From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
Subject: Re: [PATCH] drm/i915: add energy counter support for IVB
Date: Wed, 20 Jun 2012 13:17:18 -0300
Message-ID: <4FE1F78E.4040105@linux.intel.com>
References: <20120619132050.6a423e71@jbarnes-desktop>
	<878vfiijwo.fsf@intel.com>
	<20120620073825.GB4835@phenom.ffwll.local>
	<20120620083259.28bf0518@jbarnes-desktop>
	<1340207618_23753@CP5-2952>
	<CAKMK7uFydRpMDubAT+EU5u0o-LgOLnAm8Lsgtd2kOsv7EvWcdg@mail.gmail.com>
Reply-To: eugeni.dodonov@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id 0D0AD9E853
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 20 Jun 2012 09:24:55 -0700 (PDT)
In-Reply-To: <CAKMK7uFydRpMDubAT+EU5u0o-LgOLnAm8Lsgtd2kOsv7EvWcdg@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 06/20/2012 12:59 PM, Daniel Vetter wrote:
> On Wed, Jun 20, 2012 at 5:53 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
>> On Wed, 20 Jun 2012 08:32:59 -0700, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>>> On Wed, 20 Jun 2012 09:38:25 +0200
>>> Daniel Vetter <daniel@ffwll.ch> wrote:
>>>> And from the bikeshed departement: Can't we just print a running number? I
>>>> know, substraction is bloody hard, but for anything else than total power
>>>> consumption (e.g. graphing power over time) the running thing is imo
>>>> simpler. We've had the same discussion for the rc6 sysfs residency timers
>>>> and concluded (after Arjan yelled at us) that doing the substraction in
>>>> userspace is better, least it allows multiple userspace tools to read
>>>> this.
>>>>
>>>
>>> Yeah that's a good point; this way happened to be simpler for what I
>>> was doing, but just exposing the cooked register value (converted to
>>> ujoules) is better.  Will fix.
>>
>> And to keep it easy to parse, just make it return -ENODEV on older
>> platforms and a simple number for gen6+.
> 
> At that point you might also add the uJ suffix and move it to sysfs ;-)

And as a final minor suggestion, could we integrate this with the
/sys/kernel/debug/dri/0/i915_emon_status we have on ILK, so we could
have just one file for power readings?

Eugeni