From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
Subject: Re: [PATCH 2/3] drm/i915: disable drm agp support for
 !gen3 with kms enabled
Date: Sun, 24 Jun 2012 19:57:26 -0300
Message-ID: <4FE79B56.7070903@linux.intel.com>
References: <1340563898-3687-1-git-send-email-daniel.vetter@ffwll.ch>
	<1340563898-3687-3-git-send-email-daniel.vetter@ffwll.ch>
Reply-To: eugeni.dodonov@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id BE1BF9E908
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 24 Jun 2012 15:55:37 -0700 (PDT)
In-Reply-To: <1340563898-3687-3-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On 06/24/2012 03:51 PM, Daniel Vetter wrote:
> +	/* Only enable AGP support for gen 3. */
> +	if (intel_info->gen != 3) {
> +		driver.driver_features &=
> +			~(DRIVER_USE_AGP | DRIVER_REQUIRE_AGP);
> +	} else if (!intel_agp_enabled) {
> +		DRM_ERROR("drm/i915 can't work without intel_agp module!\n");
> +		return -ENODEV;
> +	}
> +

<bikeshed>
For the future generations of developers to touch gen3 (or something
older than gen3 :)), I'd suggest to expand the comment to explain why we
need it on gen3 and not on all the other gens. I haven't seen this
commented in any other agpgart killing patches, so perhaps this would be
the best place.
</bikeshed>

Eugeni