From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
Subject: Re: [PATCH 2/5] drm/i915: make
 enable/disable_gt_powersave locking consistent
Date: Sun, 24 Jun 2012 20:03:37 -0300
Message-ID: <4FE79CC9.6010403@linux.intel.com>
References: <1340548956-4097-1-git-send-email-daniel.vetter@ffwll.ch>
	<1340548956-4097-3-git-send-email-daniel.vetter@ffwll.ch>
Reply-To: eugeni.dodonov@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
	by gabe.freedesktop.org (Postfix) with ESMTP id 475C79EBF0
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 24 Jun 2012 16:01:50 -0700 (PDT)
In-Reply-To: <1340548956-4097-3-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On 06/24/2012 11:42 AM, Daniel Vetter wrote:
> The enable functions grabbed dev->struct_mutex themselves, whereas
> the disable functions expected dev->struct_mutex to be held by the
> caller. Move the locking out to the (currently only) callsite of
> intel_enable_gt_powersave to make this more consistent.
> 
> Originally this was prep work for future patches, but I've chased down
> a totally wrong alley. Still, I think this is a sensible
> clarification.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Reviewed-by: Eugeni Dodonov <eugeni.dodonov@intel.com>

Eugeni