From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eugeni Dodonov <eugeni.dodonov@linux.intel.com>
Subject: Re: [PATCH] drm/i915: expose energy counter on SNB and
 IVB
Date: Sun, 24 Jun 2012 20:13:28 -0300
Message-ID: <4FE79F18.9090705@linux.intel.com>
References: <1340228938-16489-1-git-send-email-jbarnes@virtuousgeek.org>
	<20120622190429.63becd32@bwidawsk.net>
	<20120624100124.GA5087@phenom.ffwll.local>
Reply-To: eugeni.dodonov@intel.com
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [143.182.124.37])
	by gabe.freedesktop.org (Postfix) with ESMTP id 1EA799EC76
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 24 Jun 2012 16:11:41 -0700 (PDT)
In-Reply-To: <20120624100124.GA5087@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Ben Widawsky <ben@bwidawsk.net>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 06/24/2012 07:01 AM, Daniel Vetter wrote:
> On Fri, Jun 22, 2012 at 07:04:29PM -0700, Ben Widawsky wrote:
>> On Wed, 20 Jun 2012 14:48:58 -0700
>> Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
>>> +static struct attribute *gt_attrs[] = {
>>> +	&dev_attr_gt_energy_uJ.attr,
>>> +	NULL,
>>> +};
>>
>> I think convention dictates it should be all lowercase. And while on
>> that, gt_energy_uJ is about as descriptive a name as rc6 (what jerk
>> named that anyway?). I think something like consumed_microjoules is
>> better.
> 
> I admit that the uJ makes tons of sense for me - J is the official SI
> abbrev. for joules (I'm a bit unsure about u for \mu, but it seems to be
> customary). Adding consumed makes some sense I think, but otherwise it's
> imo good if we stick with the names vpg ppl have come up. So
> gt_consumed_energy_uJ anyone? I can bikeshed this name while applying ...
> -Daniel

<bikeshed>
I'd vote for gt_energy or gt_consumed_energy, which would provide
results in plain J instead of mJ or uJ. This would result in a smaller
name + power readings which are standardized.
</bikeshed>

But if we settle on uJ values, gt_consumed_energy_uJ seems to be more
self-explainable to me.

Eugeni