From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeni Dodonov Subject: Re: [PATCH] drm/i915: disable drm agp support for !gen3 with kms enabled Date: Mon, 25 Jun 2012 12:47:28 -0300 Message-ID: <4FE88810.3000604@linux.intel.com> References: <20120625072220.GB4708@phenom.ffwll.local> <1340632729-6048-1-git-send-email-daniel.vetter@ffwll.ch> Reply-To: eugeni.dodonov@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 765D89F00F for ; Mon, 25 Jun 2012 08:45:38 -0700 (PDT) In-Reply-To: <1340632729-6048-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On 06/25/2012 10:58 AM, Daniel Vetter wrote: > This is the quick&dirty way Dave Airlie suggested to workaround the > midlayer drm agp brain-damange. Note that i915_probe is only called > when the driver has ksm enabled, so no need to check for that. > > We also need to move the intel_agp_enabled check at the right place. > Note that the only thing this does is enforce the correct module load > order (by using a symbol from intel-agp.ko) to ensure that the fake > agp driver is ready before the drm core tries to set up the agp stuff. > > v2: Add a comment to explain why gen3 needs all this legacy fake agp > stuff - we've shipped an XvMC library with a kms-enabled ddx that > requires it (but only on gen3). > > v3: Make it clear that this is really a gen3 issue only in the > comment. > > Signed-Off-by: Daniel Vetter Reviewed-by: Eugeni Dodonov Eugeni