From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeni Dodonov Subject: Re: [PATCH 13/21] drm/i915: add RPS configuration for Haswell Date: Fri, 29 Jun 2012 10:49:50 -0300 Message-ID: <4FEDB27E.9070903@linux.intel.com> References: <1340909749-15249-1-git-send-email-eugeni.dodonov@intel.com> <1340909749-15249-14-git-send-email-eugeni.dodonov@intel.com> <20120629095633.GA5463@phenom.ffwll.local> Reply-To: eugeni.dodonov@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id E2C5A9E775 for ; Fri, 29 Jun 2012 06:47:45 -0700 (PDT) In-Reply-To: <20120629095633.GA5463@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov List-Id: intel-gfx@lists.freedesktop.org On 06/29/2012 06:56 AM, Daniel Vetter wrote: > Ok, after reviewing this with the gen6 code and hsw power doc I see very > few differences (besides the 2 things that look like mistakes): > - we don't set a few things related to rc6p&rc6pp > - we have slightly different timeout/threshold values. > > When copy&pasting code we should balance the risk of introducing > regressions with the risk to not apply bugfixes everywhere they're needed. > Given that you've missed Jesse's fix while hacking on this and that this > seems to work very much like rps on snb/ivb I'd vote for sprinkling a few > ifs into gen6_enable_rps. Maybe set the timing values in local variables > at the beginning of the function. Sure, I'll do this and send the patch. Eugeni