From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeni Dodonov Subject: Re: [PATCH 07/21] drm/i915: re-initialize DDI buffer translations after resume Date: Wed, 04 Jul 2012 20:13:50 -0300 Message-ID: <4FF4CE2E.1050300@linux.intel.com> References: <1340909749-15249-1-git-send-email-eugeni.dodonov@intel.com> <1340909749-15249-8-git-send-email-eugeni.dodonov@intel.com> <20120704203506.GG5375@phenom.ffwll.local> Reply-To: eugeni.dodonov@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id E0EDD9E7F4 for ; Wed, 4 Jul 2012 16:11:34 -0700 (PDT) In-Reply-To: <20120704203506.GG5375@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov List-Id: intel-gfx@lists.freedesktop.org On 07/04/2012 05:35 PM, Daniel Vetter wrote: > On Wed, Jul 04, 2012 at 05:07:39PM -0300, Paulo Zanoni wrote: >> 2012/6/28 Eugeni Dodonov : >>> This is necessary for the modesetting to work correctly after a >>> suspend-resume cycle. Without this, the pipes and clocks got the correct >>> configuration, but the underlying DDI buffers configuration was lost. >>> >>> Signed-off-by: Eugeni Dodonov >> >> I couldn't make suspend/resume work on my machine yet, but running >> intel_prepare_ddi again after resume won't hurt us, so: >> >> Reviewed-by: Paulo Zanoni > > Queued for -next, thanks for the patch. Quick aside: I think we have a > similar issue with the hsw power well init code. Yes, I'll send the power wells patch until the end of the week as well, sorry for taking that long! Eugeni