From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeni Dodonov Subject: Re: [PATCH 19/21] drm/i915: prevent bogus intel_update_fbc notifications Date: Wed, 04 Jul 2012 20:19:24 -0300 Message-ID: <4FF4CF7C.6070401@linux.intel.com> References: <20120628192411.GF5596@phenom.ffwll.local> <1340914303-32278-1-git-send-email-eugeni.dodonov@intel.com> Reply-To: eugeni.dodonov@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 717949E7F4 for ; Wed, 4 Jul 2012 16:17:09 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org, Eugeni Dodonov List-Id: intel-gfx@lists.freedesktop.org On 07/04/2012 02:41 PM, Paulo Zanoni wrote: > 2012/6/28 Eugeni Dodonov : >> This pollutes dmesg output even if we do not have FBC for the device, so >> move the DRM_DEBUG_KMS statement lower. >> >> v2: just kill the message as suggested by Daniel. >> >> Signed-off-by: Eugeni Dodonov > > The message first says we "move the statement lower", but then later > it says we kill the message :) > With that fixed: > > Reviewed-by: Paulo Zanoni > > I'm happy with both v1 and v2. I'll let Daniel decide the bike shed color on this one :). We can always say that 'move it down' was a slang term for 'killing' later :). Eugeni