From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v6 7/7] drm/i915: add a sysfs entry to let users set sseu configs Date: Wed, 23 May 2018 16:30:13 +0100 Message-ID: <4abc7173-35df-5bd7-5da8-13bec29c5d90@linux.intel.com> References: <20180522180002.11522-1-lionel.g.landwerlin@intel.com> <20180522180002.11522-8-lionel.g.landwerlin@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 56B0F6E515 for ; Wed, 23 May 2018 15:30:15 +0000 (UTC) In-Reply-To: <20180522180002.11522-8-lionel.g.landwerlin@intel.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Lionel Landwerlin , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDIyLzA1LzIwMTggMTk6MDAsIExpb25lbCBMYW5kd2VybGluIHdyb3RlOgo+IFRoZXJlIGFy ZSBjb25jZXJucyBhYm91dCBkZW5pYWwgb2Ygc2VydmljZSBhcm91bmQgdGhlIHBlciBjb250ZXh0 IHNzZXUKPiBjb25maWd1cmF0aW9uIGNhcGFiaWxpdHkuIEluIGEgcHJldmlvdXMgY29tbWl0IGlu dHJvZHVjaW5nIHRoZQo+IGNhcGFiaWxpdHkgd2UgYWxsb3dlZCBpdCBvbmx5IGZvciBjYXBhYmxl IHVzZXJzLiBUaGlzIGNoYW5nZXMgYWRkcyBhCj4gbmV3IGRlYnVnZnMgZW50cnkgdG8gbGV0IGFu eSB1c2VyIGNvbmZpZ3VyZSBpdHMgb3duIGNvbnRleHQKPiBwb3dlcmdhdGluZyBzZXR1cC4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBMaW9uZWwgTGFuZHdlcmxpbiA8bGlvbmVsLmcubGFuZHdlcmxpbkBp bnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAg ICAgfCAgNSArKysKPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2NvbnRleHQuYyB8 IDUyICsrKysrKysrKysrKysrKysrKysrKysrKy0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfc3lzZnMuYyAgICAgICB8IDMwICsrKysrKysrKysrKysrCj4gICAzIGZpbGVzIGNoYW5nZWQs IDg2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmgKPiBpbmRleCAwOWNmY2ZlMWMzMzkuLjBmY2NlYzI5ZmRkYSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aTkxNV9kcnYuaAo+IEBAIC0xODQzLDYgKzE4NDMsOCBAQCBzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSB7Cj4gICAJCXN0cnVjdCBpZGEgaHdfaWRhOwo+ICAgI2RlZmluZSBNQVhfQ09OVEVYVF9IV19J RCAoMTw8MjEpIC8qIGV4Y2x1c2l2ZSAqLwo+ICAgI2RlZmluZSBHRU4xMV9NQVhfQ09OVEVYVF9I V19JRCAoMTw8MTEpIC8qIGV4Y2x1c2l2ZSAqLwo+ICsKPiArCQlib29sIGFsbG93X3NzZXU7CgpJ IHRoaW5rIHNwZWxsaW5nIG91dCAiZHluYW1pYyIgaW4gcGF0Y2ggdGl0bGVzLCBjb21taXQgbWVz c2FnZXMgYW5kIGV2ZW4gCmluIHRoaXMgdmFyaWFibGUgbmFtZSB3b3VsZCBiZSBiZXR0ZXIgYW5k IGNsZWFyZXIuCgo+ICAgCX0gY29udGV4dHM7Cj4gICAKPiAgIAl1MzIgZmRpX3J4X2NvbmZpZzsK PiBAQCAtMzI3NCw2ICszMjc2LDkgQEAgaTkxNV9nZW1fY29udGV4dF9sb29rdXAoc3RydWN0IGRy bV9pOTE1X2ZpbGVfcHJpdmF0ZSAqZmlsZV9wcml2LCB1MzIgaWQpCj4gICAJcmV0dXJuIGN0eDsK PiAgIH0KPiAgIAo+ICtpbnQgaTkxNV9nZW1fY29udGV4dHNfc2V0X2FsbG93X3NzZXUoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBib29sIGFsbG93ZWQpOwo+ICtib29sIGk5MTVf Z2VtX2NvbnRleHRzX2dldF9hbGxvd19zc2V1KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdik7Cj4gKwo+ICAgaW50IGk5MTVfcGVyZl9vcGVuX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYsIHZvaWQgKmRhdGEsCj4gICAJCQkgc3RydWN0IGRybV9maWxlICpmaWxlKTsKPiAgIGlu dCBpOTE1X3BlcmZfYWRkX2NvbmZpZ19pb2N0bChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lk ICpkYXRhLAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250 ZXh0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9jb250ZXh0LmMKPiBpbmRleCA1 YzVhMTJmMWMyNjUuLjgxNWE5ZDFjMjlmMyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbV9jb250ZXh0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9jb250ZXh0LmMKPiBAQCAtOTgxLDcgKzk4MSw4IEBAIGludCBpOTE1X2dlbV9jb250ZXh0 X3NldHBhcmFtX2lvY3RsKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gICAJ CQkJYnJlYWs7Cj4gICAJCQl9Cj4gICAKPiAtCQkJaWYgKCFjYXBhYmxlKENBUF9TWVNfQURNSU4p KSB7Cj4gKwkJCWlmICghZGV2X3ByaXYtPmNvbnRleHRzLmFsbG93X3NzZXUgJiYKPiArCQkJICAg ICFjYXBhYmxlKENBUF9TWVNfQURNSU4pKSB7CgpTbyB0aGUgdGhpbmcgSSBtZW50aW9uZWQgaW4g dGhlIHByZXZpb3VzIHBhdGNoLiBNeSB0aGlua2luZyB3YXMgbm90IHRvIApmYWlsIGl0IGlmIHN5 c2ZzIHRvZ2dsZSBpcyBkaXNhYmxlZCwgYnV0IGp1c3QgZG9uJ3QgZG8gZHluYW1pYyAKc3dpdGNo aW5nLiBUaGF0IHdheSB0aGUgc29mdHdhcmUgc3RhY2sgd29ya3MgaW4gYWxsIGNhc2VzIGJ1dCB1 c2VyIGhhcyAKdGhlIG9wdGlvbiBvZiB0dW5pbmcgaGlzIHN5c3RlbS4KCkkgbWVhbiBpdCBjYW4g c3RpbGwgYmUgZG9uZSBidXQgaW4gdXNlcnNwYWNlLiBTZXQgcGFyYW0gZmFpbHMsIHVzZXJzcGFj ZSAKZ29lcyBmb3IgYSBmYWxsIGJhY2suCgpPbmx5IGRpZmZlcmVuY2UgaXMgSSBndWVzcyB3aGV0 aGVyIGl0IGlzIHVzZWZ1bCB0byBhbGxvdyBzd2l0Y2hpbmcgYXQgCnJ1bnRpbWUuIEkgYW0gaW1h Z2luaW5nIHJ1bm5pbmcgc29tZSAzZCBhbmQgbWVkaWEsIGFuZCB0aGVuIHRvZ2dsaW5nIHRoZSAK a25vYiB0byBzZWUgd2hhdCBoYXBwZW5zIHRvIHBvd2VyIGFuZCBwZXJmb3JtYW5jZSBvbiB0aGUg Zmx5LiBCdXQgbWF5YmUgCnRoYXQgaXMgbm90IHNvIGludGVyZXN0aW5nLgoKQWxvbmcgdGhlIHNh bWUgbGluZXMgSSB3YXMgdGhpbmtpbmcgQ0FQX1NZU19BRE1JTiBsaW1pdGF0aW9uIGNvdWxkIGJl IApkcm9wcGVkLgoKQm90aCBwb2ludHMgYXJlIGZvciBhIHdpZGVyIGRpc2N1c3Npb24gSSBndWVz cy4KCj4gICAJCQkJcmV0ID0gLUVQRVJNOwo+ICAgCQkJCWJyZWFrOwo+ICAgCQkJfQo+IEBAIC0x MDU4LDYgKzEwNTksNTUgQEAgaW50IGk5MTVfZ2VtX2NvbnRleHRfcmVzZXRfc3RhdHNfaW9jdGwo c3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgIAlyZXR1cm4gcmV0Owo+ICAgfQo+ICAgCj4gK2lu dCBpOTE1X2dlbV9jb250ZXh0c19zZXRfYWxsb3dfc3NldShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYsCj4gKwkJCQkgICAgIGJvb2wgYWxsb3dlZCkKPiArewo+ICsJc3RydWN0IGlu dGVsX2VuZ2luZV9jcyAqZW5naW5lID0gZGV2X3ByaXYtPmVuZ2luZVtSQ1NdOwo+ICsJaW50IHJl dCA9IDA7Cj4gKwo+ICsJaWYgKCFlbmdpbmUtPmVtaXRfcnBjc19jb25maWcpCj4gKwkJcmV0dXJu IC1FTk9ERVY7Cj4gKwo+ICsJbXV0ZXhfbG9jaygmZGV2X3ByaXYtPmRybS5zdHJ1Y3RfbXV0ZXgp OwoKVGhpcyBzaG91bGQgYmUgaW50ZXJydXB0aWJsZSBzbyB1c2VyIGNhbiBDdHJsLUMgaWYgaXQg aXMgc3R1Y2suCgo+ICsKPiArCS8qCj4gKwkgKiBXaGVuIHdlIGFsbG93IGVhY2ggY29udGV4dCB0 byBjb25maWd1cmUgaXRzIHBvd2VyZ2F0aW5nCj4gKwkgKiBjb25maWd1cmF0aW9uLCB0aGVyZSBp cyBubyBuZWVkIHRvIHB1dCB0aGUgY29uZmlndXJhdGlvbnMgYmFjayB0bwo+ICsJICogdGhlIGRl ZmF1bHQsIGl0IHNob3VsZCBhbHJlYWR5IGJlIHRoZSBjYXNlLgo+ICsJICovCj4gKwlpZiAoIWFs bG93ZWQpIHsKPiArCQl1bmlvbiBpbnRlbF9zc2V1IGRlZmF1bHRfc3NldSA9Cj4gKwkJCWludGVs X3NzZXVfZnJvbV9kZXZpY2Vfc3NldSgmSU5URUxfSU5GTyhkZXZfcHJpdiktPnNzZXUpOwo+ICsJ CXN0cnVjdCBpOTE1X2dlbV9jb250ZXh0ICpjdHg7Cj4gKwo+ICsJCWxpc3RfZm9yX2VhY2hfZW50 cnkoY3R4LCAmZGV2X3ByaXYtPmNvbnRleHRzLmxpc3QsIGxpbmspIHsKPiArCQkJcmV0ID0gaTkx NV9nZW1fY29udGV4dF9yZWNvbmZpZ3VyZV9zc2V1KGN0eCwgZW5naW5lLAo+ICsJCQkJCQkJCWRl ZmF1bHRfc3NldSk7Cj4gKwkJCWlmIChyZXQpCj4gKwkJCQlicmVhazsKPiArCQl9Cj4gKwl9Cj4g Kwo+ICsJZGV2X3ByaXYtPmNvbnRleHRzLmFsbG93X3NzZXUgPSBhbGxvd2VkOwo+ICsKPiArCW11 dGV4X3VubG9jaygmZGV2X3ByaXYtPmRybS5zdHJ1Y3RfbXV0ZXgpOwo+ICsJcmV0dXJuIHJldDsK PiArfQo+ICsKPiArYm9vbCBpOTE1X2dlbV9jb250ZXh0c19nZXRfYWxsb3dfc3NldShzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gK3sKPiArCXN0cnVjdCBpbnRlbF9lbmdpbmVf Y3MgKmVuZ2luZSA9IGRldl9wcml2LT5lbmdpbmVbUkNTXTsKPiArCWJvb2wgcmV0Owo+ICsKPiAr CWlmICghZW5naW5lLT5lbWl0X3JwY3NfY29uZmlnKQo+ICsJCXJldHVybiBmYWxzZTsKPiArCj4g KwltdXRleF9sb2NrKCZkZXZfcHJpdi0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4gKwlyZXQgPSBkZXZf cHJpdi0+Y29udGV4dHMuYWxsb3dfc3NldTsKPiArCW11dGV4X3VubG9jaygmZGV2X3ByaXYtPmRy bS5zdHJ1Y3RfbXV0ZXgpOwoKSSBndWVzcyB0aGlzIG11dGV4IGRvZXMgbm90aGluZyBpbiB0aGlz IGNhc2UuCgo+ICsJcmV0dXJuIHJldDsKPiArfQo+ICsKPiAgICNpZiBJU19FTkFCTEVEKENPTkZJ R19EUk1fSTkxNV9TRUxGVEVTVCkKPiAgICNpbmNsdWRlICJzZWxmdGVzdHMvbW9ja19jb250ZXh0 LmMiCj4gICAjaW5jbHVkZSAic2VsZnRlc3RzL2k5MTVfZ2VtX2NvbnRleHQuYyIKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zeXNmcy5jIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9zeXNmcy5jCj4gaW5kZXggZTVlNmY2YmIyYjA1Li45ZmQxNWIxMzhhYzkgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zeXNmcy5jCj4gKysrIGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9zeXNmcy5jCj4gQEAgLTQ4Myw2ICs0ODMsMzQgQEAgc3Rh dGljIHNzaXplX3QgZ3RfcnBfbWh6X3Nob3coc3RydWN0IGRldmljZSAqa2Rldiwgc3RydWN0IGRl dmljZV9hdHRyaWJ1dGUgKmF0dHIKPiAgIAlyZXR1cm4gc25wcmludGYoYnVmLCBQQUdFX1NJWkUs ICIlZFxuIiwgdmFsKTsKPiAgIH0KPiAgIAo+ICtzdGF0aWMgc3NpemVfdCBnZW1fYWxsb3dfc3Nl dV9zaG93KHN0cnVjdCBkZXZpY2UgKmtkZXYsCj4gKwkJCQkgICBzdHJ1Y3QgZGV2aWNlX2F0dHJp YnV0ZSAqYXR0ciwgY2hhciAqYnVmKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAq ZGV2X3ByaXYgPSBrZGV2X21pbm9yX3RvX2k5MTUoa2Rldik7Cj4gKwlpbnQgcmV0ID0gaTkxNV9n ZW1fY29udGV4dHNfZ2V0X2FsbG93X3NzZXUoZGV2X3ByaXYpOwo+ICsKPiArCXJldHVybiBzbnBy aW50ZihidWYsIFBBR0VfU0laRSwgIiVkXG4iLCByZXQpOwoKUHJvcGFnYXRlIEVOT0RFViBhbGwg dGhlIHdheSBieSBtYWtpbmcgaTkxNV9nZW1fY29udGV4dHNfZ2V0X2FsbG93X3NzZXUgCnJldHVy biBhbiBpbnQ/Cgo+ICt9Cj4gKwo+ICtzdGF0aWMgc3NpemVfdCBnZW1fYWxsb3dfc3NldV9zdG9y ZShzdHJ1Y3QgZGV2aWNlICprZGV2LAo+ICsJCQkJICAgIHN0cnVjdCBkZXZpY2VfYXR0cmlidXRl ICphdHRyLAo+ICsJCQkJICAgIGNvbnN0IGNoYXIgKmJ1Ziwgc2l6ZV90IGNvdW50KQo+ICt7Cj4g KwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBrZGV2X21pbm9yX3RvX2k5MTUo a2Rldik7Cj4gKwl1MzIgdmFsOwo+ICsJc3NpemVfdCByZXQ7CgpDaHJpcyB3aWxsIGNvbXBsYWlu IGFib3V0IENocmlzdG1hcyB0cmVlcy4gOikKCihBbmQgcG9zc2libGUgYWJvdXQgbmV3IHVzZSBv ZiBkZXZfcHJpdiB0aHJvdWdob3V0IHRoZSBzZXJpZXMgYnV0IHRoYXQgCmJhdHRsZSBpcyBpbiBz dGFsZSBtYXRlLikKCj4gKwo+ICsJcmV0ID0ga3N0cnRvdTMyKGJ1ZiwgMCwgJnZhbCk7Cj4gKwlp ZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ICsJaTkxNV9nZW1fY29udGV4dHNfc2V0X2Fs bG93X3NzZXUoZGV2X3ByaXYsIHZhbCAhPSAwKTsKCkkgd291bGQgZW5mb3JjZSAwIG9yIDEgdG8g YWxsb3cgKGh5cG90aGV0aWNhbCkgZnV0dXJlIGV4cGFuc2lvbiB3aXRoIAptb3JlIHZhbHVlcy4K Cj4gKwo+ICsJcmV0dXJuIHJldCA/OiBjb3VudDsKPiArfQo+ICsKPiArc3RhdGljIERFVklDRV9B VFRSX1JXKGdlbV9hbGxvd19zc2V1KTsKCkkgd291bGQgbGlrZSB0byBvcGVuIHVwIGEgcm91bmQg b2YgYmlrZS1zaGVkZGluZyBvZiB0aGUga25vYiBuYW1lLiA6KQoKSG93IGFib3V0IGFsbG93X2R5 bmFtaWNfc3NldT8gZ2VtXyBvciBub3QsIGRvbid0IGtub3cuCgo+ICsKPiAgIHN0YXRpYyBjb25z dCBzdHJ1Y3QgYXR0cmlidXRlICpnZW42X2F0dHJzW10gPSB7Cj4gICAJJmRldl9hdHRyX2d0X2Fj dF9mcmVxX21oei5hdHRyLAo+ICAgCSZkZXZfYXR0cl9ndF9jdXJfZnJlcV9taHouYXR0ciwKPiBA QCAtNDkyLDYgKzUyMCw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgYXR0cmlidXRlICpnZW42X2F0 dHJzW10gPSB7Cj4gICAJJmRldl9hdHRyX2d0X1JQMF9mcmVxX21oei5hdHRyLAo+ICAgCSZkZXZf YXR0cl9ndF9SUDFfZnJlcV9taHouYXR0ciwKPiAgIAkmZGV2X2F0dHJfZ3RfUlBuX2ZyZXFfbWh6 LmF0dHIsCj4gKwkmZGV2X2F0dHJfZ2VtX2FsbG93X3NzZXUuYXR0ciwKPiAgIAlOVUxMLAo+ICAg fTsKPiAgIAo+IEBAIC01MDUsNiArNTM0LDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBhdHRyaWJ1 dGUgKnZsdl9hdHRyc1tdID0gewo+ICAgCSZkZXZfYXR0cl9ndF9SUDFfZnJlcV9taHouYXR0ciwK PiAgIAkmZGV2X2F0dHJfZ3RfUlBuX2ZyZXFfbWh6LmF0dHIsCj4gICAJJmRldl9hdHRyX3Zsdl9y cGVfZnJlcV9taHouYXR0ciwKPiArCSZkZXZfYXR0cl9nZW1fYWxsb3dfc3NldS5hdHRyLAo+ICAg CU5VTEwsCj4gICB9Owo+ICAgCj4gCgpSZWdhcmRzLAoKVHZydGtvCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=