From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michel Thierry Subject: Re: [PATCH] intel: Future-proof ring names for aubinator_error_decode Date: Thu, 18 Jan 2018 08:44:18 -0800 Message-ID: <4adfa908-7d4d-ff11-b870-6f8f7463e20e@intel.com> References: <20180117154705.24628-1-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180117154705.24628-1-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , mesa-dev@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, Kenneth Graunke List-Id: intel-gfx@lists.freedesktop.org T24gMS8xNy8yMDE4IDc6NDcgQU0sIENocmlzIFdpbHNvbiB3cm90ZToKPiBUaGUga2VybmVsIGlz IG1vdmluZyB0byBhICRjbGFzcyRpbnN0YW5jZSBuYW1pbmcgc2NoZW1lIGluIHByZXBhcmF0aW9u Cj4gZm9yIGFjY29tbW9kYXRpbmcgbW9yZSByaW5ncyBpbiB0aGUgZnV0dXJlIGluIGEgY29uc2lz dGVudCBtYW5uZXIuIEl0IGlzCj4gYWxyZWFkeSB1c2luZyB0aGUgbmFtaW5nIHNjaGVtZSBpbnRl cm5hbGx5LCBhbmQgbm93IHdlIGFyZSBsb29raW5nIGF0Cj4gdXBkYXRpbmcgc29tZSBzb2Z0LUFC SSBzdWNoIGFzIHRoZSBlcnJvciBzdGF0ZSB0byB1c2UgdGhlIG5ldyBuYW1pbmcKPiBzY2hlbWUu IFRoaXMgb2YgY291cnNlIG1lYW5zIHdlIG5lZWQgdG8gdGVhY2ggYXViaW5hdG9yX2Vycm9yX2Rl Y29kZSBob3cKPiB0byBtYXAgYm90aCBzZXRzIG9mIHJpbmcgbmFtZXMgb250byBpdHMgcmVnaXN0 ZXIgbWFwcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdp bHNvbi5jby51az4KPiBDYzogTWljaGVsIFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNv bT4KPiBDYzogTWljaGFsIFdhamRlY3prbyA8bWljaGFsLndhamRlY3prb0BpbnRlbC5jb20+Cj4g Q2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6 IExpb25lbCBMYW5kd2VybGluIDxsaW9uZWwuZy5sYW5kd2VybGluQGludGVsLmNvbT4KPiBDYzog S2VubmV0aCBHcmF1bmtlIDxrZW5uZXRoQHdoaXRlY2FwZS5vcmc+Cj4gLS0tCj4gICBzcmMvaW50 ZWwvdG9vbHMvYXViaW5hdG9yX2Vycm9yX2RlY29kZS5jIHwgMTIyICsrKysrKysrKysrKysrKysr KysrKysrKystLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA5OCBpbnNlcnRpb25zKCspLCAyNCBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvc3JjL2ludGVsL3Rvb2xzL2F1YmluYXRvcl9l cnJvcl9kZWNvZGUuYyBiL3NyYy9pbnRlbC90b29scy9hdWJpbmF0b3JfZXJyb3JfZGVjb2RlLmMK PiBpbmRleCA5ZGQ3MDc5MGUxLi4wMWM2YTdhMzY1IDEwMDY0NAo+IC0tLSBhL3NyYy9pbnRlbC90 b29scy9hdWJpbmF0b3JfZXJyb3JfZGVjb2RlLmMKPiArKysgYi9zcmMvaW50ZWwvdG9vbHMvYXVi aW5hdG9yX2Vycm9yX2RlY29kZS5jCj4gQEAgLTc0LDQwICs3NCw5NSBAQCBwcmludF9yZWdpc3Rl cihzdHJ1Y3QgZ2VuX3NwZWMgKnNwZWMsIGNvbnN0IGNoYXIgKm5hbWUsIHVpbnQzMl90IHJlZykK PiAgIH0KPiAgIAo+ICAgc3RydWN0IHJpbmdfcmVnaXN0ZXJfbWFwcGluZyB7Cj4gLSAgIGNvbnN0 IGNoYXIgKnJpbmdfbmFtZTsKPiArICAgdW5zaWduZWQgcmluZ19jbGFzczsKPiArICAgdW5zaWdu ZWQgcmluZ19pbnN0YW5jZTsKPiAgICAgIGNvbnN0IGNoYXIgKnJlZ2lzdGVyX25hbWU7Cj4gICB9 Owo+ICAgCj4gK2VudW0gewo+ICsgICBSQ1MsCj4gKyAgIEJDUywKPiArICAgVkNTLAo+ICsgICBW RUNTLAo+ICt9Owo+ICsKPiAgIHN0YXRpYyBjb25zdCBzdHJ1Y3QgcmluZ19yZWdpc3Rlcl9tYXBw aW5nIGFjdGhkX3JlZ2lzdGVyc1tdID0gewo+IC0gICB7ICJibHQiLCAiQkNTX0FDVEhEX1VEVyIg fSwKPiAtICAgeyAiYnNkIiwgIlZDU19BQ1RIRF9VRFciIH0sCj4gLSAgIHsgImJzZDIiLCAiVkNT Ml9BQ1RIRF9VRFciIH0sCj4gLSAgIHsgInJlbmRlciIsICJBQ1RIRF9VRFciIH0sCj4gLSAgIHsg InZlYm94IiwgIlZFQ1NfQUNUSERfVURXIiB9LAo+ICsgICB7IEJDUywgMCwgIkJDU19BQ1RIRF9V RFciIH0sCj4gKyAgIHsgVkNTLCAwLCAiVkNTX0FDVEhEX1VEVyIgfSwKPiArICAgeyBWQ1MsIDEs ICJWQ1MyX0FDVEhEX1VEVyIgfSwKPiArICAgeyBSQ1MsIDAsICJBQ1RIRF9VRFciIH0sCj4gKyAg IHsgVkVDUywgMCwgIlZFQ1NfQUNUSERfVURXIiB9LAo+ICAgfTsKPiAgIAo+ICAgc3RhdGljIGNv bnN0IHN0cnVjdCByaW5nX3JlZ2lzdGVyX21hcHBpbmcgY3RsX3JlZ2lzdGVyc1tdID0gewo+IC0g ICB7ICJibHQiLCAiQkNTX1JJTkdfQlVGRkVSX0NUTCIgfSwKPiAtICAgeyAiYnNkIiwgIlZDU19S SU5HX0JVRkZFUl9DVEwiIH0sCj4gLSAgIHsgImJzZDIiLCAiVkNTMl9SSU5HX0JVRkZFUl9DVEwi IH0sCj4gLSAgIHsgInJlbmRlciIsICJSQ1NfUklOR19CVUZGRVJfQ1RMIiB9LAo+IC0gICB7ICJ2 ZWJveCIsICJWRUNTX1JJTkdfQlVGRkVSX0NUTCIgfSwKPiArICAgeyBCQ1MsIDAsICJCQ1NfUklO R19CVUZGRVJfQ1RMIiB9LAo+ICsgICB7IFZDUywgMCwgIlZDU19SSU5HX0JVRkZFUl9DVEwiIH0s Cj4gKyAgIHsgVkNTLCAxLCAiVkNTMl9SSU5HX0JVRkZFUl9DVEwiIH0sCj4gKyAgIHsgUkNTLCAw LCAiUkNTX1JJTkdfQlVGRkVSX0NUTCIgfSwKPiArICAgeyBWRUNTLCAwLCAgIlZFQ1NfUklOR19C VUZGRVJfQ1RMIiB9LAo+ICAgfTsKPiAgIAo+ICAgc3RhdGljIGNvbnN0IHN0cnVjdCByaW5nX3Jl Z2lzdGVyX21hcHBpbmcgZmF1bHRfcmVnaXN0ZXJzW10gPSB7Cj4gLSAgIHsgImJsdCIsICJCQ1Nf RkFVTFRfUkVHIiB9LAo+IC0gICB7ICJic2QiLCAiVkNTX0ZBVUxUX1JFRyIgfSwKPiAtICAgeyAi cmVuZGVyIiwgIlJDU19GQVVMVF9SRUciIH0sCj4gLSAgIHsgInZlYm94IiwgIlZFQ1NfRkFVTFRf UkVHIiB9LAo+ICsgICB7IEJDUywgMCwgIkJDU19GQVVMVF9SRUciIH0sCj4gKyAgIHsgVkNTLCAw LCAiVkNTX0ZBVUxUX1JFRyIgfSwKPiArICAgeyBSQ1MsIDAsICJSQ1NfRkFVTFRfUkVHIiB9LAo+ ICsgICB7IFZFQ1MsIDAsICJWRUNTX0ZBVUxUX1JFRyIgfSwKPiAgIH07Cj4gICAKPiArc3RhdGlj IGludCByaW5nX25hbWVfdG9fY2xhc3MoY29uc3QgY2hhciAqcmluZ19uYW1lLAo+ICsgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25lZCBpbnQgKmNsYXNzKQo+ICt7Cj4gKyAgIHN0 YXRpYyBjb25zdCBjaGFyICpjbGFzc19uYW1lc1tdID0gewo+ICsgICAgICBbUkNTXSA9ICJyY3Mi LAo+ICsgICAgICBbQkNTXSA9ICJiY3MiLAo+ICsgICAgICBbVkNTXSA9ICJ2Y3MiLAo+ICsgICAg ICBbVkVDU10gPSAidmVjcyIsCj4gKyAgIH07CgpUaGlzIHdpbGwgbWF0Y2ggdGhlIG5ldyBuYW1l cyBpbiB0aGUgZXJyb3Igc3RhdGUsIGUuZy4KCnJjczAgY29tbWFuZCBzdHJlYW06Ci4uLgpiY3Mw IGNvbW1hbmQgc3RyZWFtOgouLi4KdmNzMCBjb21tYW5kIHN0cmVhbToKLi4uCnZjczEgY29tbWFu ZCBzdHJlYW06Ci4uLgp2ZWNzMCBjb21tYW5kIHN0cmVhbToKLi4uCgo+ICsgICBmb3IgKHNpemVf dCBpID0gMDsgaSA8IEFSUkFZX1NJWkUoY2xhc3NfbmFtZXMpOyBpKyspIHsKPiArICAgICAgaWYg KHN0cmNtcChyaW5nX25hbWUsIGNsYXNzX25hbWVzW2ldKSkKPiArICAgICAgICAgY29udGludWU7 Cj4gKwo+ICsgICAgICAqY2xhc3MgPSBpOwo+ICsgICAgICByZXR1cm4gYXRvaShyaW5nX25hbWUg KyBzdHJsZW4oY2xhc3NfbmFtZXNbaV0pKTsKPiArICAgfQo+ICsKPiArICAgc3RhdGljIGNvbnN0 IHN0cnVjdCB7Cj4gKyAgICAgIGNvbnN0IGNoYXIgKm5hbWU7Cj4gKyAgICAgIHVuc2lnbmVkIGlu dCBjbGFzczsKPiArICAgICAgaW50IGluc3RhbmNlOwo+ICsgICB9IGxlZ2FjeV9uYW1lc1tdID0g ewo+ICsgICAgICB7ICJyZW5kZXIiLCBSQ1MsIDAgfSwKPiArICAgICAgeyAiYmx0IiwgQkNTLCAw IH0sCj4gKyAgICAgIHsgImJzZCIsIFZDUywgMCB9LAo+ICsgICAgICB7ICJic2QyIiwgVkNTLCAx IH0sCj4gKyAgICAgIHsgInZlYm94IiwgVkVDUywgMCB9LAo+ICsgICB9OwoKQW5kIHRoZXNlIGFy ZSB0aGUgY3VycmVudCBvbmVzLCBzbyBhbHNvCgpSZXZpZXdlZC1ieTogTWljaGVsIFRoaWVycnkg PG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4KCj4gKyAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwg QVJSQVlfU0laRShsZWdhY3lfbmFtZXMpOyBpKyspIHsKPiArICAgICAgaWYgKHN0cmNtcChyaW5n X25hbWUsIGxlZ2FjeV9uYW1lc1tpXS5uYW1lKSkKPiArICAgICAgICAgY29udGludWU7Cj4gKwo+ ICsgICAgICAqY2xhc3MgPSBsZWdhY3lfbmFtZXNbaV0uY2xhc3M7Cj4gKyAgICAgIHJldHVybiBs ZWdhY3lfbmFtZXNbaV0uaW5zdGFuY2U7Cj4gKyAgIH0KPiArCj4gKyAgIHJldHVybiAtMTsKPiAr fQo+ICsKPiAgIHN0YXRpYyBjb25zdCBjaGFyICoKPiAgIHJlZ2lzdGVyX25hbWVfZnJvbV9yaW5n KGNvbnN0IHN0cnVjdCByaW5nX3JlZ2lzdGVyX21hcHBpbmcgKm1hcHBpbmcsCj4gICAgICAgICAg ICAgICAgICAgICAgICAgICB1bnNpZ25lZCBuYl9tYXBwaW5nLAo+ICAgICAgICAgICAgICAgICAg ICAgICAgICAgY29uc3QgY2hhciAqcmluZ19uYW1lKQo+ICAgewo+ICsgICB1bnNpZ25lZCBpbnQg Y2xhc3M7Cj4gKyAgIGludCBpbnN0YW5jZTsKPiArCj4gKyAgIGluc3RhbmNlID0gcmluZ19uYW1l X3RvX2NsYXNzKHJpbmdfbmFtZSwgJmNsYXNzKTsKPiArICAgaWYgKGluc3RhbmNlIDwgMCkKPiAr ICAgICAgcmV0dXJuIE5VTEw7Cj4gKwo+ICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IG5i X21hcHBpbmc7IGkrKykgewo+IC0gICAgICBpZiAoc3RyY21wKG1hcHBpbmdbaV0ucmluZ19uYW1l LCByaW5nX25hbWUpID09IDApCj4gKyAgICAgIGlmIChtYXBwaW5nW2ldLnJpbmdfY2xhc3MgPT0g Y2xhc3MgJiYKPiArICAgICAgICAgIG1hcHBpbmdbaV0ucmluZ19pbnN0YW5jZSA9PSBpbnN0YW5j ZSkKPiAgICAgICAgICAgIHJldHVybiBtYXBwaW5nW2ldLnJlZ2lzdGVyX25hbWU7Cj4gICAgICB9 Cj4gICAgICByZXR1cm4gTlVMTDsKPiBAQCAtMTE3LDE2ICsxNzIsMzUgQEAgc3RhdGljIGNvbnN0 IGNoYXIgKgo+ICAgaW5zdGRvbmVfcmVnaXN0ZXJfZm9yX3JpbmcoY29uc3Qgc3RydWN0IGdlbl9k ZXZpY2VfaW5mbyAqZGV2aW5mbywKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0 IGNoYXIgKnJpbmdfbmFtZSkKPiAgIHsKPiAtICAgaWYgKHN0cmNtcChyaW5nX25hbWUsICJibHQi KSA9PSAwKQo+IC0gICAgICByZXR1cm4gIkJDU19JTlNURE9ORSI7Cj4gLSAgIGVsc2UgaWYgKHN0 cmNtcChyaW5nX25hbWUsICJ2ZWJveCIpID09IDApCj4gLSAgICAgIHJldHVybiAiVkVDU19JTlNU RE9ORSI7Cj4gLSAgIGVsc2UgaWYgKHN0cmNtcChyaW5nX25hbWUsICJic2QiKSA9PSAwKQo+IC0g ICAgICByZXR1cm4gIlZDU19JTlNURE9ORSI7Cj4gLSAgIGVsc2UgaWYgKHN0cmNtcChyaW5nX25h bWUsICJyZW5kZXIiKSA9PSAwKSB7Cj4gKyAgIHVuc2lnbmVkIGludCBjbGFzczsKPiArICAgaW50 IGluc3RhbmNlOwo+ICsKPiArICAgaW5zdGFuY2UgPSByaW5nX25hbWVfdG9fY2xhc3MocmluZ19u YW1lLCAmY2xhc3MpOwo+ICsgICBpZiAoaW5zdGFuY2UgPCAwKQo+ICsgICAgICByZXR1cm4gTlVM TDsKPiArCj4gKyAgIHN3aXRjaCAoY2xhc3MpIHsKPiArICAgY2FzZSBSQ1M6Cj4gICAgICAgICBp ZiAoZGV2aW5mby0+Z2VuID09IDYpCj4gICAgICAgICAgICByZXR1cm4gIklOU1RET05FXzIiOwo+ IC0gICAgICByZXR1cm4gIklOU1RET05FXzEiOwo+ICsgICAgICBlbHNlCj4gKyAgICAgICAgIHJl dHVybiAiSU5TVERPTkVfMSI7Cj4gKwo+ICsgICBjYXNlIEJDUzoKPiArICAgICAgcmV0dXJuICJC Q1NfSU5TVERPTkUiOwo+ICsKPiArICAgY2FzZSBWQ1M6Cj4gKyAgICAgIHN3aXRjaCAoaW5zdGFu Y2UpIHsKPiArICAgICAgY2FzZSAwOgo+ICsgICAgICAgICByZXR1cm4gIlZDU19JTlNURE9ORSI7 Cj4gKyAgICAgIGNhc2UgMToKPiArICAgICAgICAgcmV0dXJuICJWQ1MyX0lOU1RET05FIjsKPiAr ICAgICAgZGVmYXVsdDoKPiArICAgICAgICAgcmV0dXJuIE5VTEw7Cj4gKyAgICAgIH0KPiArCj4g KyAgIGNhc2UgVkVDUzoKPiArICAgICAgcmV0dXJuICJWRUNTX0lOU1RET05FIjsKPiAgICAgIH0K PiAgIAo+ICAgICAgcmV0dXJuIE5VTEw7Cj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeAo=