From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Souza, Jose" Subject: Re: [PATCH 3/5] drm/i915/cnl+: Verify combo PHY HW state during PHY uninit Date: Fri, 2 Nov 2018 21:34:12 +0000 Message-ID: <4aff36999fa0061326cc64aea277203a7c877292.camel@intel.com> References: <20181102180706.16582-1-imre.deak@intel.com> <20181102180706.16582-4-imre.deak@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 983456E5EB for ; Fri, 2 Nov 2018 21:34:16 +0000 (UTC) In-Reply-To: <20181102180706.16582-4-imre.deak@intel.com> Content-Language: en-US Content-ID: <795229FB68FD7544B84FBB5BA54C5764@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "intel-gfx@lists.freedesktop.org" , "Deak, Imre" Cc: "Zanoni, Paulo R" , "Vivi, Rodrigo" List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCAyMDE4LTExLTAyIGF0IDIwOjA3ICswMjAwLCBJbXJlIERlYWsgd3JvdGU6DQo+IFZl cmlmeSBvbiBDTkwsIElDTCB0aGF0IHRoZSBjb21ibyBQSFkgSFcgc3RhdGUgc3RheWVkIGludGFj dCBhZnRlcg0KPiBQSFkNCj4gaW5pdGlhbGl6YXRpb24uDQo+IA0KPiBDYzogUGF1bG8gWmFub25p IDxwYXVsby5yLnphbm9uaUBpbnRlbC5jb20+DQo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxl LnN5cmphbGFAbGludXguaW50ZWwuY29tPg0KPiBDYzogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8 am9zZS5zb3V6YUBpbnRlbC5jb20+DQo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBp bnRlbC5jb20+DQo+IFNpZ25lZC1vZmYtYnk6IEltcmUgRGVhayA8aW1yZS5kZWFrQGludGVsLmNv bT4NCj4gLS0tDQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb21ib19waHkuYyB8IDEw Mw0KPiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKy0NCj4gIDEgZmlsZSBjaGFuZ2Vk LCAxMDEgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkNCj4gDQo+IGRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb21ib19waHkuYw0KPiBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2NvbWJvX3BoeS5jDQo+IGluZGV4IDEzMTg0YWU1YTIxNy4uMTUyMmUyYTI1 MzkwIDEwMDY0NA0KPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb21ib19waHku Yw0KPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9jb21ib19waHkuYw0KPiBAQCAt NTIsOCArNTIsOCBAQCBzdGF0aWMgY29uc3Qgc3RydWN0IGNubF9wcm9jbW9uIHsNCj4gICAqIHJl Z2lzdGVycywgdGhhdCdzIHdoeSB3ZSBjYWxsIHRoZSBJQ0wgbWFjcm9zIGV2ZW4gdGhvdWdoIHRo ZQ0KPiBmdW5jdGlvbiBoYXMgQ05MDQo+ICAgKiBvbiBpdHMgbmFtZS4NCj4gICAqLw0KPiAtc3Rh dGljIHZvaWQgY25sX3NldF9wcm9jbW9uX3JlZl92YWx1ZXMoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUNCj4gKmRldl9wcml2LA0KPiAtCQkJCSAgICAgICBlbnVtIHBvcnQgcG9ydCkNCj4gK3N0YXRp YyBjb25zdCBzdHJ1Y3QgY25sX3Byb2Ntb24gKg0KPiArY25sX2dldF9wcm9jbW9uX3JlZl92YWx1 ZXMoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LCBlbnVtDQo+IHBvcnQgcG9ydCkN Cj4gIHsNCj4gIAljb25zdCBzdHJ1Y3QgY25sX3Byb2Ntb24gKnByb2Ntb247DQo+ICAJdTMyIHZh bDsNCj4gQEAgLTgwLDYgKzgwLDE3IEBAIHN0YXRpYyB2b2lkIGNubF9zZXRfcHJvY21vbl9yZWZf dmFsdWVzKHN0cnVjdA0KPiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwNCj4gIAkJYnJlYWs7 DQo+ICAJfQ0KPiAgDQo+ICsJcmV0dXJuIHByb2Ntb247DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyB2 b2lkIGNubF9zZXRfcHJvY21vbl9yZWZfdmFsdWVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlDQo+ ICpkZXZfcHJpdiwNCj4gKwkJCQkgICAgICAgZW51bSBwb3J0IHBvcnQpDQo+ICt7DQo+ICsJY29u c3Qgc3RydWN0IGNubF9wcm9jbW9uICpwcm9jbW9uOw0KPiArCXUzMiB2YWw7DQo+ICsNCj4gKwlw cm9jbW9uID0gY25sX2dldF9wcm9jbW9uX3JlZl92YWx1ZXMoZGV2X3ByaXYsIHBvcnQpOw0KPiAr DQo+ICAJdmFsID0gSTkxNV9SRUFEKElDTF9QT1JUX0NPTVBfRFcxKHBvcnQpKTsNCj4gIAl2YWwg Jj0gfigoMHhmZiA8PCAxNikgfCAweGZmKTsNCj4gIAl2YWwgfD0gcHJvY21vbi0+ZHcxOw0KPiBA QCAtODksNiArMTAwLDYzIEBAIHN0YXRpYyB2b2lkIGNubF9zZXRfcHJvY21vbl9yZWZfdmFsdWVz KHN0cnVjdA0KPiBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwNCj4gIAlJOTE1X1dSSVRFKElD TF9QT1JUX0NPTVBfRFcxMChwb3J0KSwgcHJvY21vbi0+ZHcxMCk7DQo+ICB9DQo+ICANCj4gK3N0 YXRpYyBib29sIGNoZWNrX3BoeV9yZWcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 LA0KPiArCQkJICBlbnVtIHBvcnQgcG9ydCwgaTkxNV9yZWdfdCByZWcsIHUzMiBtYXNrLA0KPiAr CQkJICB1MzIgZXhwZWN0ZWRfdmFsKQ0KPiArew0KPiArCXUzMiB2YWwgPSBJOTE1X1JFQUQocmVn KTsNCj4gKw0KPiArCWlmICgodmFsICYgbWFzaykgIT0gZXhwZWN0ZWRfdmFsKSB7DQo+ICsJCURS TV9ERUJVR19EUklWRVIoIlBvcnQtJWMgY29tYm8gUEhZIHJlZyAlMDh4IHN0YXRlDQo+IG1pc21h dGNoOiAiDQo+ICsJCQkJICJjdXJyZW50ICUwOHggbWFzayAlMDh4IGV4cGVjdGVkDQo+ICUwOHhc biIsDQo+ICsJCQkJIHBvcnRfbmFtZShwb3J0KSwNCj4gKwkJCQkgcmVnLnJlZywgdmFsLCBtYXNr LCBleHBlY3RlZF92YWwpOw0KPiArCQlyZXR1cm4gZmFsc2U7DQo+ICsJfQ0KPiArDQo+ICsJcmV0 dXJuIHRydWU7DQo+ICt9DQo+ICsNCj4gK3N0YXRpYyBib29sIGNubF92ZXJpZnlfcHJvY21vbl9y ZWZfdmFsdWVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlDQo+ICpkZXZfcHJpdiwNCj4gKwkJCQkJ ICBlbnVtIHBvcnQgcG9ydCkNCj4gK3sNCj4gKwljb25zdCBzdHJ1Y3QgY25sX3Byb2Ntb24gKnBy b2Ntb247DQo+ICsJYm9vbCByZXQ7DQo+ICsNCj4gKwlwcm9jbW9uID0gY25sX2dldF9wcm9jbW9u X3JlZl92YWx1ZXMoZGV2X3ByaXYsIHBvcnQpOw0KPiArDQo+ICsJcmV0ID0gY2hlY2tfcGh5X3Jl ZyhkZXZfcHJpdiwgcG9ydCwgSUNMX1BPUlRfQ09NUF9EVzEocG9ydCksDQo+ICsJCQkgICAgKDB4 ZmYgPDwgMTYpIHwgMHhmZiwgcHJvY21vbi0+ZHcxKTsNCj4gKwlyZXQgJj0gY2hlY2tfcGh5X3Jl ZyhkZXZfcHJpdiwgcG9ydCwgSUNMX1BPUlRfQ09NUF9EVzkocG9ydCksDQo+ICsJCQkgICAgIC0x VSwgcHJvY21vbi0+ZHc5KTsNCj4gKwlyZXQgJj0gY2hlY2tfcGh5X3JlZyhkZXZfcHJpdiwgcG9y dCwgSUNMX1BPUlRfQ09NUF9EVzEwKHBvcnQpLA0KPiArCQkJICAgICAtMVUsIHByb2Ntb24tPmR3 MTApOw0KPiArDQo+ICsJcmV0dXJuIHJldDsNCj4gK30NCj4gKw0KPiArc3RhdGljIGJvb2wgY25s X2NvbWJvX3BoeV9lbmFibGVkKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikNCj4g K3sNCj4gKwlyZXR1cm4gIShJOTE1X1JFQUQoQ0hJQ0tFTl9NSVNDXzIpICYgQ05MX0NPTVBfUFdS X0RPV04pICYmDQo+ICsJCShJOTE1X1JFQUQoQ05MX1BPUlRfQ09NUF9EVzApICYgQ09NUF9JTklU KTsNCj4gK30NCj4gKw0KPiArc3RhdGljIGJvb2wgY25sX2NvbWJvX3BoeV92ZXJpZnlfc3RhdGUo c3RydWN0IGRybV9pOTE1X3ByaXZhdGUNCj4gKmRldl9wcml2KQ0KPiArew0KPiArCWVudW0gcG9y dCBwb3J0ID0gUE9SVF9BOw0KPiArCWJvb2wgcmV0Ow0KPiArDQo+ICsJaWYgKCFjbmxfY29tYm9f cGh5X2VuYWJsZWQoZGV2X3ByaXYpKQ0KPiArCQlyZXR1cm4gZmFsc2U7DQo+ICsNCj4gKwlyZXQg PSBjbmxfdmVyaWZ5X3Byb2Ntb25fcmVmX3ZhbHVlcyhkZXZfcHJpdiwgcG9ydCk7DQo+ICsNCj4g KwlyZXQgJj0gY2hlY2tfcGh5X3JlZyhkZXZfcHJpdiwgcG9ydCwgQ05MX1BPUlRfQ0wxQ01fRFc1 LA0KPiArCQkJICAgICBDTF9QT1dFUl9ET1dOX0VOQUJMRSwNCj4gQ0xfUE9XRVJfRE9XTl9FTkFC TEUpOw0KPiArDQo+ICsJcmV0dXJuIHJldDsNCj4gK30NCj4gKw0KPiAgdm9pZCBjbmxfY29tYm9f cGh5c19pbml0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikNCj4gIHsNCj4gIAl1 MzIgdmFsOw0KPiBAQCAtMTEzLDExICsxODEsMzggQEAgdm9pZCBjbmxfY29tYm9fcGh5c191bmlu aXQoc3RydWN0DQo+IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQ0KPiAgew0KPiAgCXUzMiB2 YWw7DQo+ICANCj4gKwlpZiAoIWNubF9jb21ib19waHlfdmVyaWZ5X3N0YXRlKGRldl9wcml2KSkN Cj4gKwkJRFJNX1dBUk4oIkNvbWJvIFBIWSBIVyBzdGF0ZSBjaGFuZ2VkIHVuZXhwZWN0ZWRseS5c biIpOw0KPiArDQo+ICAJdmFsID0gSTkxNV9SRUFEKENISUNLRU5fTUlTQ18yKTsNCj4gIAl2YWwg fD0gQ05MX0NPTVBfUFdSX0RPV047DQo+ICAJSTkxNV9XUklURShDSElDS0VOX01JU0NfMiwgdmFs KTsNCj4gIH0NCj4gIA0KPiArc3RhdGljIGJvb2wgaWNsX2NvbWJvX3BoeV9lbmFibGVkKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwNCj4gKwkJCQkgIGVudW0gcG9ydCBwb3J0KQ0K PiArew0KPiArCXJldHVybiAhKEk5MTVfUkVBRChJQ0xfUEhZX01JU0MocG9ydCkpICYNCj4gKwkJ IElDTF9QSFlfTUlTQ19ERV9JT19DT01QX1BXUl9ET1dOKSAmJg0KPiArCQkoSTkxNV9SRUFEKElD TF9QT1JUX0NPTVBfRFcwKHBvcnQpKSAmIENPTVBfSU5JVCk7DQo+ICt9DQo+ICsNCj4gK3N0YXRp YyBib29sIGljbF9jb21ib19waHlfdmVyaWZ5X3N0YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRl DQo+ICpkZXZfcHJpdiwNCj4gKwkJCQkgICAgICAgZW51bSBwb3J0IHBvcnQpDQo+ICt7DQo+ICsJ Ym9vbCByZXQ7DQo+ICsNCj4gKwlpZiAoIWljbF9jb21ib19waHlfZW5hYmxlZChkZXZfcHJpdiwg cG9ydCkpDQo+ICsJCXJldHVybiBmYWxzZTsNCj4gKw0KPiArCXJldCA9IGNubF92ZXJpZnlfcHJv Y21vbl9yZWZfdmFsdWVzKGRldl9wcml2LCBwb3J0KTsNCj4gKw0KPiArCXJldCAmPSBjaGVja19w aHlfcmVnKGRldl9wcml2LCBwb3J0LCBJQ0xfUE9SVF9DTF9EVzUocG9ydCksDQo+ICsJCQkgICAg IENMX1BPV0VSX0RPV05fRU5BQkxFLA0KPiBDTF9QT1dFUl9ET1dOX0VOQUJMRSk7DQo+ICsNCj4g KwlyZXR1cm4gcmV0Ow0KPiArfQ0KPiArDQo+ICB2b2lkIGljbF9jb21ib19waHlzX2luaXQoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQ0KPiAgew0KPiAgCWVudW0gcG9ydCBwb3J0 Ow0KPiBAQCAtMTQ4LDYgKzI0MywxMCBAQCB2b2lkIGljbF9jb21ib19waHlzX3VuaW5pdChzdHJ1 Y3QNCj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpDQo+ICAJZm9yIChwb3J0ID0gUE9SVF9B OyBwb3J0IDw9IFBPUlRfQjsgcG9ydCsrKSB7DQo+ICAJCXUzMiB2YWw7DQo+ICANCj4gKwkJaWYg KCFpY2xfY29tYm9fcGh5X3ZlcmlmeV9zdGF0ZShkZXZfcHJpdiwgcG9ydCkpDQo+ICsJCQlEUk1f V0FSTigiUG9ydC0lYyBjb21ibyBQSFkgSFcgc3RhdGUgY2hhbmdlZA0KPiB1bmV4cGVjdGVkbHlc biIsDQo+ICsJCQkJIHBvcnRfbmFtZShwb3J0KSk7DQoNCk1pbm9yOiBJbiBtb3N0IG9mIHRoZSBw bGFjZXMgdGhlIHBvcnQgaW5kZW50aWZpY2F0aW9uIGlzIHByaW50ZWQgbGlrZQ0KdGhpczogInBv cnQgJWMiDQoNCj4gKw0KPiAgCQl2YWwgPSBJOTE1X1JFQUQoSUNMX1BIWV9NSVNDKHBvcnQpKTsN Cj4gIAkJdmFsIHw9IElDTF9QSFlfTUlTQ19ERV9JT19DT01QX1BXUl9ET1dOOw0KPiAgCQlJOTE1 X1dSSVRFKElDTF9QSFlfTUlTQyhwb3J0KSwgdmFsKTsNCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=