From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE76CC021BC for ; Tue, 25 Feb 2025 14:09:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3713810E6B5; Tue, 25 Feb 2025 14:09:12 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="OjThLzy5"; dkim-atps=neutral Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by gabe.freedesktop.org (Postfix) with ESMTPS id 69BFA10E6B6; Tue, 25 Feb 2025 14:09:09 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id 97080442E6; Tue, 25 Feb 2025 14:09:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1740492548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XR8tPEF4JOD9Mewu8g7MXiYm4y2vVcFBMc945e+Xaoc=; b=OjThLzy5VcjM3qOMCD67MOdey5Qx8Yae/mVFboetJAbwrXhmrzLBuU5OLz+eg6x1Wi2aO7 P6kq0b9oTTdd0bIrdTCOFK9hVBFIfhHBPot6L5Vo0vOCwniqN3R1PUwwLap1hmsPd4lz4L 13BZfdrtlBEX3NOgZuTym12yYnXdW+NnNr860GrqoV4+qPeXRLh01I9GAdZ7xh4w6xelZU lXvqz/16OymMcniPjqqv1HTZveXJvDRq8MiMm3vQQHpQXNp3uIdiLWlFgrXU3hDO+ZQUaP WEzJ6jYHMlzyRebRnedHsgrwjraw19rqhOWK1OZNI5isbkXPqkx+lgm2Os3GHg== Date: Tue, 25 Feb 2025 15:09:06 +0100 From: Louis Chauvet To: Jim Cromie , linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org Cc: intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com Subject: Re: [PATCH 06/63] dyndbg: ddebug_apply_class_bitmap - add module arg, select on it Message-ID: <4ba7ad6f-c1dd-40e3-abcd-547635ff43da@bootlin.com> Mail-Followup-To: Jim Cromie , linux-kernel@vger.kernel.org, jbaron@akamai.com, gregkh@linuxfoundation.org, ukaszb@chromium.org, intel-gfx-trybot@lists.freedesktop.org, dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, daniel.vetter@ffwll.ch, tvrtko.ursulin@linux.intel.com, jani.nikula@intel.com, ville.syrjala@linux.intel.com References: <20250125064619.8305-1-jim.cromie@gmail.com> <20250125064619.8305-7-jim.cromie@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250125064619.8305-7-jim.cromie@gmail.com> X-GND-State: clean X-GND-Score: -100 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeefvddrtddtgdekudeltdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvfevuffkfhggtggugfgjsehtkeertddttddunecuhfhrohhmpefnohhuihhsucevhhgruhhvvghtuceolhhouhhishdrtghhrghuvhgvthessghoohhtlhhinhdrtghomheqnecuggftrfgrthhtvghrnhepudeiffduffeivdejgfejheeuudekkedvjeeuffegfefghfffkeelgffgieevudejnecuffhomhgrihhnpegsohhothhlihhnrdgtohhmnecukfhppeeltddrkeelrdduieefrdduvdejnecuvehluhhsthgvrhfuihiivgepudenucfrrghrrghmpehinhgvthepledtrdekledrudeifedruddvjedphhgvlhhopehlohhuihhsqdgthhgruhhvvghtqdhlrghpthhophdpmhgrihhlfhhrohhmpehlohhuihhsrdgthhgruhhvvghtsegsohhothhlihhnrdgtohhmpdhnsggprhgtphhtthhopedugedprhgtphhtthhopehjihhmrdgtrhhomhhivgesghhmrghilhdrtghomhdprhgtphhtthhopehlihhnuhigqdhkvghrnhgvlhesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopehjsggrrhhonhesrghkrghmrghirdgtohhmpdhrtghpthhtohepghhrvghgkhhhsehlihhnuhigfhhouhhnuggrthhiohhnr dhorhhgpdhrtghpthhtohepuhhkrghsiigssegthhhrohhmihhumhdrohhrghdprhgtphhtthhopehinhhtvghlqdhgfhigqdhtrhihsghotheslhhishhtshdrfhhrvggvuggvshhkthhophdrohhrghdprhgtphhtthhopegurhhiqdguvghvvghlsehlihhsthhsrdhfrhgvvgguvghskhhtohhprdhorhhgpdhrtghpthhtoheprghmugdqghhfgieslhhishhtshdrfhhrvggvuggvshhkthhophdrohhrgh X-GND-Sasl: louis.chauvet@bootlin.com X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Le 25/01/2025 à 07:45, Jim Cromie a écrit : > Add param: query_module to ddebug_apply_class_bitmap(), and pass it > thru to _ddebug_queries(), replacing NULL with query_module. This > allows its caller to update just one module, or all (as currently). > > We'll use this later to propagate drm.debug to each USEr as they're > modprobed. > > No functional change. > > Signed-off-by: Jim Cromie Reviewed-by: Louis Chauvet > --- > > after `modprobe i915`, heres the module dependencies, > though not all on drm.debug. > > bash-5.2# lsmod > Module Size Used by > i915 3133440 0 > drm_buddy 20480 1 i915 > ttm 90112 1 i915 > i2c_algo_bit 16384 1 i915 > video 61440 1 i915 > wmi 32768 1 video > drm_display_helper 200704 1 i915 > drm_kms_helper 208896 2 drm_display_helper,i915 > drm 606208 5 drm_kms_helper,drm_display_helper,drm_buddy,i915,ttm > cec 57344 2 drm_display_helper,i915 > --- > lib/dynamic_debug.c | 19 ++++++++++++------- > 1 file changed, 12 insertions(+), 7 deletions(-) > > diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c > index 41cbaa96f83d..8adb81e75a16 100644 > --- a/lib/dynamic_debug.c > +++ b/lib/dynamic_debug.c > @@ -605,7 +605,8 @@ static int ddebug_exec_queries(char *query, const char *modname) > > /* apply a new bitmap to the sys-knob's current bit-state */ > static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, > - unsigned long *new_bits, unsigned long *old_bits) > + unsigned long *new_bits, unsigned long *old_bits, > + const char *query_modname) > { > #define QUERY_SIZE 128 > char query[QUERY_SIZE]; > @@ -613,7 +614,8 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, > int matches = 0; > int bi, ct; > > - v2pr_info("apply: 0x%lx to: 0x%lx\n", *new_bits, *old_bits); > + v2pr_info("apply bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, *old_bits, > + query_modname ?: ""); > > for (bi = 0; bi < map->length; bi++) { > if (test_bit(bi, new_bits) == test_bit(bi, old_bits)) > @@ -622,12 +624,15 @@ static int ddebug_apply_class_bitmap(const struct ddebug_class_param *dcp, > snprintf(query, QUERY_SIZE, "class %s %c%s", map->class_names[bi], > test_bit(bi, new_bits) ? '+' : '-', dcp->flags); > > - ct = ddebug_exec_queries(query, NULL); > + ct = ddebug_exec_queries(query, query_modname); > matches += ct; > > v2pr_info("bit_%d: %d matches on class: %s -> 0x%lx\n", bi, > ct, map->class_names[bi], *new_bits); > } > + v2pr_info("applied bitmap: 0x%lx to: 0x%lx for %s\n", *new_bits, *old_bits, > + query_modname ?: ""); > + > return matches; > } > > @@ -682,7 +687,7 @@ static int param_set_dyndbg_classnames(const char *instr, const struct kernel_pa > continue; > } > curr_bits ^= BIT(cls_id); > - totct += ddebug_apply_class_bitmap(dcp, &curr_bits, dcp->bits); > + totct += ddebug_apply_class_bitmap(dcp, &curr_bits, dcp->bits, NULL); > *dcp->bits = curr_bits; > v2pr_info("%s: changed bit %d:%s\n", KP_NAME(kp), cls_id, > map->class_names[cls_id]); > @@ -692,7 +697,7 @@ static int param_set_dyndbg_classnames(const char *instr, const struct kernel_pa > old_bits = CLASSMAP_BITMASK(*dcp->lvl); > curr_bits = CLASSMAP_BITMASK(cls_id + (wanted ? 1 : 0 )); > > - totct += ddebug_apply_class_bitmap(dcp, &curr_bits, &old_bits); > + totct += ddebug_apply_class_bitmap(dcp, &curr_bits, &old_bits, NULL); > *dcp->lvl = (cls_id + (wanted ? 1 : 0)); > v2pr_info("%s: changed bit-%d: \"%s\" %lx->%lx\n", KP_NAME(kp), cls_id, > map->class_names[cls_id], old_bits, curr_bits); > @@ -755,7 +760,7 @@ int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp) > inrep &= CLASSMAP_BITMASK(map->length); > } > v2pr_info("bits:%lx > %s\n", inrep, KP_NAME(kp)); > - totct += ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits); > + totct += ddebug_apply_class_bitmap(dcp, &inrep, dcp->bits, NULL); > *dcp->bits = inrep; > break; > case DD_CLASS_TYPE_LEVEL_NUM: > @@ -768,7 +773,7 @@ int param_set_dyndbg_classes(const char *instr, const struct kernel_param *kp) > old_bits = CLASSMAP_BITMASK(*dcp->lvl); > new_bits = CLASSMAP_BITMASK(inrep); > v2pr_info("lvl:%ld bits:0x%lx > %s\n", inrep, new_bits, KP_NAME(kp)); > - totct += ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits); > + totct += ddebug_apply_class_bitmap(dcp, &new_bits, &old_bits, NULL); > *dcp->lvl = inrep; > break; > default: -- Louis Chauvet, Bootlin Embedded Linux and Kernel engineering https://bootlin.com