From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniele Ceraolo Spurio Subject: Re: [PATCH v2 03/22] drm/i915/guc: Simplify preparation of GuC parameter block Date: Mon, 15 Apr 2019 11:27:36 -0700 Message-ID: <4cdb9497-57dd-cf95-5cb8-134906269765@intel.com> References: <20190411084436.24384-1-michal.wajdeczko@intel.com> <20190411084436.24384-4-michal.wajdeczko@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5026F89333 for ; Mon, 15 Apr 2019 18:27:37 +0000 (UTC) In-Reply-To: <20190411084436.24384-4-michal.wajdeczko@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michal Wajdeczko , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDQvMTEvMTkgMTo0NCBBTSwgTWljaGFsIFdhamRlY3prbyB3cm90ZToKPiBEZWZpbml0aW9u IG9mIHRoZSBwYXJhbWV0ZXJzIGJsb2NrIHBhc3NlZCB0byBHdUMgaXMgYWJvdXQgdG8gY2hhbmdl Lgo+IFNsaWdodGx5IHJlZmFjdG9yIGNvZGUgbm93IHRvIG1ha2UgdXBjb21pbmcgcGF0Y2ggc21h bGxlci4KCkkgZG9uJ3QgdGhpbmsgdGhpcyBzaW1wbGlmaWVzIHRoZSB1cGNvbWluZyBwYXRjaCAo Ni8yMikgaW4gYW55IHdheSwgCnNpbmNlIG1vc3QgY2hhbmdlcyBpbiB0aGF0IG9uZSBhcmUgY29u Y2VudHJhdGVkIGluIHRoZSBpbmRpdmlkdWFsIAoqX2ZsYWdzIGZ1bmN0aW9ucywgd2hpY2ggeW91 J3JlIG5vdCB0b3VjaGluZyBoZXJlLiBUaGUgb25seSByZWxhdGVkIApjaGFuZ2VzIGFyZSB0aGUg b25lcyB0aGF0IHRoZSBvdGhlciBwYXRjaCBkb2VzIGluIGd1Y19wcmVwYXJlX3BhcmFtcywgCmJ1 dCB0aG9zZSBsb29rcyBsaWtlIHRoZXkgd291bGQgYmUgdGhlIHNhbWUgd2l0aG91dCBzcGxpdHRp bmcgdGhlIApmdW5jdGlvbiBvdXQuClBlcnNvbmFsbHkgSSB3b3VsZCBqdXN0IGRyb3AgdGhpcyBh biBrZWVwIGludGVsX2d1Y19pbml0X3BhcmFtcygpIGFzIGlzLCAKc2luY2UgaXQgaXMgY2xlYXJl ciB0byBmb2xsb3cgSU1PLgoKRGFuaWVsZQoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBNaWNoYWwgV2Fq ZGVjemtvIDxtaWNoYWwud2FqZGVjemtvQGludGVsLmNvbT4KPiBDYzogSm9vbmFzIExhaHRpbmVu IDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IENjOiBKb2huIFNwb3Rzd29vZCA8 am9obi5hLnNwb3Rzd29vZEBpbnRlbC5jb20+Cj4gUmV2aWV3ZWQtYnk6IEpvaG4gU3BvdHN3b29k IDxqb2huLmEuc3BvdHN3b29kQGludGVsLmNvbT4KPiBSZXZpZXdlZC1ieTogSm9vbmFzIExhaHRp bmVuIDxqb29uYXMubGFodGluZW5AbGludXguaW50ZWwuY29tPgo+IC0tLQo+ICAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmMgfCAzOCArKysrKysrKysrKysrKysrKysrLS0tLS0tLS0t LS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKyksIDE1IGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuYyBiL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Yy5jCj4gaW5kZXggM2FhYmZhMmQ5MTk4Li5jMGU4 YjM1OWIyM2EgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjLmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWMuYwo+IEBAIC0zMzMsMTkgKzMz Myw4IEBAIHN0YXRpYyB1MzIgZ3VjX2N0bF9sb2dfcGFyYW1zX2ZsYWdzKHN0cnVjdCBpbnRlbF9n dWMgKmd1YykKPiAgIAlyZXR1cm4gZmxhZ3M7Cj4gICB9Cj4gICAKPiAtLyoKPiAtICogSW5pdGlh bGlzZSB0aGUgR3VDIHBhcmFtZXRlciBibG9jayBiZWZvcmUgc3RhcnRpbmcgdGhlIGZpcm13YXJl Cj4gLSAqIHRyYW5zZmVyLiBUaGVzZSBwYXJhbWV0ZXJzIGFyZSByZWFkIGJ5IHRoZSBmaXJtd2Fy ZSBvbiBzdGFydHVwCj4gLSAqIGFuZCBjYW5ub3QgYmUgY2hhbmdlZCB0aGVyZWFmdGVyLgo+IC0g Ki8KPiAtdm9pZCBpbnRlbF9ndWNfaW5pdF9wYXJhbXMoc3RydWN0IGludGVsX2d1YyAqZ3VjKQo+ ICtzdGF0aWMgdm9pZCBndWNfcHJlcGFyZV9wYXJhbXMoc3RydWN0IGludGVsX2d1YyAqZ3VjLCB1 MzIgKnBhcmFtcykKPiAgIHsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9 IGd1Y190b19pOTE1KGd1Yyk7Cj4gLQl1MzIgcGFyYW1zW0dVQ19DVExfTUFYX0RXT1JEU107Cj4g LQlpbnQgaTsKPiAtCj4gLQltZW1zZXQocGFyYW1zLCAwLCBzaXplb2YocGFyYW1zKSk7Cj4gLQo+ ICAgCS8qCj4gICAJICogR3VDIEFSQVQgaW5jcmVtZW50IGlzIDEwIG5zLiBHdUMgZGVmYXVsdCBz Y2hlZHVsZXIgcXVhbnR1bSBpcyBvbmUKPiAgIAkgKiBzZWNvbmQuIFRoaXMgQVJBUiBpcyBjYWxj dWxhdGVkIGJ5Ogo+IEBAIC0zNjAsOSArMzQ5LDEyIEBAIHZvaWQgaW50ZWxfZ3VjX2luaXRfcGFy YW1zKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykKPiAgIAlwYXJhbXNbR1VDX0NUTF9MT0dfUEFSQU1T XSAgPSBndWNfY3RsX2xvZ19wYXJhbXNfZmxhZ3MoZ3VjKTsKPiAgIAlwYXJhbXNbR1VDX0NUTF9E RUJVR10gPSBndWNfY3RsX2RlYnVnX2ZsYWdzKGd1Yyk7Cj4gICAJcGFyYW1zW0dVQ19DVExfQ1RY SU5GT10gPSBndWNfY3RsX2N0eGluZm9fZmxhZ3MoZ3VjKTsKPiArfQo+ICAgCj4gLQlmb3IgKGkg PSAwOyBpIDwgR1VDX0NUTF9NQVhfRFdPUkRTOyBpKyspCj4gLQkJRFJNX0RFQlVHX0RSSVZFUigi cGFyYW1bJTJkXSA9ICUjeFxuIiwgaSwgcGFyYW1zW2ldKTsKPiArc3RhdGljIHZvaWQgZ3VjX3dy aXRlX3BhcmFtcyhzdHJ1Y3QgaW50ZWxfZ3VjICpndWMsIGNvbnN0IHUzMiAqcGFyYW1zKQo+ICt7 Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBndWNfdG9faTkxNShndWMp Owo+ICsJaW50IGk7Cj4gICAKPiAgIAkvKgo+ICAgCSAqIEFsbCBTT0ZUX1NDUkFUQ0ggcmVnaXN0 ZXJzIGFyZSBpbiBGT1JDRVdBS0VfQkxJVFRFUiBkb21haW4gYW5kCj4gQEAgLTM3MywxMiArMzY1 LDI4IEBAIHZvaWQgaW50ZWxfZ3VjX2luaXRfcGFyYW1zKHN0cnVjdCBpbnRlbF9ndWMgKmd1YykK PiAgIAo+ICAgCUk5MTVfV1JJVEUoU09GVF9TQ1JBVENIKDApLCAwKTsKPiAgIAo+IC0JZm9yIChp ID0gMDsgaSA8IEdVQ19DVExfTUFYX0RXT1JEUzsgaSsrKQo+ICsJZm9yIChpID0gMDsgaSA8IEdV Q19DVExfTUFYX0RXT1JEUzsgaSsrKSB7Cj4gKwkJRFJNX0RFQlVHX0RSSVZFUigicGFyYW1bJTJk XSA9ICUjeFxuIiwgaSwgcGFyYW1zW2ldKTsKPiAgIAkJSTkxNV9XUklURShTT0ZUX1NDUkFUQ0go MSArIGkpLCBwYXJhbXNbaV0pOwo+ICsJfQo+ICAgCj4gICAJaW50ZWxfdW5jb3JlX2ZvcmNld2Fr ZV9wdXQoJmRldl9wcml2LT51bmNvcmUsIEZPUkNFV0FLRV9CTElUVEVSKTsKPiAgIH0KPiAgIAo+ ICsvKgo+ICsgKiBJbml0aWFsaXNlIHRoZSBHdUMgcGFyYW1ldGVyIGJsb2NrIGJlZm9yZSBzdGFy dGluZyB0aGUgZmlybXdhcmUKPiArICogdHJhbnNmZXIuIFRoZXNlIHBhcmFtZXRlcnMgYXJlIHJl YWQgYnkgdGhlIGZpcm13YXJlIG9uIHN0YXJ0dXAKPiArICogYW5kIGNhbm5vdCBiZSBjaGFuZ2Vk IHRoZXJlYWZ0ZXIuCj4gKyAqLwo+ICt2b2lkIGludGVsX2d1Y19pbml0X3BhcmFtcyhzdHJ1Y3Qg aW50ZWxfZ3VjICpndWMpCj4gK3sKPiArCXUzMiBwYXJhbXNbR1VDX0NUTF9NQVhfRFdPUkRTXTsK PiArCj4gKwltZW1zZXQocGFyYW1zLCAwLCBzaXplb2YocGFyYW1zKSk7Cj4gKwlndWNfcHJlcGFy ZV9wYXJhbXMoZ3VjLCBwYXJhbXMpOwo+ICsJZ3VjX3dyaXRlX3BhcmFtcyhndWMsIHBhcmFtcyk7 Cj4gK30KPiArCj4gICBpbnQgaW50ZWxfZ3VjX3NlbmRfbm9wKHN0cnVjdCBpbnRlbF9ndWMgKmd1 YywgY29uc3QgdTMyICphY3Rpb24sIHUzMiBsZW4sCj4gICAJCSAgICAgICB1MzIgKnJlc3BvbnNl X2J1ZiwgdTMyIHJlc3BvbnNlX2J1Zl9zaXplKQo+ICAgewo+IApfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=