Re: [Intel-gfx] [PATCH 02/16] drm/i915: Shrink {icl_mg, tgl_dkl}_phy_ddi_buf_trans

Jani Nikula
2021-10-08T10:19:21Z

On Wed, 06 Oct 2021, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> All the values we have in {icl_mg,tgl_dkl}_phy_ddi_buf_trans
> fit into u8. Shrink the types accordingly.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
> drivers/gpu/drm/i915/display/intel_ddi_buf_trans.h | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.h b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.h
> index 82fdc5ecd9de..2133984a572b 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.h
> +++ b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.h
> @@ -34,15 +34,15 @@ struct icl_ddi_buf_trans {
> };
>
> struct icl_mg_phy_ddi_buf_trans {
> - u32 cri_txdeemph_override_11_6;
> - u32 cri_txdeemph_override_5_0;
> - u32 cri_txdeemph_override_17_12;
> + u8 cri_txdeemph_override_11_6;
> + u8 cri_txdeemph_override_5_0;
> + u8 cri_txdeemph_override_17_12;
> };
>
> struct tgl_dkl_phy_ddi_buf_trans {
> - u32 vswing;
> - u32 preshoot;
> - u32 de_emphasis;
> + u8 vswing;
> + u8 preshoot;
> + u8 de_emphasis;
> };
>
> struct dg2_snps_phy_buf_trans {

--
Jani Nikula, Intel Open Source Graphics Center