From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniele Ceraolo Spurio Subject: Re: [RFC 06/11] drm/i915/guc: Remove extra arguments from guc_client_alloc Date: Thu, 23 Feb 2017 17:39:45 -0800 Message-ID: <4fb5feb4-c32c-c13b-ccdc-26413f03df1d@intel.com> References: <20170223190833.2888-1-michal.winiarski@intel.com> <20170223191421.4502-2-michal.winiarski@intel.com> <318912c9-89c1-0d53-2e0a-e0bdea4e024e@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 891716EB8F for ; Fri, 24 Feb 2017 01:39:46 +0000 (UTC) In-Reply-To: <318912c9-89c1-0d53-2e0a-e0bdea4e024e@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Oscar Mateo , =?UTF-8?Q?Micha=c5=82_Winiarski?= , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org CgpPbiAyMy8wMi8xNyAwODozOCwgT3NjYXIgTWF0ZW8gd3JvdGU6Cj4KPgo+IE9uIDAyLzIzLzIw MTcgMTE6MTQgQU0sIE1pY2hhxYIgV2luaWFyc2tpIHdyb3RlOgo+PiBXZSdyZSBhbHdheXMgdXNp bmcgYWxsIGVuZ2luZXMgYW5kIGtlcm5lbCBjb250ZXh0IGZvciBndWMgY2xpZW50cywgbGV0J3MK Pj4gcmVtb3ZlIHRob3NlIGFyZ3VtZW50cyBmcm9tIGd1Y19jbGllbnRfYWxsb2MuCj4gSSBhbSBx dWl0ZSBuZXcgdG8gdGhlIEd1QyBidXQsIGJ5IHRoZSBsb29rIG9mIGl0LCBwYXNzaW5nIHRoZSBj dHggd2FzCj4gZ3JvdW5kd29yayBmb3IgZGlyZWN0IHN1Ym1pc3Npb24gKHdoaWNoIG1lYW5zIGNh bGxpbmcgZ3VjX2NsaWVudF9hbGxvYwo+IHdpdGggY29udGV4dHMgZGlmZmVyZW50IHRoYW4ga2Vy bmVsX2NvbnRleHQpLiBXaHkgbm90IGxlYXZlIGl0IHRoZXJlLAo+IHNpbmNlIHNvbWVvbmUgd2Fz IGNhcmVmdWwgdG8gbGF5IHRoZSBncm91bmR3b3JrPyBJIGRvbid0IHNlZSBhbiBvYnZpb3VzCj4g dXNlIGZvciB0aGUgZW5naW5lcywgdGhvdWdoIChjbGllbnRzIHRoYXQgb25seSBoYXZlIGFjY2Vz cyB0byBzb21lIG9mCj4gdGhlIGVuZ2luZXM/KS4KPgoKSWYgSSByZWNhbGwgY29ycmVjdGx5IHRo ZSBpZGVhIGJlaGluZCBoYXZpbmcgdGhlIGVuZ2luZSBmbGFnIHdhcyBmb3IgCnBvc3NpYmx5IGhh dmluZyBkZWRpY2F0ZWQgY2xpZW50cyBmb3Igc2luZ2xlIGVuZ2luZXMgYW5kL29yIGVuZ2luZXMg Cmdyb3VwcyBpZiAxIHdvcmstcXVldWUgKyBkb29yYmVsbCBwYWlyIHR1cm5lZCBvdXQgdG8gbm90 IGJlIGVub3VnaCBmb3IgCm91ciBuZWVkcy4gVGhlcmUgbWlnaHQgYWxzbyBiZSBzb21lIGxpdHRs ZSBwZXJmb3JtYW5jZSBiZW5lZml0IGluIHRoYXQgCnNjZW5hcmlvIGJlY2F1c2Ugd2UgY2FuIHVw ZGF0ZSBkaWZmZXJlbnQgd29yay1xdWV1ZXMgaW4gcGFyYWxsZWwsIGJ1dCAKd2UncmUgc3RpbGwg Y2FwcGVkIGJ5IGhvdyBmYXN0IEd1QyBjYW4gcHJvY2VzcyB0aGVtLiBOb3Qgc3VyZSBpZiBpdCAK c3RpbGwgbWFrZXMgc2Vuc2UgdGhvdWdoLgoKRGFuaWVsZQoKPj4gU2lnbmVkLW9mZi1ieTogTWlj aGHFgiBXaW5pYXJza2kgPG1pY2hhbC53aW5pYXJza2lAaW50ZWwuY29tPgo+PiAtLS0KPj4gICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMgfCAxNiArKysrLS0tLS0t LS0tLS0tCj4+ICAgMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygrKSwgMTIgZGVsZXRpb25z KC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJt aXNzaW9uLmMKPj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2d1Y19zdWJtaXNzaW9uLmMK Pj4gaW5kZXggNmM2NGNlMS4uMzA4MDczNSAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9ndWNfc3VibWlzc2lvbi5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ3VjX3N1Ym1pc3Npb24uYwo+PiBAQCAtODM4LDIxICs4MzgsMTUgQEAgc3RhdGljIHZv aWQgZ3VjX2luaXRfZG9vcmJlbGxfaHcoc3RydWN0Cj4+IGludGVsX2d1YyAqZ3VjKQo+PiAgIC8q Kgo+PiAgICAqIGd1Y19jbGllbnRfYWxsb2MoKSAtIEFsbG9jYXRlIGFuIGk5MTVfZ3VjX2NsaWVu dAo+PiAgICAqIEBkZXZfcHJpdjogICAgZHJpdmVyIHByaXZhdGUgZGF0YSBzdHJ1Y3R1cmUKPj4g LSAqIEBlbmdpbmVzOiAgICBUaGUgc2V0IG9mIGVuZ2luZXMgdG8gZW5hYmxlIGZvciB0aGlzIGNs aWVudAo+PiAgICAqIEBwcmlvcml0eTogICAgZm91ciBsZXZlbHMgcHJpb3JpdHkgX0NSSVRJQ0FM LCBfSElHSCwgX05PUk1BTCBhbmQKPj4gX0xPVwo+PiAgICAqICAgICAgICAgVGhlIGtlcm5lbCBj bGllbnQgdG8gcmVwbGFjZSBFeGVjTGlzdCBzdWJtaXNzaW9uIGlzCj4+IGNyZWF0ZWQgd2l0aAo+ PiAgICAqICAgICAgICAgTk9STUFMIHByaW9yaXR5LiBQcmlvcml0eSBvZiBhIGNsaWVudCBmb3Ig c2NoZWR1bGVyIGNhbgo+PiBiZSBISUdILAo+PiAgICAqICAgICAgICAgd2hpbGUgYSBwcmVlbXB0 aW9uIGNvbnRleHQgY2FuIHVzZSBDUklUSUNBTC4KPj4gLSAqIEBjdHg6ICAgIHRoZSBjb250ZXh0 IHRoYXQgb3ducyB0aGUgY2xpZW50ICh3ZSB1c2UgdGhlIGRlZmF1bHQgcmVuZGVyCj4+IC0gKiAg ICAgICAgIGNvbnRleHQpCj4+IC0gKgo+PiAgICAqIFJldHVybjogICAgQW4gaTkxNV9ndWNfY2xp ZW50IG9iamVjdCBpZiBzdWNjZXNzLCBlbHNlIE5VTEwuCj4+ICAgICovCj4+ICAgc3RhdGljIHN0 cnVjdCBpOTE1X2d1Y19jbGllbnQgKgo+PiAgIGd1Y19jbGllbnRfYWxsb2Moc3RydWN0IGRybV9p OTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAtICAgICAgICAgdWludDMyX3QgZW5naW5lcywKPj4g LSAgICAgICAgIHVpbnQzMl90IHByaW9yaXR5LAo+PiAtICAgICAgICAgc3RydWN0IGk5MTVfZ2Vt X2NvbnRleHQgKmN0eCkKPj4gKyAgICAgICAgIHVpbnQzMl90IHByaW9yaXR5KQo+PiAgIHsKPj4g ICAgICAgc3RydWN0IGk5MTVfZ3VjX2NsaWVudCAqY2xpZW50Owo+PiAgICAgICBzdHJ1Y3QgaW50 ZWxfZ3VjICpndWMgPSAmZGV2X3ByaXYtPmd1YzsKPj4gQEAgLTg2NCw5ICs4NTgsOSBAQCBndWNf Y2xpZW50X2FsbG9jKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gICAgICAg aWYgKCFjbGllbnQpCj4+ICAgICAgICAgICByZXR1cm4gTlVMTDsKPj4gICAtICAgIGNsaWVudC0+ b3duZXIgPSBjdHg7Cj4+ICsgICAgY2xpZW50LT5vd25lciA9IGRldl9wcml2LT5rZXJuZWxfY29u dGV4dDsKPj4gICAgICAgY2xpZW50LT5ndWMgPSBndWM7Cj4+IC0gICAgY2xpZW50LT5lbmdpbmVz ID0gZW5naW5lczsKPj4gKyAgICBjbGllbnQtPmVuZ2luZXMgPSBJTlRFTF9JTkZPKGRldl9wcml2 KS0+cmluZ19tYXNrOwo+PiAgICAgICBjbGllbnQtPnByaW9yaXR5ID0gcHJpb3JpdHk7Cj4+ICAg ICAgIGNsaWVudC0+ZG9vcmJlbGxfaWQgPSBHVUNfSU5WQUxJRF9ET09SQkVMTF9JRDsKPj4gICBA QCAtMTA2Miw5ICsxMDU2LDcgQEAgaW50IGk5MTVfZ3VjX3N1Ym1pc3Npb25faW5pdChzdHJ1Y3QK Pj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4+ICAgICAgIGd1Y19hZGRvbl9jcmVhdGUo Z3VjKTsKPj4gICAgICAgICBndWMtPmV4ZWNidWZfY2xpZW50ID0gZ3VjX2NsaWVudF9hbGxvYyhk ZXZfcHJpdiwKPj4gLSAgICAgICAgICAgICAgICAgICAgICAgICAgIElOVEVMX0lORk8oZGV2X3By aXYpLT5yaW5nX21hc2ssCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICBHVUNfQ1RYX1BS SU9SSVRZX0tNRF9OT1JNQUwsCj4+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICBkZXZfcHJp di0+a2VybmVsX2NvbnRleHQpOwo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgR1VDX0NU WF9QUklPUklUWV9LTURfTk9STUFMKTsKPj4gICAgICAgaWYgKCFndWMtPmV4ZWNidWZfY2xpZW50 KSB7Cj4+ICAgICAgICAgICBEUk1fRVJST1IoIkZhaWxlZCB0byBjcmVhdGUgR3VDIGNsaWVudCBm b3IgZXhlY2J1ZiFcbiIpOwo+PiAgICAgICAgICAgZ290byBlcnI7Cj4KPiBfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxp c3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==