From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 20/25] drm/i915: Differentiate between ggtt->mutex and ppgtt->mutex Date: Mon, 26 Nov 2018 11:13:16 +0000 Message-ID: <4fe7ba97-77b3-c4d5-b8ed-dd26d82e8ac5@linux.intel.com> References: <20181102161232.17742-1-chris@chris-wilson.co.uk> <20181102161232.17742-20-chris@chris-wilson.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 24B846E220 for ; Mon, 26 Nov 2018 11:13:18 +0000 (UTC) In-Reply-To: <20181102161232.17742-20-chris@chris-wilson.co.uk> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAyLzExLzIwMTggMTY6MTIsIENocmlzIFdpbHNvbiB3cm90ZToKPiBXZSBoYXZlIHR3byBj bGFzc2VzIG9mIFZNLCBnbG9iYWwgR1RUIGFuZCBwZXItcHJvY2VzcyBHVFQuIEluIG9yZGVyIHRv Cj4gYWxsb3cgb3Vyc2VsdmVzIHRoZSBmcmVlZG9tIHRvIG1peCBib3RoIGFsb25nIGNhbGwgY2hh aW5zLCBkaXN0aW5ndWlzaAo+IHRoZSB0d28gY2xhc3NlcyB3aXRoIHJlZ2FyZHMgdG8gdGhlaXIg bXV0ZXggYW5kIGxvY2tkZXAgbWFwcy4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBDaHJpcyBXaWxzb24g PGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiAtLS0KPiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfZ2VtX2d0dC5jICAgICAgIHwgMTAgKysrKystLS0tLQo+ICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW1fZ3R0LmggICAgICAgfCAgMiArKwo+ICAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvc2VsZnRlc3RzL21vY2tfZ3R0LmMgfCAgNiArKystLS0KPiAgIDMgZmlsZXMgY2hhbmdlZCwg MTAgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCkkgci1iLWVkIHRoaXMgb25lIGluIFNl cHRlbWJlciBhcyB3ZWxsLgoKUmV2aWV3ZWQtYnk6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJz dWxpbkBpbnRlbC5jb20+CgpSZWdhcmRzLAoKVHZydGtvCgo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtX2d0dC5jCj4gaW5kZXggNDVkOTgyYWY1MmE5Li5lMDViOGIwNGI1NWEgMTAwNjQ0Cj4g LS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMKPiArKysgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+IEBAIC00NzQsOCArNDc0LDcgQEAgc3RhdGlj IHZvaWQgdm1fZnJlZV9wYWdlKHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLCBzdHJ1Y3Qg cGFnZSAqcGFnZSkKPiAgIAlzcGluX3VubG9jaygmdm0tPmZyZWVfcGFnZXMubG9jayk7Cj4gICB9 Cj4gICAKPiAtc3RhdGljIHZvaWQgaTkxNV9hZGRyZXNzX3NwYWNlX2luaXQoc3RydWN0IGk5MTVf YWRkcmVzc19zcGFjZSAqdm0sCj4gLQkJCQkgICAgc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2KQo+ICtzdGF0aWMgdm9pZCBpOTE1X2FkZHJlc3Nfc3BhY2VfaW5pdChzdHJ1Y3QgaTkx NV9hZGRyZXNzX3NwYWNlICp2bSwgaW50IHN1YmNsYXNzKQo+ICAgewo+ICAgCS8qCj4gICAJICog VGhlIHZtLT5tdXRleCBtdXN0IGJlIHJlY2xhaW0gc2FmZSAoZm9yIHVzZSBpbiB0aGUgc2hyaW5r ZXIpLgo+IEBAIC00ODMsNiArNDgyLDcgQEAgc3RhdGljIHZvaWQgaTkxNV9hZGRyZXNzX3NwYWNl X2luaXQoc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gICAJICogYXR0ZW1wdCBob2xk aW5nIHRoZSBsb2NrIGlzIGltbWVkaWF0ZWx5IHJlcG9ydGVkIGJ5IGxvY2tkZXAuCj4gICAJICov Cj4gICAJbXV0ZXhfaW5pdCgmdm0tPm11dGV4KTsKPiArCWxvY2tkZXBfc2V0X3N1YmNsYXNzKCZ2 bS0+bXV0ZXgsIHN1YmNsYXNzKTsKPiAgIAlpOTE1X2dlbV9zaHJpbmtlcl90YWludHNfbXV0ZXgo JnZtLT5tdXRleCk7Cj4gICAKPiAgIAlHRU1fQlVHX09OKCF2bS0+dG90YWwpOwo+IEBAIC0xNTUw LDcgKzE1NTAsNyBAQCBzdGF0aWMgc3RydWN0IGk5MTVfaHdfcHBndHQgKmdlbjhfcHBndHRfY3Jl YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAgCS8qIEZyb20gYmR3LCB0aGVy ZSBpcyBzdXBwb3J0IGZvciByZWFkLW9ubHkgcGFnZXMgaW4gdGhlIFBQR1RULiAqLwo+ICAgCXBw Z3R0LT52bS5oYXNfcmVhZF9vbmx5ID0gdHJ1ZTsKPiAgIAo+IC0JaTkxNV9hZGRyZXNzX3NwYWNl X2luaXQoJnBwZ3R0LT52bSwgaTkxNSk7Cj4gKwlpOTE1X2FkZHJlc3Nfc3BhY2VfaW5pdCgmcHBn dHQtPnZtLCBWTV9DTEFTU19QUEdUVCk7Cj4gICAKPiAgIAkvKiBUaGVyZSBhcmUgb25seSBmZXcg ZXhjZXB0aW9ucyBmb3IgZ2VuID49Ni4gY2h2IGFuZCBieHQuCj4gICAJICogQW5kIHdlIGFyZSBu b3Qgc3VyZSBhYm91dCB0aGUgbGF0dGVyIHNvIHBsYXkgc2FmZSBmb3Igbm93Lgo+IEBAIC0xOTkw LDcgKzE5OTAsNyBAQCBzdGF0aWMgc3RydWN0IGk5MTVfaHdfcHBndHQgKmdlbjZfcHBndHRfY3Jl YXRlKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAgCj4gICAJcHBndHQtPmJhc2Uu dm0udG90YWwgPSBJOTE1X1BERVMgKiBHRU42X1BURVMgKiBJOTE1X0dUVF9QQUdFX1NJWkU7Cj4g ICAKPiAtCWk5MTVfYWRkcmVzc19zcGFjZV9pbml0KCZwcGd0dC0+YmFzZS52bSwgaTkxNSk7Cj4g KwlpOTE1X2FkZHJlc3Nfc3BhY2VfaW5pdCgmcHBndHQtPmJhc2Uudm0sIFZNX0NMQVNTX1BQR1RU KTsKPiAgIAo+ICAgCXBwZ3R0LT5iYXNlLnZtLmFsbG9jYXRlX3ZhX3JhbmdlID0gZ2VuNl9hbGxv Y192YV9yYW5nZTsKPiAgIAlwcGd0dC0+YmFzZS52bS5jbGVhcl9yYW5nZSA9IGdlbjZfcHBndHRf Y2xlYXJfcmFuZ2U7Cj4gQEAgLTM0MjUsNyArMzQyNSw3IEBAIGludCBpOTE1X2dndHRfaW5pdF9o dyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYpCj4gICAJICogYW5kIGJleW9uZCB0 aGUgZW5kIG9mIHRoZSBHVFQgaWYgd2UgZG8gbm90IHByb3ZpZGUgYSBndWFyZC4KPiAgIAkgKi8K PiAgIAltdXRleF9sb2NrKCZkZXZfcHJpdi0+ZHJtLnN0cnVjdF9tdXRleCk7Cj4gLQlpOTE1X2Fk ZHJlc3Nfc3BhY2VfaW5pdCgmZ2d0dC0+dm0sIGRldl9wcml2KTsKPiArCWk5MTVfYWRkcmVzc19z cGFjZV9pbml0KCZnZ3R0LT52bSwgVk1fQ0xBU1NfR0dUVCk7Cj4gICAKPiAgIAlnZ3R0LT52bS5p c19nZ3R0ID0gdHJ1ZTsKPiAgIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbV9ndHQuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtX2d0dC5oCj4gaW5k ZXggZTIzNjBmMTY0MjdhLi45MjI5YjAzZDYyOWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbV9ndHQuaAo+IEBAIC0yODgsNiArMjg4LDggQEAgc3RydWN0IGk5MTVfYWRkcmVzc19zcGFj ZSB7Cj4gICAJYm9vbCBjbG9zZWQ7Cj4gICAKPiAgIAlzdHJ1Y3QgbXV0ZXggbXV0ZXg7IC8qIHBy b3RlY3RzIHZtYSBhbmQgb3VyIGxpc3RzICovCj4gKyNkZWZpbmUgVk1fQ0xBU1NfR0dUVCAwCj4g KyNkZWZpbmUgVk1fQ0xBU1NfUFBHVFQgMQo+ICAgCj4gICAJdTY0IHNjcmF0Y2hfcHRlOwo+ICAg CXN0cnVjdCBpOTE1X3BhZ2VfZG1hIHNjcmF0Y2hfcGFnZTsKPiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfZ3R0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9zZWxmdGVzdHMvbW9ja19ndHQuYwo+IGluZGV4IDZhZTQxOGM3NjAxNS4uOTc2Yzg2MmIzODQy IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L3NlbGZ0ZXN0cy9tb2NrX2d0dC5j Cj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvc2VsZnRlc3RzL21vY2tfZ3R0LmMKPiBAQCAt NzAsNyArNzAsNyBAQCBtb2NrX3BwZ3R0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1LAo+ ICAgCXBwZ3R0LT52bS50b3RhbCA9IHJvdW5kX2Rvd24oVTY0X01BWCwgUEFHRV9TSVpFKTsKPiAg IAlwcGd0dC0+dm0uZmlsZSA9IEVSUl9QVFIoLUVOT0RFVik7Cj4gICAKPiAtCWk5MTVfYWRkcmVz c19zcGFjZV9pbml0KCZwcGd0dC0+dm0sIGk5MTUpOwo+ICsJaTkxNV9hZGRyZXNzX3NwYWNlX2lu aXQoJnBwZ3R0LT52bSwgVk1fQ0xBU1NfUFBHVFQpOwo+ICAgCj4gICAJcHBndHQtPnZtLmNsZWFy X3JhbmdlID0gbm9wX2NsZWFyX3JhbmdlOwo+ICAgCXBwZ3R0LT52bS5pbnNlcnRfcGFnZSA9IG1v Y2tfaW5zZXJ0X3BhZ2U7Cj4gQEAgLTEwMiw2ICsxMDIsNyBAQCB2b2lkIG1vY2tfaW5pdF9nZ3R0 KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICppOTE1KQo+ICAgCXN0cnVjdCBpOTE1X2dndHQgKmdn dHQgPSAmaTkxNS0+Z2d0dDsKPiAgIAo+ICAgCWdndHQtPnZtLmk5MTUgPSBpOTE1Owo+ICsJZ2d0 dC0+dm0uaXNfZ2d0dCA9IHRydWU7Cj4gICAKPiAgIAlnZ3R0LT5nbWFkciA9IChzdHJ1Y3QgcmVz b3VyY2UpIERFRklORV9SRVNfTUVNKDAsIDIwNDggKiBQQUdFX1NJWkUpOwo+ICAgCWdndHQtPm1h cHBhYmxlX2VuZCA9IHJlc291cmNlX3NpemUoJmdndHQtPmdtYWRyKTsKPiBAQCAtMTE3LDkgKzEx OCw4IEBAIHZvaWQgbW9ja19pbml0X2dndHQoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUp Cj4gICAJZ2d0dC0+dm0udm1hX29wcy5zZXRfcGFnZXMgICA9IGdndHRfc2V0X3BhZ2VzOwo+ICAg CWdndHQtPnZtLnZtYV9vcHMuY2xlYXJfcGFnZXMgPSBjbGVhcl9wYWdlczsKPiAgIAo+IC0JaTkx NV9hZGRyZXNzX3NwYWNlX2luaXQoJmdndHQtPnZtLCBpOTE1KTsKPiAgIAo+IC0JZ2d0dC0+dm0u aXNfZ2d0dCA9IHRydWU7Cj4gKwlpOTE1X2FkZHJlc3Nfc3BhY2VfaW5pdCgmZ2d0dC0+dm0sIFZN X0NMQVNTX0dHVFQpOwo+ICAgfQo+ICAgCj4gICB2b2lkIG1vY2tfZmluaV9nZ3R0KHN0cnVjdCBk cm1faTkxNV9wcml2YXRlICppOTE1KQo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK