From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Emde Subject: Re: [PATCH] properly enable the blc controller on the right pipe Date: Thu, 26 Jul 2012 00:35:22 +0200 Message-ID: <501074AA.1070905@osadl.org> References: <20120426170844.GG5156@phenom.ffwll.local> <1335461132-11664-1-git-send-email-daniel.vetter@ffwll.ch> <4F999E10.2060404@osadl.org> <20120426193004.GJ5156@phenom.ffwll.local> <4F9AFF00.8010705@osadl.org> <20120602230800.GB4737@phenom.ffwll.local> <50081313.8070206@osadl.org> <50088F7D.1020008@osadl.org> <20120720081046.GA5544@phenom.ffwll.local> <500E4F12.9040906@osadl.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from toro.web-alm.net (toro.web-alm.net [62.245.132.31]) by gabe.freedesktop.org (Postfix) with ESMTP id A89819E8F2 for ; Wed, 25 Jul 2012 15:40:11 -0700 (PDT) In-Reply-To: <500E4F12.9040906@osadl.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On 07/24/2012 09:30 AM, Carsten Emde wrote: > On 07/20/2012 10:10 AM, Daniel Vetter wrote: >> On Fri, Jul 20, 2012 at 12:51:41AM +0200, Carsten Emde wrote: >>> On 07/19/2012 04:40 PM, Daniel Vetter wrote: >>>> Well, the backlight-confusion branch had a bug and outright disabled >>>> the intel backlight :( drm-intel-next-queued should have fixes for all >>>> the backlight goofus I've accidentally created, so testing feedback on >>>> that branch would be highly appreciated. >>> This branch is now broken again. The original drm-intel-next-queued >>> branch works well (it still has the quirk), but after I reverted the >>> Acer quirk, the screen remains dark. >>> >>> I double-checked it and used exactly the same patch to revert the >>> quirk in the two trees: The backlight-confusion branch works, and >>> the drm-intel-next-queued branch does not. >>> >>> I then used drivers/gpu/drm/i915/intel_panel.c from >>> backlight-confusion in drm-intel-next-queued and - it worked again. >>> When testing the two differences separately it turned out this patch >>> did the magic: >> >> Yeah, I guess your system only worked whith the old code because it >> accidentally disabled the entire backlight stuff. Now that that doesn't >> happen any more, it's as broken as ever. >> >> I'll look into creating another patch, afaict from digging through git >> history, this backlight combination mode is totally bogus. But if we kill >> it, a few machines will resume with dimmed backlight, because we don't >> restore the lbpc register properly. > After all that hassle and bearing in mind that we found only two > notebooks so far, Acer Aspire 5732Z and 5734Z, that suffer from this > backlight inversion problem, shouldn't we simply return to the quirk > solution? I would quickly add the data of the other Acer to the > backlight quirks, send a rebased patch, and we are all set. These are the data of the other Acer Aspire that needs backlight inversion. Index: linux-git/drivers/gpu/drm/i915/intel_display.c =================================================================== --- linux-git.orig/drivers/gpu/drm/i915/intel_display.c +++ linux-git/drivers/gpu/drm/i915/intel_display.c @@ -6877,7 +6877,8 @@ static struct intel_quirk intel_quirks[] /* Sony Vaio Y cannot use SSC on LVDS */ { 0x0046, 0x104d, 0x9076, quirk_ssc_force_disable }, - /* Acer Aspire 5734Z must invert backlight brightness */ + /* Acer Aspire 5732Z and 5734Z must invert backlight brightness */ + { 0x2a42, 0x1025, 0x0212, quirk_invert_brightness }, { 0x2a42, 0x1025, 0x0459, quirk_invert_brightness }, }; Do you wish me to submit this as a regular patch? -Carsten.