Re: [PATCH] drm/i915: Clear FORCEWAKE when taking over from BIOS

Mika Kuoppala
2012-10-19T09:10:18Z

On Fri, 19 Oct 2012 09:02:10 +0100, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Fri, 19 Oct 2012 10:22:49 +0300, Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote:
> > Would it be possible to call in here:
> >
> > if (HAS_FORCE_WAKE(dev))
> > dev_priv->gt.force_wake_put(dev_priv);
> >
> > and get rid of the per gen forcewake resets?
>
> No. Perhaps I would have better gone with intel_gt_sanitize(), as the
> purpose is not to undo our own settings of the forcewake but undo that
> of nefarious foreign interests such as the BIOS. As such we need to
> explicitly clear the register rather than clear a bit.
> -Chris

Thanks for explanation.

Reviewed-by: Mika Kuoppala <mika.kuoppala@intel.com>

> --
> Chris Wilson, Intel Open Source Technology Centre
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki
Business Identity Code: 0357606 - 4
Domiciled in Helsinki

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.