Re: [PATCH] drm/i915: Clear FORCEWAKE when taking over from BIOS

Chris Wilson
2012-10-19T08:02:33Z

On Fri, 19 Oct 2012 10:22:49 +0300, Mika Kuoppala <mika.kuoppala@linux.intel.com> wrote:
> Would it be possible to call in here:
>
> if (HAS_FORCE_WAKE(dev))
> dev_priv->gt.force_wake_put(dev_priv);
>
> and get rid of the per gen forcewake resets?

No. Perhaps I would have better gone with intel_gt_sanitize(), as the
purpose is not to undo our own settings of the forcewake but undo that
of nefarious foreign interests such as the BIOS. As such we need to
explicitly clear the register rather than clear a bit.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre