From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zoltan Nyul Subject: Re: [PATCH 0/8] Don't let the ghost eDP haunt us Date: Tue, 18 Jun 2013 10:21:37 +0300 Message-ID: <51C00A81.4050207@gmail.com> References: <1371394640-1130-1-git-send-email-daniel.vetter@ffwll.ch> <20130617143331.GS30071@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pb0-f51.google.com (mail-pb0-f51.google.com [209.85.160.51]) by gabe.freedesktop.org (Postfix) with ESMTP id B4216E6152 for ; Tue, 18 Jun 2013 00:21:40 -0700 (PDT) Received: by mail-pb0-f51.google.com with SMTP id um15so3603159pbc.10 for ; Tue, 18 Jun 2013 00:21:40 -0700 (PDT) Received: from [10.10.15.62] ([194.136.86.45]) by mx.google.com with ESMTPSA id ka16sm11970364pad.14.2013.06.18.00.21.39 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 18 Jun 2013 00:21:40 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This patch series seems ok for me. Reviewed-by: Zoltan Nyul > Hi > > This week I sent a patch called "drm/i915: propagate errors from > intel_dp_init_connector" to fix a Haswell bug that was preventing my machine > from booting. Chris provided a nice suggestion for it, so this series should > implement his suggestion, but split in a few patches. While writing this code I > also spotted a few other things, so there are some patches for them here. Patch > 3 is the real bug fix and patches 4 & 5 implement Chris's suggestions. Patch 1 > is another bug fix and patches 2, 6, 7 & 8 are my bikesheds for the current > code. > > Thanks, > Paulo > > Paulo Zanoni (8): > drm/i915: don't check encoder at DP connector destroy() > drm/i915: extract intel_edp_init_connector > drm/i915: propagate errors from intel_dp_init_connector > drm/i915: fix the "ghost eDP" connector unwind path > drm/i915: fix the "ghost eDP" encoder unwind path > drm/i915: check the return value of intel_dp_i2c_init > drm/i915: invert the verbosity of intel_enable_fbc > drm/i915: rename intel_dp_destroy to intel_dp_connector_destroy > > drivers/gpu/drm/i915/intel_ddi.c | 7 +- > drivers/gpu/drm/i915/intel_dp.c | 180 +++++++++++++++++++++++---------------- > drivers/gpu/drm/i915/intel_drv.h | 2 +- > drivers/gpu/drm/i915/intel_pm.c | 3 +- > 4 files changed, 113 insertions(+), 79 deletions(-) > > -- > 1.8.1.2