From: Thomas Richter <thor@math.tu-berlin.de>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Avoid flicker with horizontal panning on 830GM
Date: Thu, 05 Sep 2013 16:51:55 +0200 [thread overview]
Message-ID: <52289A8B.2090100@math.tu-berlin.de> (raw)
In-Reply-To: <2593_1378131525_52249E45_2593_4993_1_20130902141857.GW9374@phenom.ffwll.local>
Am 02.09.2013 16:18, schrieb Daniel Vetter:
> Hm, I've probably botched the watermarks again. Can you please retest with
> the below diff?
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index dfdc7ad..b667ff0 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -1064,6 +1064,8 @@ static unsigned long intel_calculate_wm(unsigned long clock_in_khz,
>
> DRM_DEBUG_KMS("FIFO watermark level: %ld\n", wm_size);
>
> + wm_size = 0;
> +
> /* Don't promote wm_size to unsigned... */
> if (wm_size> (long)wm->max_wm)
> wm_size = wm->max_wm;
As this didn't work either, could you point me to a documentation of the
830M so I could have a look myself? Unfortunately, I did not find
anything appropriate, only an overall description of the chipset that
lists all the RAM/addressing related registers and a high-level
description of the gpu features, but nothing detailed on the 2D graphics
and VGA-related registers.
Thanks,
Thomas
next prev parent reply other threads:[~2013-09-05 14:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 17:01 [PATCH] drm/i915: Avoid flicker with horizontal panning on 830GM Thomas Richter
2013-09-02 7:10 ` Daniel Vetter
2013-09-02 14:12 ` Ville Syrjälä
[not found] ` <2593_1378105810_522439D2_2593_1811_1_20130902071022.GP9374@phenom.ffwll.local>
2013-09-02 13:58 ` Thomas Richter
2013-09-02 14:18 ` Daniel Vetter
2013-09-02 14:21 ` Ville Syrjälä
[not found] ` <2593_1378131525_52249E45_2593_4993_1_20130902141857.GW9374@phenom.ffwll.local>
2013-09-02 15:21 ` Thomas Richter
2013-09-05 14:51 ` Thomas Richter [this message]
2013-09-05 14:56 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52289A8B.2090100@math.tu-berlin.de \
--to=thor@math.tu-berlin.de \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox