From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Richter <thor@math.tu-berlin.de>
Subject: Re: [PATCH] drm/i915: Avoid flicker with horizontal
	panning on 830GM
Date: Thu, 05 Sep 2013 16:51:55 +0200
Message-ID: <52289A8B.2090100@math.tu-berlin.de>
References: <522372FD.5080001@math.tu-berlin.de>
	<2593_1378105810_522439D2_2593_1811_1_20130902071022.GP9374@phenom.ffwll.local>
	<522499A3.50502@math.tu-berlin.de>
	<2593_1378131525_52249E45_2593_4993_1_20130902141857.GW9374@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from medousa.rus.uni-stuttgart.de (medousa.rus.uni-stuttgart.de
	[129.69.192.4])
	by gabe.freedesktop.org (Postfix) with ESMTP id 75042E5CEA
	for <intel-gfx@lists.freedesktop.org>;
	Thu,  5 Sep 2013 07:52:25 -0700 (PDT)
In-Reply-To: <2593_1378131525_52249E45_2593_4993_1_20130902141857.GW9374@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Daniel Vetter <daniel@ffwll.ch>
Cc: daniel.vetter@ffwll.ch, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

Am 02.09.2013 16:18, schrieb Daniel Vetter:
> Hm, I've probably botched the watermarks again. Can you please retest with
> the below diff?
>
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index dfdc7ad..b667ff0 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -1064,6 +1064,8 @@ static unsigned long intel_calculate_wm(unsigned long clock_in_khz,
>
>   	DRM_DEBUG_KMS("FIFO watermark level: %ld\n", wm_size);
>
> +	wm_size = 0;
> +
>   	/* Don't promote wm_size to unsigned... */
>   	if (wm_size>  (long)wm->max_wm)
>   		wm_size = wm->max_wm;
As this didn't work either, could you point me to a documentation of the 
830M so I could have a look myself? Unfortunately, I did not find 
anything appropriate, only an overall description of the chipset that 
lists all the RAM/addressing related registers and a high-level 
description of the gpu features, but nothing detailed on the 2D graphics 
and VGA-related registers.

Thanks,
     Thomas