public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Todd Previte <tprevite@gmail.com>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Implement Displayport automated testing
Date: Fri, 04 Oct 2013 11:11:55 -0700	[thread overview]
Message-ID: <524F04EB.2050806@gmail.com> (raw)
In-Reply-To: <87li292r3f.fsf@intel.com>

On 10/4/13 4:49 AM, Jani Nikula wrote:
> On Fri, 04 Oct 2013, Todd Previte<tprevite@gmail.com>  wrote:
>> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
>> index ae8dbfb..9fa544b 100644
>> --- a/include/drm/drm_dp_helper.h
>> +++ b/include/drm/drm_dp_helper.h
>> @@ -266,9 +266,10 @@
>>   
>>   #define DP_TEST_REQUEST			    0x218
>>   # define DP_TEST_LINK_TRAINING		    (1 << 0)
>> -# define DP_TEST_LINK_PATTERN		    (1 << 1)
>> +# define DP_TEST_LINK_VIDEO_PATTERN	    (1 << 1)
>>   # define DP_TEST_LINK_EDID_READ		    (1 << 2)
>>   # define DP_TEST_LINK_PHY_TEST_PATTERN	    (1 << 3) /* DPCD >= 1.1 */
>> +# define DP_TEST_LINK_FAUX_TEST_PATTERN	    (1 << 4) /* DPCD >= 1.2 */
>>   
>>   #define DP_TEST_LINK_RATE		    0x219
>>   # define DP_LINK_RATE_162		    (0x6)
> This hunk needs to be a separate patch, and sent to dri-devel.
>
> Jani.
>
>
>
Oh right. Originally I was using local definitions until I found those 
in the header and used them instead. I'll break those out into a 
separate patch for V2 as well. Thanks Jani.

-T

  reply	other threads:[~2013-10-04 18:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-04 10:32 [PATCH] drm/i915: Implement Displayport automated testing Todd Previte
2013-10-04 10:45 ` Chris Wilson
2013-10-04 18:11   ` Todd Previte
2013-10-04 20:39     ` Ben Widawsky
2013-10-04 23:00       ` Todd Previte
2013-10-04 11:49 ` Jani Nikula
2013-10-04 18:11   ` Todd Previte [this message]
2013-10-04 19:53 ` [PATCH V2] " Todd Previte
2013-11-01 22:44 ` [PATCH V3] " Todd Previte
2013-11-01 22:44   ` [PATCH] " Todd Previte
2013-11-05  9:21     ` Jani Nikula
2013-11-05 21:01       ` Todd Previte
2013-11-05 21:47         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=524F04EB.2050806@gmail.com \
    --to=tprevite@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox