From mboxrd@z Thu Jan 1 00:00:00 1970 From: Todd Previte Subject: Re: [PATCH] drm/i915: Implement Displayport automated testing Date: Fri, 04 Oct 2013 11:11:55 -0700 Message-ID: <524F04EB.2050806@gmail.com> References: <1380882730-32207-1-git-send-email-tprevite@gmail.com> <87li292r3f.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pb0-f42.google.com (mail-pb0-f42.google.com [209.85.160.42]) by gabe.freedesktop.org (Postfix) with ESMTP id F217CE7C81 for ; Fri, 4 Oct 2013 11:10:12 -0700 (PDT) Received: by mail-pb0-f42.google.com with SMTP id un15so4366757pbc.1 for ; Fri, 04 Oct 2013 11:10:12 -0700 (PDT) In-Reply-To: <87li292r3f.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 10/4/13 4:49 AM, Jani Nikula wrote: > On Fri, 04 Oct 2013, Todd Previte wrote: >> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h >> index ae8dbfb..9fa544b 100644 >> --- a/include/drm/drm_dp_helper.h >> +++ b/include/drm/drm_dp_helper.h >> @@ -266,9 +266,10 @@ >> >> #define DP_TEST_REQUEST 0x218 >> # define DP_TEST_LINK_TRAINING (1 << 0) >> -# define DP_TEST_LINK_PATTERN (1 << 1) >> +# define DP_TEST_LINK_VIDEO_PATTERN (1 << 1) >> # define DP_TEST_LINK_EDID_READ (1 << 2) >> # define DP_TEST_LINK_PHY_TEST_PATTERN (1 << 3) /* DPCD >= 1.1 */ >> +# define DP_TEST_LINK_FAUX_TEST_PATTERN (1 << 4) /* DPCD >= 1.2 */ >> >> #define DP_TEST_LINK_RATE 0x219 >> # define DP_LINK_RATE_162 (0x6) > This hunk needs to be a separate patch, and sent to dri-devel. > > Jani. > > > Oh right. Originally I was using local definitions until I found those in the header and used them instead. I'll break those out into a separate patch for V2 as well. Thanks Jani. -T