From: Thomas Richter <thor@math.tu-berlin.de>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: [PATCH] 835GM DLL setup
Date: Sun, 06 Oct 2013 01:04:14 +0200 [thread overview]
Message-ID: <52509AEE.9000006@math.tu-berlin.de> (raw)
In-Reply-To: <29761_1380973482_524FFBA9_29761_4042_1_20131005114432.GE9395@intel.com>
Hi Daniel, hi folks,
after another evening of debugging, I believe I know now how to prevent
the ns2501 DVO from locking up. It rather seems that this is due to a
bug in the intel_display module, in specific in the pll update function.
That is, edit intel_display.c, function i8xx_update_dll(), and insert
the following lines to setup the PLL value:
if (inten_pipe_has_type(&crtc->base,INTEL_OUTPUT_DVO)) {
dpll |= DPLL_DVO_HIGH_SPEED;
}
This is actually pretty much the same logic as in the i9xx setup, and
this is the very same bit the ns2501 "hack" logic sets to enable the
DVO. With this patch, I no longer see that the ns2501 hack actually has
to re-activate the DVO, it just continues to run in all modes (1024x768
to 640x480).
There might still be a catch with external monitors connected, I'm not
quite sure how this works. Screen duplication with 1024x768 and 800x600
works, but it does not work with 640x480 for reasons not quite clear to
me. Maybe the DVO sits then on pipe B and the update logic is not called
correctly, or the DVO does not need the high-speed flag in this specific
case. Also, during bootup, the external monitor flickers as if the
"watermark" levels are not set correctly. This goes away as soon as X
starts up.
But anyhow, at least I believe the problem for the DVO "lockup" issue is
found. The above patch probably needs to go into some other functions
that modify the PLL settings.
I will try how much of the "ns2501 dvo hack" can now go away. It should
hopefully no longer be necessary.
Greetings,
Thomas
next prev parent reply other threads:[~2013-10-05 23:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 22:51 [PATCH] drm/i915: enable trickle feed on Haswell Paulo Zanoni
2013-08-30 17:25 ` Ville Syrjälä
2013-09-02 6:01 ` Daniel Vetter
[not found] ` <29427_1378101775_52242A0E_29427_747_1_20130902060151.GE9374@phenom.ffwll.local>
2013-10-05 8:33 ` Questions on display pipes on 835GM Thomas Richter
2013-10-05 11:44 ` Ville Syrjälä
[not found] ` <29761_1380973482_524FFBA9_29761_4042_1_20131005114432.GE9395@intel.com>
2013-10-05 16:47 ` Thomas Richter
2013-10-05 19:24 ` Daniel Vetter
2013-10-05 19:39 ` Daniel Vetter
[not found] ` <29761_1381001928_52506AC8_29761_5606_1_20131005193904.GX31334@phenom.ffwll.local>
2013-10-05 23:09 ` Thomas Richter
2013-10-05 23:37 ` Daniel Vetter
[not found] ` <5132_1381149082_5252A99A_5132_80_1_CAKMK7uHkOJ=urFKCacocf_i+6YL9Azf5vK=Au-kRJMi=sNBP1Q@mail.gmail.com>
2013-10-07 21:58 ` Broken in 3.10.10 (was: Questions on display pipes on 835GM) Thomas Richter
2013-10-08 7:24 ` Daniel Vetter
2013-10-08 8:39 ` Daniel Vetter
2013-10-08 9:14 ` Chris Wilson
[not found] ` <26192_1381221546_5253C4A9_26192_7222_1_CAKMK7uGvk9vuNXunutyHjkGjvBWsv7ObN02EfbG2679MtQ5M=A@mail.gmail.com>
2013-10-08 17:06 ` Broken in 3.10.10 Thomas Richter
2013-10-05 23:04 ` Thomas Richter [this message]
2013-10-05 23:46 ` [PATCH] 835GM DLL setup Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52509AEE.9000006@math.tu-berlin.de \
--to=thor@math.tu-berlin.de \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox