From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kenneth Graunke <kenneth@whitecape.org>
Subject: Re: [PATCH 1/2] drm/i915/hsw: Add
 I915_EXEC_RESOURCE_STREAMER flag
Date: Wed, 09 Oct 2013 14:40:22 -0700
Message-ID: <5255CD46.40407@whitecape.org>
References: <1381266592-7558-1-git-send-email-abdiel.janulgue@linux.intel.com>
	<1381266592-7558-2-git-send-email-abdiel.janulgue@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from hapkido.dreamhost.com (hapkido.dreamhost.com [66.33.216.122])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5ABE5E8869
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  9 Oct 2013 14:40:04 -0700 (PDT)
Received: from homiemail-a14.g.dreamhost.com (caiajhbdcaib.dreamhost.com
	[208.97.132.81])
	by hapkido.dreamhost.com (Postfix) with ESMTP id 1DAC0DE968
	for <intel-gfx@lists.freedesktop.org>;
	Wed,  9 Oct 2013 14:40:03 -0700 (PDT)
In-Reply-To: <1381266592-7558-2-git-send-email-abdiel.janulgue@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 10/08/2013 02:09 PM, Abdiel Janulgue wrote:
> Ensures that the batch buffer is executed by the resource streamer.
> 
> Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
> ---
>  drivers/gpu/drm/i915/i915_gem_execbuffer.c |    2 ++
>  include/uapi/drm/i915_drm.h                |    5 +++++
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> index 0ce0d47..4a56c58 100644
> --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c
> @@ -962,6 +962,8 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
>  	case I915_EXEC_DEFAULT:
>  	case I915_EXEC_RENDER:
>  		ring = &dev_priv->ring[RCS];
> +		flags |= (args->flags & I915_EXEC_RESOURCE_STREAMER) ?
> +		  I915_EXEC_RESOURCE_STREAMER : 0;
>  		break;
>  	case I915_EXEC_BSD:
>  		ring = &dev_priv->ring[VCS];
> diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
> index 3a4e97b..5a4bd16 100644
> --- a/include/uapi/drm/i915_drm.h
> +++ b/include/uapi/drm/i915_drm.h
> @@ -731,6 +731,11 @@ struct drm_i915_gem_execbuffer2 {
>   */
>  #define I915_EXEC_HANDLE_LUT		(1<<12)
>  
> +/** Tell the kernel that the batchbuffer is processed by
> + *  the resource streamer.
> + */
> +#define I915_EXEC_RESOURCE_STREAMER     (1<<13)
> +
>  #define __I915_EXEC_UNKNOWN_FLAGS -(I915_EXEC_HANDLE_LUT<<1)
>  
>  #define I915_EXEC_CONTEXT_ID_MASK	(0xffffffff)
> 

I think you need to change __I915_EXEC_UNKNOWN_FLAGS to:

#define __I915_EXEC_UNKNOWN_FLAGS -(I915_EXEC_RESOURCE_STREAMER<<1)

since you've added a new bit.