From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chad Versace Subject: Re: [PATCH intel-gpu-tools] configure: Don't bail if libdrm_nouveau isn't available. Date: Fri, 11 Oct 2013 15:52:22 -0700 Message-ID: <52588126.4060302@linux.intel.com> References: <1381463805-10521-1-git-send-email-mattst88@gmail.com> <20131011212409.GI8303@phenom.ffwll.local> <5258810E.7080207@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 4A291E84CA for ; Fri, 11 Oct 2013 15:52:27 -0700 (PDT) In-Reply-To: <5258810E.7080207@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chad Versace Cc: Ben Widawsky , Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org On 10/11/2013 03:51 PM, Chad Versace wrote: > On 10/11/2013 02:29 PM, Matt Turner wrote: >> On Fri, Oct 11, 2013 at 2:24 PM, Daniel Vetter wrote: >>> On Fri, Oct 11, 2013 at 12:51:34PM -0700, Matt Turner wrote: >>>> On Fri, Oct 11, 2013 at 12:40 AM, Daniel Vetter wrote: >>>>> On Fri, Oct 11, 2013 at 5:56 AM, Matt Turner wrote: >>>>>> We were seriously *requiring* libdrm_nouveau unless explicitly disabled? >>>>> >>>>> I've had a bit of hilarious fail with optional testcases that >>>>> automatically get disabled when depencies aren't around. Hence why >>>>> they're all required by default with the optional switch to disable >>>>> them. >>>> >>>> You've had this problem in general, or with nouveau? >>> >>> In general. >> >> So I think what I'm saying is that the nouveau support in >> intel-gpu-tools isn't the project's primary purpose, so we should >> allow it to build without nouveau support if you don't have nouveau >> installed. If you don't have nouveau installed, you're not making a >> mistake by not building intel-gpu-tools without support. And if you >> have nouveau installed, you still get nouveau support. > > I completely agree with Matt. > > If the system doesn't already have nouveau installed, then it there is very > low likelihood that it makes any sense to install nouveau onto that system. > It very likely does not have NVidia hardware at all. So why require it? > Let's just autodetect it and behave sanely. > > Requiring libdrm_nouveau is a nuisance for developers working on platforms > where libdrm doesn't get built with NVidia support. And, this patch gets Reviewed-by: Chad Versace