From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EA97C2B9F4 for ; Fri, 25 Jun 2021 12:03:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A01C61623 for ; Fri, 25 Jun 2021 12:03:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A01C61623 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B0F786ED98; Fri, 25 Jun 2021 12:03:52 +0000 (UTC) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC2D16EDAE; Fri, 25 Jun 2021 12:03:51 +0000 (UTC) IronPort-SDR: SS7+MTwp3lm0l6HpKw/TqQ1fJRpFy9bTHKPXyRJv/YyFrEBxOEgzgF6miosUy6xZ8yd/PLDLSw IhsV44PT1CgQ== X-IronPort-AV: E=McAfee;i="6200,9189,10025"; a="207592094" X-IronPort-AV: E=Sophos;i="5.83,298,1616482800"; d="scan'208";a="207592094" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jun 2021 05:03:45 -0700 IronPort-SDR: pVrKN1E2/V05ki7uEUhKCaRwLGYr/o06JhRO7g+2m+nTzwPRzaSebX5aCI7FqoXWUWjRlku0H4 DQx0A7+o85KQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,298,1616482800"; d="scan'208";a="488158409" Received: from irvmail001.ir.intel.com ([10.43.11.63]) by orsmga001.jf.intel.com with ESMTP; 25 Jun 2021 05:03:41 -0700 Received: from [10.249.158.233] (mwajdecz-MOBL.ger.corp.intel.com [10.249.158.233]) by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id 15PC3drJ023148; Fri, 25 Jun 2021 13:03:40 +0100 To: Matthew Brost References: <20210624070516.21893-1-matthew.brost@intel.com> <20210624070516.21893-4-matthew.brost@intel.com> <0b04e2ee-f5f3-3eb9-ad9f-a595f1942e4c@intel.com> <20210624154158.GA1629@sdutt-i7> From: Michal Wajdeczko Message-ID: <5264ef27-efbd-1adf-b45c-602a59fb4d6d@intel.com> Date: Fri, 25 Jun 2021 14:03:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210624154158.GA1629@sdutt-i7> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 03/47] drm/i915/guc: Increase size of CTB buffers X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 24.06.2021 17:41, Matthew Brost wrote: > On Thu, Jun 24, 2021 at 03:49:55PM +0200, Michal Wajdeczko wrote: >> >> >> On 24.06.2021 09:04, Matthew Brost wrote: >>> With the introduction of non-blocking CTBs more than one CTB can be in >>> flight at a time. Increasing the size of the CTBs should reduce how >>> often software hits the case where no space is available in the CTB >>> buffer. >>> >>> Cc: John Harrison >>> Signed-off-by: Matthew Brost >>> --- >>> drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 11 ++++++++--- >>> 1 file changed, 8 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c >>> index 07f080ddb9ae..a17215920e58 100644 >>> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c >>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c >>> @@ -58,11 +58,16 @@ static inline struct drm_device *ct_to_drm(struct intel_guc_ct *ct) >>> * +--------+-----------------------------------------------+------+ >>> * >>> * Size of each `CT Buffer`_ must be multiple of 4K. >>> - * As we don't expect too many messages, for now use minimum sizes. >>> + * We don't expect too many messages in flight at any time, unless we are >>> + * using the GuC submission. In that case each request requires a minimum >>> + * 2 dwords which gives us a maximum 256 queue'd requests. Hopefully this >>> + * enough space to avoid backpressure on the driver. We increase the size >>> + * of the receive buffer (relative to the send) to ensure a G2H response >>> + * CTB has a landing spot. >>> */ >>> #define CTB_DESC_SIZE ALIGN(sizeof(struct guc_ct_buffer_desc), SZ_2K) >>> #define CTB_H2G_BUFFER_SIZE (SZ_4K) >>> -#define CTB_G2H_BUFFER_SIZE (SZ_4K) >>> +#define CTB_G2H_BUFFER_SIZE (4 * CTB_H2G_BUFFER_SIZE) >>> >>> struct ct_request { >>> struct list_head link; >>> @@ -641,7 +646,7 @@ static int ct_read(struct intel_guc_ct *ct, struct ct_incoming_msg **msg) >>> /* beware of buffer wrap case */ >>> if (unlikely(available < 0)) >>> available += size; >>> - CT_DEBUG(ct, "available %d (%u:%u)\n", available, head, tail); >>> + CT_DEBUG(ct, "available %d (%u:%u:%u)\n", available, head, tail, size); >> >> CTB size is already printed in intel_guc_ct_init() and is fixed so not >> sure if repeating it on every ct_read has any benefit >> > > I'd say more debug the better and if CT_DEBUG is enabled the logs are > very verbose so an extra value doesn't really hurt. fair, but this doesn't mean we should add little/no value item, anyway since DEBUG_GUC is if off by default, this is: Reviewed-by: Michal Wajdeczko > > Matt > >>> GEM_BUG_ON(available < 0); >>> >>> header = cmds[head]; >>> _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx