Re: More questions and patches for 835GM/ns2501 DVO

Daniel Vetter
2013-11-04T07:15:32Z

On Mon, Nov 4, 2013 at 12:09 AM, Thomas Richter <thor@math.tu-berlin.de> wrote:
> On 03.11.2013 22:18, Daniel Vetter wrote:
>>
>>
>> Hm, that would mean that the cursor is somehow stuck in the enabled state,
>> despite that we've tried to disabled it very hard. Can you please try out
>> the below patch? If this doesn't work please take not of the different
>> WARNINGs you're hitting and whether it's always the same one with the same
>> calltrace or something different.
>>
>> I think for now we should try to get the single monitor case working - I
>> have a few theories for the dual-screen issues, but there's not much point
>> working on them if the simple case doesn't work yet.
>>
>> Also I think I'll merge the two patches if they don't make things worse
>> for you, imo it's the right approach and at least conceptually should be
>> able to avoid all these retry loops.
>
> Thanks for the patches. Tried quite a bit, and haven't seen the warning yet.
> Looks like the one-monitor
> case works quite fine now, except that the boot console is vertically "off",
> which is just annoying though
> not problematic.

Awesome. I'll try to merge these patches with cc: stable.

> I also tried a lot with the two-monitor case and again went deeply into the
> DPLL setup logic.
> The differences I observed before are simply due to the initial resolution
> (800x600), in the final
> resolution, the DPLL settings are actually correct. What I get there is:

I suspect that due to the pipe A quirk logic we actually get the setup
sequence for the DPLLs completely wrong. This will require a bit more
magic to make it work correctly ... But I have some ideas.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch