From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shobhit Kumar Subject: Re: [PATCH v2 0/7] drm/i915: Baytrail MIPI DSI support Updated Date: Mon, 11 Nov 2013 15:58:56 +0530 Message-ID: <5280B168.4080801@intel.com> References: <1383990548-30737-1-git-send-email-shobhit.kumar@intel.com> <20131109102816.GJ14082@phenom.ffwll.local> <20131111085057.GB3884@ulmo.nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20131111085057.GB3884@ulmo.nvidia.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Thierry Reding , Daniel Vetter Cc: jani.nikula@intel.com, intel-gfx , DRI Development , vijayakumar.balakrishnan@intel.com, yogesh.mohan.marimuthu@intel.com, Thierry Reding List-Id: intel-gfx@lists.freedesktop.org On 11/11/2013 02:20 PM, Thierry Reding wrote: > On Sat, Nov 09, 2013 at 11:28:16AM +0100, Daniel Vetter wrote: >> On Sat, Nov 09, 2013 at 03:19:01PM +0530, Shobhit Kumar wrote: >>> Hi All - >>> These patches enhance the current support for MIPI DSI for Baytrail. They >>> continue on the sub-encoder design and adds few more dev_ops to handle >>> sequence correctly. Major changes are - >>> >>> 1. DSI Clock calculation based on pixel clock >>> 2. Add new dev_ops for better sequencing the enable/disable path >>> 3. Parameterized the hardcoded DSI parameters. These also forms building >>> block for the generic MIPI driver to come in future based on enhancements >>> in VBT. All these parameters are initialized or computed in the sub-encoder >>> driver. Some of them might look unneccesary for now. >>> >>> I am also aware of the drm_bridge support now comming in and will in future >>> migrate from sub-encoder design to drm_bridge. >> >> Just a quick aside: Thierry Reding from nvidia is also working on a DSI >> design for the tegra driver. Atm he seems to aim for a full-blown DSI bus >> based on his drm_panel patches for getting the panel metadata out of an >> ARM DT (we'd use VBT instead). Iirc there's no patches anywhere yet, but >> maybe Thierry could share a git branch somewhere with the wip stuff? >> >> Cc'ing Thierry and dri-devel in case a bigger discussion develops. > > I've been cleaning up the patches and was going to post them today. The > implementation really isn't as "full-blown" as you make it sound =), > primarily because the DSI panel that I have doesn't support things such > as reading out the DDB, so I cannot test most of the functionality that > I planned to. > > However I think introducing a DSI bus type is the right thing and it's > been suggested recently that we have too few bus types. Furthermore it > seems to be playing out rather nicely with the DRM panel work, so it > would be really nice if Intel could test-drive this within their driver > to see if it's good enough for their purposes as well. Interesting. Would be nice to have a look. > > Is everyone working on that subscribed to dri-devel or should I Cc the > intel-gfx mailing list (or someone in particular) when posting the > patches? > Will keep an eye for your patches in dri-devel. Regards Shobhit