From mboxrd@z Thu Jan  1 00:00:00 1970
From: Todd Previte <tprevite@gmail.com>
Subject: Re: [PATCH] drm/i915/dp: set sink to power down mode on
	dp disable
Date: Tue, 12 Nov 2013 09:37:52 -0700
Message-ID: <52825960.1040300@gmail.com>
References: <1384269013-8910-1-git-send-email-jani.nikula@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-pd0-f176.google.com (mail-pd0-f176.google.com
	[209.85.192.176])
	by gabe.freedesktop.org (Postfix) with ESMTP id A5D97FA442
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 12 Nov 2013 08:37:59 -0800 (PST)
Received: by mail-pd0-f176.google.com with SMTP id r10so1769753pdi.21
	for <intel-gfx@lists.freedesktop.org>;
	Tue, 12 Nov 2013 08:37:55 -0800 (PST)
In-Reply-To: <1384269013-8910-1-git-send-email-jani.nikula@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 11/12/13 8:10 AM, Jani Nikula wrote:
> We used to put the local sink and any downstream sinks to power down
> mode at disable or dpms off using the DPCD SET_POWER register, until
> this was broken by
>
> commit e8cb455876fa8f67c6aba394d0a14b697bf04cc3
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Sun Jul 1 13:05:48 2012 +0200
>
>      drm/i915/dp: convert to encoder disable/enable
>
> Fix it.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>   drivers/gpu/drm/i915/intel_dp.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index dbe4840..cbf33be 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1774,7 +1774,7 @@ static void intel_disable_dp(struct intel_encoder *encoder)
>   	 * ensure that we have vdd while we switch off the panel. */
>   	ironlake_edp_panel_vdd_on(intel_dp);
>   	ironlake_edp_backlight_off(intel_dp);
> -	intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_ON);
> +	intel_dp_sink_dpms(intel_dp, DRM_MODE_DPMS_OFF);
>   	ironlake_edp_panel_off(intel_dp);
>
>   	/* cpu edp my only be disable _after_ the cpu pipe/plane is disabled. */

Reviewed-by: Todd Previte <tprevite@gmail.com>