From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/4] drm/i915: Handle incomplete Z_FINISH for compressed error states Date: Tue, 2 Oct 2018 15:34:43 +0100 Message-ID: <528f0db4-9d6f-dc89-d3bf-cf4cc6858d64@linux.intel.com> References: <20181001194447.29910-1-chris@chris-wilson.co.uk> <20181001194447.29910-2-chris@chris-wilson.co.uk> <673d9c33-df35-d403-3e61-fbbc98047ba6@linux.intel.com> <153848307796.23109.12963662055734893298@skylake-alporthouse-com> <5b408c9d-a3da-ffa3-55b8-e2a8da856e43@linux.intel.com> <153848656029.23109.17013640697174613167@skylake-alporthouse-com> <650e482e-74c0-c996-6065-a56a5ec6855d@linux.intel.com> <153848833858.23109.12163375002290599091@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6786689269 for ; Tue, 2 Oct 2018 14:35:00 +0000 (UTC) In-Reply-To: <153848833858.23109.12163375002290599091@skylake-alporthouse-com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx List-Id: intel-gfx@lists.freedesktop.org Ck9uIDAyLzEwLzIwMTggMTQ6NTIsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTEwLTAyIDE0OjQ2OjEwKQo+Pgo+PiBPbiAwMi8xMC8yMDE4IDE0OjIy LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE4LTEw LTAyIDE0OjEzOjE0KQo+Pj4+Cj4+Pj4gT24gMDIvMTAvMjAxOCAxMzoyNCwgQ2hyaXMgV2lsc29u IHdyb3RlOgo+Pj4+PiBRdW90aW5nIFR2cnRrbyBVcnN1bGluICgyMDE4LTEwLTAyIDEzOjIwOjA1 KQo+Pj4+Pj4KPj4+Pj4+IE9uIDAxLzEwLzIwMTggMjA6NDQsIENocmlzIFdpbHNvbiB3cm90ZToK Pj4+Pj4+PiBUaGUgZmluYWwgY2FsbCB0byB6bGliX2RlZmxhdGUoWl9GSU5JU0gpIG1heSByZXF1 aXJlIG1vcmUgb3V0cHV0Cj4+Pj4+Pj4gc3BhY2UgdG8gYmUgYWxsb2NhdGVkIGFuZCBzbyBuZWVk cyB0byByZS1pbnZva2VkLiBGYWlsdXJlIHRvIGRvIHNvIGluCj4+Pj4+Pj4gdGhlIGN1cnJlbnQg Y29kZSBsZWFkcyB0byBpbmNvbXBsZXRlIHpsaWIgc3RyZWFtcyAoYWxiZWl0IGludGFjdCBkdWUg dG8KPj4+Pj4+PiB0aGUgdXNlIG9mIFpfU1lOQ19GTFVTSCkgcmVzdWx0aW5nIGluIHRoZSBvY2Nh c2lvbmFsIHNob3J0IG9iamVjdAo+Pj4+Pj4+IGNhcHR1cmUuCj4+Pj4+Pj4KPj4+Pj4+PiBUZXN0 Y2FzZTogaWd0L2k5MTUtZXJyb3ItY2FwdHVyZS5qcwo+Pj4+Pj4+IEZpeGVzOiAwYTk3MDE1ZDQ1 ZWUgKCJkcm0vaTkxNTogQ29tcHJlc3MgR1BVIG9iamVjdHMgaW4gZXJyb3Igc3RhdGUiKQo+Pj4+ Pj4+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVr Pgo+Pj4+Pj4+IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRl bC5jb20+Cj4+Pj4+Pj4gQ2M6IDxzdGFibGVAdmdlci5rZXJuZWwub3JnPiAjIHY0LjEwKwo+Pj4+ Pj4+IC0tLQo+Pj4+Pj4+ICAgICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3Iu YyB8IDYwICsrKysrKysrKysrKysrKysrKysrKy0tLS0tLQo+Pj4+Pj4+ICAgICAgMSBmaWxlIGNo YW5nZWQsIDQ3IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygtKQo+Pj4+Pj4+Cj4+Pj4+Pj4g ZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vycm9yLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jCj4+Pj4+Pj4gaW5kZXggM2Q1NTU0ZjE0 ZGZkLi5lZDhjMTZjYmZhYTQgMTAwNjQ0Cj4+Pj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9ncHVfZXJyb3IuYwo+Pj4+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ3B1X2Vycm9yLmMKPj4+Pj4+PiBAQCAtMjM3LDYgKzIzNyw3IEBAIHN0YXRpYyBpbnQgY29t cHJlc3NfcGFnZShzdHJ1Y3QgY29tcHJlc3MgKmMsCj4+Pj4+Pj4gICAgICAgICAgICAgICAgICAg ICAgICAgICBzdHJ1Y3QgZHJtX2k5MTVfZXJyb3Jfb2JqZWN0ICpkc3QpCj4+Pj4+Pj4gICAgICB7 Cj4+Pj4+Pj4gICAgICAgICAgc3RydWN0IHpfc3RyZWFtX3MgKnpzdHJlYW0gPSAmYy0+enN0cmVh bTsKPj4+Pj4+PiArICAgICBpbnQgZmx1c2ggPSBaX05PX0ZMVVNIOwo+Pj4+Pj4+ICAgICAgCj4+ Pj4+Pj4gICAgICAgICAgenN0cmVhbS0+bmV4dF9pbiA9IHNyYzsKPj4+Pj4+PiAgICAgICAgICBp ZiAoYy0+dG1wICYmIGk5MTVfbWVtY3B5X2Zyb21fd2MoYy0+dG1wLCBzcmMsIFBBR0VfU0laRSkp Cj4+Pj4+Pj4gQEAgLTI1Nyw4ICsyNTgsMTEgQEAgc3RhdGljIGludCBjb21wcmVzc19wYWdlKHN0 cnVjdCBjb21wcmVzcyAqYywKPj4+Pj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgenN0cmVh bS0+YXZhaWxfb3V0ID0gUEFHRV9TSVpFOwo+Pj4+Pj4+ICAgICAgICAgICAgICAgICAgfQo+Pj4+ Pj4KPj4+Pj4+IExvb2tzIGxpa2UgdGhlIGJsb2NrIGFib3ZlLCBub3Qgc2hvd24gaW4gdGhpcyBk aWZmLCBjb3VsZCB1c2UgYSBjaGVjawo+Pj4+Pj4gYW5kIGFib3J0IGlmIHRoZSBkc3QtPnBhZ2Vf Y291bnQgb3Zlcmdyb3dzIHRoZSBwZXNzaW1pc3RpYyBhbGxvY2F0aW9uIG9mCj4+Pj4+PiB0aGUg YXJyYXkuCj4+Pj4+Pgo+Pj4+Pj4+ICAgICAgCj4+Pj4+Pj4gLSAgICAgICAgICAgICBpZiAoemxp Yl9kZWZsYXRlKHpzdHJlYW0sIFpfU1lOQ19GTFVTSCkgIT0gWl9PSykKPj4+Pj4+PiArICAgICAg ICAgICAgIGlmICh6bGliX2RlZmxhdGUoenN0cmVhbSwgZmx1c2gpICE9IFpfT0spCj4+Pj4+Pgo+ Pj4+Pj4gU28gdGhpcyAobm90IGFsd2F5cyBhc2tpbmcgZm9yIGEgZmx1c2gpIGFjdHVhbGx5IG5v dCBvbmx5IGZpeGVzIHRoZQo+Pj4+Pj4gZmx1c2ggYXQgdGhlIGVuZCBidXQgaW1wcm92ZXMgdGhl IEFQSSB1c2FnZSBhbmQgcG90ZW50aWFsbHkgY29tcHJlc3Npb24KPj4+Pj4+IHJhdGlvLCBjb3Jy ZWN0Pwo+Pj4+Pgo+Pj4+PiBZZXMuCj4+Pj4+ICAgICAKPj4+Pj4+PiAgICAgICAgICAgICAgICAg ICAgICAgICAgcmV0dXJuIC1FSU87Cj4+Pj4+Pj4gKwo+Pj4+Pj4+ICsgICAgICAgICAgICAgaWYg KHpzdHJlYW0tPmF2YWlsX291dCkKPj4+Pj4+PiArICAgICAgICAgICAgICAgICAgICAgZmx1c2gg PSBaX1NZTkNfRkxVU0g7Cj4+Pj4+Pgo+Pj4+Pj4gSG0uLiBidXQgd2h5IHRoaXM/IEl0IHdpbGwg Zmx1c2ggb25seSBvY2Nhc2lvbmFsbHksIHdoZW4gb25lIGlucHV0IHBhZ2UKPj4+Pj4+IGRpZCBu b3QgZml0IGluIHRoZSBhdmFpbGFibGUgb3V0cHV0IC0gYnV0IHRoYXQgd2lsbCBkZXBlbmQgb24K Pj4+Pj4+IGNvbXByZXNzaWJpbGl0eSBzbyBJIGRvbid0IHRoaW5rIGl0IGhhcyBhIGZpeGVkIHBl cmlvZC4gSXQgaXMgbm90IGZvcgo+Pj4+Pj4gaW5zdGFuY2UgZm9yIGV2ZXJ5IDRrIG9mIGNvbXBy ZXNzZWQgb3V0cHV0LCBpZiB0aGF0IHdhcyBtYXliZSB0aGUgZ29hbC4KPj4+Pj4KPj4+Pj4gTXkg dGhpbmtpbmcgaXMgdGhhdCBpZiB0aGUgemxpYl9kZWZsYXRlKCkgd2FudHMgdG8gZGVmZXIgdG8g ZmlsbCBpdHMKPj4+Pj4gd2luZG93IChvciB3aGF0ZXZlcikgYnV0IHdlIG5lZWQgdG8gY3Jvc3Mg YSBwYWdlIGJvdW5kYXJ5LCB3ZSBoYXZlIHRvCj4+Pj4+IHB1c2ggZXZlcnl0aGluZyBmcm9tIHRo ZSBjdXJyZW50IHBhZ2UgYmVmb3JlIHdlIGNoYW5nZSB0aGUgUFRFLgo+Pj4+Cj4+Pj4gSG0gYnV0 IEkgYW0gbm90IHN1cmUgdGhpcyBpcyBhY2hpZXZpbmcgdGhhdCwgb3IgdGhhdCBpdCBpcyBuZWVk ZWQuIEkKPj4+PiByZWFkIHRoZSBkb2NzIG1hbnkgdGltZXMgYW5kIEkgYW0gbm90IHN1cmUgaG93 IGl0IGlzIHN1cHBvc2VkIHRvIHdvcmsuCj4+Pj4KPj4+PiBGaXJzdCB0aGluZyBJIGFtIG5vdCBz dXJlIG9mIGlzIHdoZXRoZXIgd2UgbmVlZCB0byBhc2sgZm9yIGFueSBmbHVzaGVzLAo+Pj4+IG9y IGl0IHdvdWxkIGJlIGVub3VnaCB0byBsb29wIHVudGlsIGF2YWlsX2luID4gMCB8fCBhdmFpbF9v dXQgPT0gMC4KPj4+PiBTaW5jZSBkb2NzIHNheSB0aGF0IGlmIGF2YWlsX291dCA9PSAwLCB6bGli X2RlZmxhdGUgbmVlZHMgdG8gYmUgY2FsbGVkCj4+Pj4gYWdhaW4gaW4gdGhlIHNhbWUgZmx1c2gg bW9kZS4KPj4+Cj4+PiBJaXJjLCBaX1NZTkNfRkxVU0ggdGFsa3MgYWJvdXQgdGVybWluYXRpbmcg dGhlIGNvbXByZXNzaW9uIGJsb2NrIGVhcmxpZXIKPj4+IGluIG9yZGVyIHRvIGNvbnN1bWUgbmV4 dF9hdmFpbCwgd2l0aG91dCB0aGUgU1lOQyByZXBlYXRpbmcgYSBjYWxsIGlzCj4+PiBhbGxvd2Vk IHRvIG5vdCBwcm9ncmVzcy4KPj4+Cj4+Pj4gQ3VycmVudCBjb2RlIGZhaWxzIHRvIGVuc3VyZSB0 aGlzLiBJdCB3b3VsZCBoYXBwZW4gb24gdGhlIG5leHQgY2FsbCB0bwo+Pj4+IGNvbXByZXNzX3Bh Z2UsIGJ1dCBhKSBJIHRoaW5rIHRoYXQgaXMgdW5jbGVhbiBhbmQgYikgZmx1c2ggbW9kZSB3aWxs IG5vdAo+Pj4+IG1hdGNoLgo+Pj4KPj4+IEZhaWxzIHRvIGVuc3VyZSB3aGF0IGV4YWN0bHk/IEkg dGhpbmsgaXQgaXMgb2JleWluZyB0aGUgcnVsZXMgb24gZmx1c2g6Cj4+Pgo+Pj4gICAgIElmIHRo ZSBwYXJhbWV0ZXIgZmx1c2ggaXMgc2V0IHRvIFpfU1lOQ19GTFVTSCwgYWxsIHBlbmRpbmcgb3V0 cHV0IGlzCj4+PiAgICAgZmx1c2hlZCB0byB0aGUgb3V0cHV0IGJ1ZmZlciBhbmQgdGhlIG91dHB1 dCBpcyBhbGlnbmVkIG9uIGEgYnl0ZSBib3VuZGFyeSwgc28KPj4+ICAgICB0aGF0IHRoZSBkZWNv bXByZXNzb3IgY2FuIGdldCBhbGwgaW5wdXQgZGF0YSBhdmFpbGFibGUgc28gZmFyLiAoSW4gcGFy dGljdWxhcgo+Pj4gICAgIGF2YWlsX2luIGlzIHplcm8gYWZ0ZXIgdGhlIGNhbGwgaWYgZW5vdWdo IG91dHB1dCBzcGFjZSBoYXMgYmVlbiBwcm92aWRlZAo+Pj4gICAgIGJlZm9yZSB0aGUgY2FsbC4p ICBGbHVzaGluZyBtYXkgZGVncmFkZSBjb21wcmVzc2lvbiBmb3Igc29tZSBjb21wcmVzc2lvbgo+ Pj4gICAgIGFsZ29yaXRobXMgYW5kIHNvIGl0IHNob3VsZCBiZSB1c2VkIG9ubHkgd2hlbiBuZWNl c3NhcnkuCj4+Cj4+IEkgYW0gbm90IHN1cmUgd2UgbmVlZCB0byBmbHVzaCAtIEkgZG9uJ3Qgc2Vl IHRoYXQgaXQgc2F5cyBpbiB0aGUgZG9jcwo+PiB0aGF0IHdlIGhhdmUgdG8uIEFGQUlVIHdoZW4g YXZhaWxfaW4gZHJvcHMgdG8gemVybyB3ZSBhcmUgYWxsb3dlZCB0bwo+PiBtb3ZlIG9uLiBBbnl0 aGluZyBvdXRzdGFuZGluZyBpbiB0aGUgY29tcHJlc3NvciB3b3VsZCBiZSB0aGVuIGZsdXNoZWQK Pj4gZWl0aGVyIG9uIHByb2Nlc3NpbmcgdGhlIG5leHQgcGFnZSwgb3Igb24gc3RyZWFtIGNsb3Nl Lgo+IAo+IFRoZSBjYXNlIHdlIHdhbnQgdG8gaGFuZGxlIGlzIGF2YWlsX2luICE9IDAuIFdlIGNh bm5vdCBtb3ZlIG9uIHVudGlsCj4gYXZhaWxfaW4gaXMgMC4KClRoYXQncyB3aGF0IEkgc2FpZCEg OikgQnV0IEkgZG9uJ3Qgc2VlIGluIHRoZSBkb2NzIHRoYXQgaXMgc2F5cyB3ZSBoYXZlIAp0byBm bHVzaCBhZnRlciBhdmFpbF9pbiBpcyB6ZXJvLCBub3Igd2hlbiBhdmFpbF9vdXQgaXMgemVyby4K Cj4gCj4+PiAgICAgLi4uCj4+Pgo+Pj4gICAgIElmIGRlZmxhdGUgcmV0dXJucyB3aXRoIGF2YWls X291dCA9PSAwLCB0aGlzIGZ1bmN0aW9uIG11c3QgYmUgY2FsbGVkIGFnYWluCj4+PiAgICAgd2l0 aCB0aGUgc2FtZSB2YWx1ZSBvZiB0aGUgZmx1c2ggcGFyYW1ldGVyIGFuZCBtb3JlIG91dHB1dCBz cGFjZSAodXBkYXRlZAo+Pj4gICAgIGF2YWlsX291dCksIHVudGlsIHRoZSBmbHVzaCBpcyBjb21w bGV0ZSAoZGVmbGF0ZSByZXR1cm5zIHdpdGggbm9uLXplcm8KPj4+ICAgICBhdmFpbF9vdXQpLgo+ Pgo+PiBZZXMsIGJ1dCB0aGUgcGF0Y2ggZG9lcyBub3QgZG8gdGhhdC4gWW91IGVuYWJsZSB0aGUg Zmx1c2ggbW9kZSB3aGVuCj4+IGF2YWlsX291dCBpcyBub24gemVybywgYnV0IHRoZW4gdHdvIG9w dGlvbnMgYXJlIHBvc3NpYmxlLiBFaXRoZXIKPj4gYXZhaWxfaW4gaXMgemVybywgaW4gd2hpY2gg Y2FzZSBub3RoaW5nIGhhcHBlbnMsIG9yIGl0IGlzIG5vdC4gSW4gdGhlCj4+IGxhdHRlciBjYXNl IHRoZXJlIGlzIGFub3RoZXIgZmx1c2hpbmcgY2FsbCB0byB6bGliX2RlZmxhdGUuIElmIGF2YWls X291dAo+PiBpcyB6ZXJvIGFmdGVyIHRoYXQgY2FsbCwgYW5kIGF2YWlsX2luIGlzIGFsc28gemVy bywgdGhlIGRvY3VtZW50YXRpb24KPj4gcGFyYWdyYXBoIGFib3ZlIHNheXMgeW91IGhhdmUgdG8g Y2FsbCB6bGliX2RlZmxhdGUgaW4gdGhlIHNhbWUgZmx1c2gKPj4gbW9kZSBhZ2Fpbi4KPiAKPiBS ZWFkIHRoZSBwYXJhZ3JhcGggYWdhaW4sIHNwZWNpZmljYWxseSB3aGVuIGF2YWlsX291dCA9PSAw IHlvdSBzaG91bGQKPiBhbGxvY2F0ZSBtb3JlIHNwYWNlIGFuZCByZXJ1biB0aGUgY29tcHJlc3Nv ci4gSWYgYXZhaWxfb3V0ICE9IDAgYW5kCj4gYXZhaWxfaW4gIT0gMCB3ZSB3YW50IHRvIFNZTkMg aW4gb3JkZXIgdG8gY29uc3VtZSB0aGUgcmVtYWluaW5nCj4gYXZhaWxfaW4uCgpTb3JyeSBJIGRv bid0IHNlZSB3aGVyZSBpdCBzYXlzIHRoYXQgeW91IGhhdmUgdG8gU1lOQ19GTFVTSCBpbiBhbnkg CmNpcmN1bXN0YW5jZSBhcGFydCBmcm9tIGluZmx1ZW5jaW5nIHRoZSBzdHJlYW0gY29tcG9zaXRp b24gZWl0aGVyIGZvciAKZXJyb3IgcmVjb3Zlcnkgb3IgaW50ZXJhY3RpdmUgYXBwbGljYXRpb25z PwoKRnVydGhlcm1vcmUsIGFzIEkgd3JvdGUgYWJvdmUsIHdoZW4geW91IHN0YXJ0IGEgZmx1c2gg aW4gdGhpcyBwYXRjaCB5b3UgCmRvbid0IGVuc3VyZSB0aGUgbmV4dCB6bGliX2RlZmxhdGUgY2Fs bCBpcyB3aXRoIHRoZSBzYW1lIGZsdXNoIG1vZGUgCihzaW5jZSBpdCBjYW4gYmUgb25seSBvbiB0 aGUgbmV4dCBjYWxsIHRvIGNvbXByZXNzX3BhZ2UpLgoKWl9PSyAmJiBhdmFpbF9vdXQgPT0gMCBp dCBzYXlzIHlvdSBoYXZlIHRvIHJ1biBpdCBhZ2Fpbiwgc28gdGhhdCB0b28gCndvdWxkIGJlIG1v cmUgaW50dWl0aXZlIGJlaW5nIGRvbmUgaW4gc2NvcGUgb2YgYSBzaW5nbGUgY29tcHJlc3NfcGFn ZSAKY2FsbC4gKEl0IGRvZXNuJ3Qgc2F5IGF2YWlsX2luID09IDAgJiYgYXZhaWxfb3V0ID09IDAg aXMgbm90IHBvc3NpYmxlLikKClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==