From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shobhit Kumar Subject: Re: [PATCH 5/7] drm/i915: Reorganize the DSI enable/disable sequence Date: Wed, 11 Dec 2013 19:43:10 +0530 Message-ID: <52A872F6.90306@intel.com> References: <1386764525-10457-1-git-send-email-shobhit.kumar@intel.com> <20131211130603.GA9804@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id CED49FACD7 for ; Wed, 11 Dec 2013 06:13:15 -0800 (PST) In-Reply-To: <20131211130603.GA9804@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Daniel Vetter Cc: jani.nikula@intel.com, vijayakumar.balakrishnan@intel.com, intel-gfx@lists.freedesktop.org, yogesh.mohan.marimuthu@intel.com List-Id: intel-gfx@lists.freedesktop.org On Wednesday 11 December 2013 06:36 PM, Daniel Vetter wrote: > On Wed, Dec 11, 2013 at 05:52:05PM +0530, Shobhit Kumar wrote: >> Basically ULPS handling during enable/disable has been moved to >> pre_enable and post_disable phases. PLL and panel power disable >> also has been moved to post_disable phase. The ULPS entry/exit >> sequneces as suggested by HW team is as follows - >> >> During enable time - >> set DEVICE_READY --> Clear DEVICE_READY --> set DEVICE_READY >> >> And during disable time to flush all FIFOs - >> set ENTER_SLEEP --> EXIT_SLEEP --> ENTER_SLEEP >> >> Also during disbale sequnece sub-encoder disable is moved to the end >> after port is disabled. >> >> v2: Based on comments from Ville >> - Detailed epxlaination in the commit messgae >> - Moved parameter changes out into another patch >> - Backlight enabling will be a new patch >> >> v3: Updated as per Jani's comments >> - Removed the I915_WRITE_BITS as it is not needed >> - Moved panel_reset and send_otp_cmds hooks to dsi_pre_enable >> - Moved disable_panel_power hook to dsi_post_disable >> - Replace hardcoding with AFE_LATCHOUT >> >> v4: Make intel_dsi_device_ready and intel_dsi_clear_device_ready static >> >> Signed-off-by: Yogesh Mohan Marimuthu >> Signed-off-by: Shobhit Kumar >> Reviewed-by: Jani Nikula > > Merged all patches from this series, thanks. btw, when resending > individual patches pls use the --in-reply-to option so that they're all > nicely grouped together with the discussion. > Thanks Daniel for merging and the tip. Regards Shobhit