From: Vandana Kannan <vandana.kannan@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 0/5] Enabling DRRS support in the kernel
Date: Wed, 18 Dec 2013 15:45:06 +0530 [thread overview]
Message-ID: <52B175AA.4050105@intel.com> (raw)
In-Reply-To: <20131218092400.GF26371@phenom.ffwll.local>
On Dec-18-2013 2:54 PM, Daniel Vetter wrote:
> On Tue, Dec 17, 2013 at 10:58:22AM +0530, Vandana Kannan wrote:
>> Dynamic Refresh Rate Switching (DRRS) is a power conservation feature which
>> enables switching between low and high refresh rates based on the usage
>> scenario. This feature is applicable for internal eDP panel. Indication that
>> the panel can support DRRS is given by the panel EDID, which would list
>> multiple refresh rates for one resolution.
>> The patch series supports idleness detection in display i915 driver and switch
>> to low refresh rate.
>
> Just one overall comment on process:
>
> When resending patches _always_ mention what you've changed compared to
> the last version. Specifically call out which review comments you've
> incorporated and even more important which one's you've decided to
> implement differently or rejected.
>
> The preferred form for that is with a per-patch changelog in the commit
> message. Also mentioned the reviewer's name if the change is due to
> review.
>
> For bigger reworks that affect the entire patch series please also mention
> them in the cover letter.
>
> I'll update our internal BKMs with this information.
>
> Thanks, Daniel
Thanks Daniel.
I will incorporate these comments while resending the patches.
- Vandana
>>
>> Pradeep Bhat (3):
>> [Intel-gfx] drm/i915: Adding VBT fields to support eDP DRRS feature
>> [Intel-gfx] drm/i915: Parse EDID probed modes for DRRS support
>> [Intel-gfx] drm/i915: Add support for DRRS to switch RR
>>
>> Vandana Kannan (2):
>> [Intel-gfx] drm/i915: Idleness detection for DRRS
>> [Intel-gfx] drm/i915/bdw: Add support for DRRS to switch RR
>>
>> drivers/gpu/drm/i915/i915_drv.h | 30 ++++++
>> drivers/gpu/drm/i915/i915_reg.h | 1 +
>> drivers/gpu/drm/i915/intel_bios.c | 23 +++++
>> drivers/gpu/drm/i915/intel_bios.h | 29 ++++++
>> drivers/gpu/drm/i915/intel_display.c | 13 +++
>> drivers/gpu/drm/i915/intel_dp.c | 180 ++++++++++++++++++++++++++++++++++
>> drivers/gpu/drm/i915/intel_drv.h | 35 ++++++-
>> drivers/gpu/drm/i915/intel_pm.c | 112 +++++++++++++++++++++
>> drivers/gpu/drm/i915/intel_sprite.c | 3 +
>> 9 files changed, 425 insertions(+), 1 deletion(-)
>>
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
prev parent reply other threads:[~2013-12-18 10:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 5:28 [PATCH 0/5] Enabling DRRS support in the kernel Vandana Kannan
2013-12-17 5:28 ` [PATCH 1/5] drm/i915: Adding VBT fields to support eDP DRRS feature Vandana Kannan
2013-12-17 12:26 ` Chris Wilson
2013-12-18 8:08 ` Vandana Kannan
2013-12-18 9:11 ` Chris Wilson
2013-12-18 10:13 ` Vandana Kannan
2013-12-17 5:28 ` [PATCH 2/5] drm/i915: Parse EDID probed modes for DRRS support Vandana Kannan
2013-12-17 12:28 ` Chris Wilson
2013-12-18 8:11 ` Vandana Kannan
2013-12-18 9:06 ` Chris Wilson
2013-12-18 10:12 ` Vandana Kannan
2013-12-19 11:51 ` Jani Nikula
2013-12-20 5:21 ` Vandana Kannan
2013-12-17 5:28 ` [PATCH 3/5] drm/i915: Add support for DRRS to switch RR Vandana Kannan
2013-12-17 5:28 ` [PATCH 4/5] drm/i915: Idleness detection for DRRS Vandana Kannan
2013-12-17 12:29 ` Chris Wilson
2013-12-18 8:18 ` Vandana Kannan
2013-12-18 9:04 ` Chris Wilson
2013-12-18 10:09 ` Vandana Kannan
2013-12-17 5:28 ` [PATCH 5/5] drm/i915/bdw: Add support for DRRS to switch RR Vandana Kannan
2013-12-17 12:30 ` Chris Wilson
2013-12-18 8:24 ` Vandana Kannan
2013-12-18 9:01 ` Chris Wilson
2013-12-18 10:06 ` Vandana Kannan
2013-12-18 9:24 ` [PATCH 0/5] Enabling DRRS support in the kernel Daniel Vetter
2013-12-18 10:15 ` Vandana Kannan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B175AA.4050105@intel.com \
--to=vandana.kannan@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox