public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Todd Previte <tprevite@gmail.com>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Enable 5.4Ghz (HBR2) link rate for Displayport 1.2-capable devices
Date: Fri, 17 Jan 2014 08:00:08 -0700	[thread overview]
Message-ID: <52D94578.5070200@gmail.com> (raw)
In-Reply-To: <20140117115521.GA20479@strange.amr.corp.intel.com>

On 1/17/2014 4:55 AM, Damien Lespiau wrote:
> On Thu, Jan 16, 2014 at 08:06:08PM -0700, Todd Previte wrote:
>> For HSW+ platforms, enable the 5.4Ghz (HBR2) link rate for devices that support it. The
>> sink device must report that is supports Displayport 1.2 and the HBR2 bit rate in the
>> DPCD in order to use HBR2.
>> ---
>>   drivers/gpu/drm/i915/intel_dp.c | 21 +++++++++++++++------
>>   1 file changed, 15 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> index 7df5085..f92d1c0 100644
>> --- a/drivers/gpu/drm/i915/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>> @@ -102,7 +102,10 @@ intel_dp_max_link_bw(struct intel_dp *intel_dp)
>>   	case DP_LINK_BW_2_7:
>>   		break;
>>   	case DP_LINK_BW_5_4: /* 1.2 capable displays may advertise higher bw */
>> -		max_link_bw = DP_LINK_BW_2_7;
>> +        if (intel_dp->dpcd[DP_DPCD_REV] == 0x12)
>> +            max_link_bw = DP_LINK_BW_5_4;
>> +        else
>> +            max_link_bw = DP_LINK_BW_2_7;
>>   		break;
> I see spaces instead of tabs. You can use the useful checkpatch.pl
> script on patches to catch those pesky style issues (from within a linux
> tree):
>
> $ ./scripts/checkpatch.pl 0001-drm-i915-Enable-5.4Ghz-HBR2-link-rate-for-Displaypor.patch
>
> [...]
>
> total: 6 errors, 9 warnings, 55 lines checked
>
Gah. That's what happens when I make changes with different editors. 
I'll fix those in the next revision.

-T

  parent reply	other threads:[~2014-01-17 15:00 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-17  3:06 [PATCH] drm/i915: Enable 5.4Ghz (HBR2) link rate for Displayport 1.2-capable devices Todd Previte
2014-01-17  6:30 ` Daniel Vetter
2014-01-17 14:58   ` Todd Previte
2014-01-17 15:08     ` Damien Lespiau
2014-01-17 15:22       ` Todd Previte
2014-01-17 11:55 ` Damien Lespiau
2014-01-17 13:32   ` Jani Nikula
2014-01-17 15:22     ` Todd Previte
2014-01-17 15:00   ` Todd Previte [this message]
2014-01-17 16:58 ` [PATCH V2] " Todd Previte
2014-01-17 16:58   ` [PATCH] " Todd Previte
2014-01-17 17:34     ` Daniel Vetter
2014-01-20 17:19 ` [PATCH v3] " Todd Previte
2014-01-20 17:19   ` Todd Previte
2014-01-21  9:26     ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52D94578.5070200@gmail.com \
    --to=tprevite@gmail.com \
    --cc=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox