From mboxrd@z Thu Jan 1 00:00:00 1970 From: Todd Previte Subject: Re: [PATCH] drm/i915: Enable 5.4Ghz (HBR2) link rate for Displayport 1.2-capable devices Date: Fri, 17 Jan 2014 08:00:08 -0700 Message-ID: <52D94578.5070200@gmail.com> References: <1389927968-2473-1-git-send-email-tprevite@gmail.com> <20140117115521.GA20479@strange.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pa0-f48.google.com (mail-pa0-f48.google.com [209.85.220.48]) by gabe.freedesktop.org (Postfix) with ESMTP id DBE8BFCBF2 for ; Fri, 17 Jan 2014 07:00:09 -0800 (PST) Received: by mail-pa0-f48.google.com with SMTP id kx10so2654985pab.21 for ; Fri, 17 Jan 2014 07:00:09 -0800 (PST) In-Reply-To: <20140117115521.GA20479@strange.amr.corp.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Damien Lespiau Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 1/17/2014 4:55 AM, Damien Lespiau wrote: > On Thu, Jan 16, 2014 at 08:06:08PM -0700, Todd Previte wrote: >> For HSW+ platforms, enable the 5.4Ghz (HBR2) link rate for devices that support it. The >> sink device must report that is supports Displayport 1.2 and the HBR2 bit rate in the >> DPCD in order to use HBR2. >> --- >> drivers/gpu/drm/i915/intel_dp.c | 21 +++++++++++++++------ >> 1 file changed, 15 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c >> index 7df5085..f92d1c0 100644 >> --- a/drivers/gpu/drm/i915/intel_dp.c >> +++ b/drivers/gpu/drm/i915/intel_dp.c >> @@ -102,7 +102,10 @@ intel_dp_max_link_bw(struct intel_dp *intel_dp) >> case DP_LINK_BW_2_7: >> break; >> case DP_LINK_BW_5_4: /* 1.2 capable displays may advertise higher bw */ >> - max_link_bw = DP_LINK_BW_2_7; >> + if (intel_dp->dpcd[DP_DPCD_REV] == 0x12) >> + max_link_bw = DP_LINK_BW_5_4; >> + else >> + max_link_bw = DP_LINK_BW_2_7; >> break; > I see spaces instead of tabs. You can use the useful checkpatch.pl > script on patches to catch those pesky style issues (from within a linux > tree): > > $ ./scripts/checkpatch.pl 0001-drm-i915-Enable-5.4Ghz-HBR2-link-rate-for-Displaypor.patch > > [...] > > total: 6 errors, 9 warnings, 55 lines checked > Gah. That's what happens when I make changes with different editors. I'll fix those in the next revision. -T