From mboxrd@z Thu Jan  1 00:00:00 1970
From: Todd Previte <tprevite@gmail.com>
Subject: Re: [PATCH] drm/i915: Enable 5.4Ghz (HBR2) link rate
 for Displayport 1.2-capable devices
Date: Fri, 17 Jan 2014 08:22:08 -0700
Message-ID: <52D94AA0.5000505@gmail.com>
References: <1389927968-2473-1-git-send-email-tprevite@gmail.com>
	<20140117115521.GA20479@strange.amr.corp.intel.com>
	<878uuebuo7.fsf@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-pd0-f181.google.com (mail-pd0-f181.google.com
	[209.85.192.181])
	by gabe.freedesktop.org (Postfix) with ESMTP id 70E26105DE1
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 17 Jan 2014 07:22:10 -0800 (PST)
Received: by mail-pd0-f181.google.com with SMTP id y10so564673pdj.40
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 17 Jan 2014 07:22:10 -0800 (PST)
In-Reply-To: <878uuebuo7.fsf@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: Jani Nikula <jani.nikula@linux.intel.com>, Damien Lespiau <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 1/17/2014 6:32 AM, Jani Nikula wrote:
> On Fri, 17 Jan 2014, Damien Lespiau <damien.lespiau@intel.com> wrote:
>> I see spaces instead of tabs. You can use the useful checkpatch.pl
>> script on patches to catch those pesky style issues (from within a linux
>> tree):
>>
>> $ ./scripts/checkpatch.pl 0001-drm-i915-Enable-5.4Ghz-HBR2-link-rate-for-Displaypor.patch
>>
>> [...]
>>
>> total: 6 errors, 9 warnings, 55 lines checked
> Should anyone find this useful, I have these to check branches in my
> local repos directly:
>
> alias checkpatch='/path/to/checkpatch.pl -q --emacs --strict'
>
> checkbranch()
> {
>      local commit
>      local range
>
>      if [ -z "$1" ]; then
> 	range="origin..HEAD"
>      elif [ -n "`echo $1 | grep '\.\.'`" ]; then
> 	range="$1"
>      else
> 	range="$1..HEAD"
>      fi
>
>      for commit in `git rev-list --reverse $range`; do
> 	git --no-pager log --oneline -1 $commit
> 	git format-patch --stdout -1 $commit | checkpatch -
>      done
> }
>
> Then I can do:
>
> Check local patches against origin:
> $ checkbranch
>
> Check local patches against drm-intel/drm-intel-nightly:
> $ checkbranch drm-intel/drm-intel-nightly
>
> Check a revision range:
> $ checkbranch commit1..commit2
>
> Do note that checkpatch is not the law. But it helps you get some of the
> little things straight.
>
>
> HTH,
> Jani.
>
>
>
Cool thanks Jani. I'll give that a try.

-T