From: "S, Deepak" <deepak.s@intel.com>
To: "Jesse Barnes" <jbarnes@virtuousgeek.org>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 3/3] drm/i915/vlv: WA for Turbo and RC6 to work together.
Date: Wed, 22 Jan 2014 22:07:53 +0530 [thread overview]
Message-ID: <52DFF3E1.2060308@intel.com> (raw)
In-Reply-To: <20140122083415.77a713e7@jbarnes-desktop>
On 1/22/2014 10:04 PM, Jesse Barnes wrote:
> On Tue, 21 Jan 2014 17:18:59 +0200
> Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>
>> On Mon, Jan 20, 2014 at 06:40:26PM +0530, deepak.s@intel.com wrote:
>>> From: Deepak S <deepak.s@intel.com>
>>>
>>> With RC6 enabled, BYT has an HW issue in determining the right
>>> Gfx busyness.
>>> WA for Turbo + RC6: Use SW based Gfx busy-ness detection to decide
>>> on increasing/decreasing the freq. This logic will monitor C0
>>> counters of render/media power-wells over EI period and takes
>>> necessary action based on these values
>>
>> Do we have any idea what kind of performance impact this should
>> have?
>
> So aside from the code review comments, it sounds like there are two
> high level issues:
> 1) keeping existing boost code from Chris (as mentioned by Ville)
> 2) power measurements vs current upstream
>
> Given that upstream is a bit different than when this code was forked
> off, it could be that we don't need this. Can you sanity check things
> by getting some power measurements with and without this patch? It
> looks like 1/3 and 2/3 will be required in any case though.
>
> Assuming 3/3 does show a benefit, the other question is whether keeping
> the current turbo boost code makes sense, so you'd have to port those
> changes from the gen6_pm_rps_work() from Chris and measure again...
>
> Thanks,
>
Sure Jesse, I will do power measurement and get back to you on the results.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2014-01-22 16:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-20 13:10 [PATCH v4 0/3] VLV Turbo/rps + RC6 workaround deepak.s
2014-01-20 13:10 ` [PATCH v4 1/3] drm/i915: Disable/Enable PM Intrrupts based on the current freq deepak.s
2014-01-21 14:34 ` Ville Syrjälä
2014-01-21 15:11 ` S, Deepak
2014-01-20 13:10 ` [PATCH v3 2/3] drm/i915/vlv: WA to fix Voltage not getting dropped to Vmin when Gfx is power gated deepak.s
2014-01-21 14:43 ` Ville Syrjälä
2014-01-21 15:29 ` S, Deepak
2014-01-20 13:10 ` [PATCH v2 3/3] drm/i915/vlv: WA for Turbo and RC6 to work together deepak.s
2014-01-21 15:18 ` Ville Syrjälä
2014-01-22 11:30 ` S, Deepak
2014-01-22 16:34 ` Jesse Barnes
2014-01-22 16:37 ` S, Deepak [this message]
2014-01-22 16:59 ` Jesse Barnes
2014-01-22 18:32 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52DFF3E1.2060308@intel.com \
--to=deepak.s@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox