From: "Antti Koskipää" <antti.koskipaa@linux.intel.com>
To: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: Clean up display pipe register accesses
Date: Fri, 24 Jan 2014 14:13:11 +0200 [thread overview]
Message-ID: <52E258D7.8090203@linux.intel.com> (raw)
In-Reply-To: <4B498744C37F034EA16F6FBC6AB9FAD201449056@IRSMSX103.ger.corp.intel.com>
On 01/22/14 08:50, Barbalho, Rafael wrote:
> BCLRPAT is in the transcoder, not the pipe.
> PIPERSRC is in the transcoder not in the pipe.
> PIPECONF is in the pipe not the transcoder.
> Missing from that patch is also all the DSP* registers (DSPCNTR,DSPADDR, etc...) those should use the new _PIPE2 macro.
Yes, you are correct. Seems that some of the original macros were wrong.
V2 coming up.
--
- Antti
next prev parent reply other threads:[~2014-01-24 12:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 12:25 [PATCH] drm/i915: Clean up display pipe register accesses Antti Koskipaa
2014-01-22 6:50 ` Barbalho, Rafael
2014-01-24 12:13 ` Antti Koskipää [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-01-27 11:17 Antti Koskipaa
2014-01-27 11:20 ` Antti Koskipää
2014-01-27 11:21 ` Chris Wilson
2014-01-27 12:51 ` Antti Koskipää
2014-01-27 12:54 ` Chris Wilson
2014-01-27 11:22 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E258D7.8090203@linux.intel.com \
--to=antti.koskipaa@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox