From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Antti_Koskip=E4=E4?=
 <antti.koskipaa@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Clean up display pipe register
 accesses
Date: Fri, 24 Jan 2014 14:13:11 +0200
Message-ID: <52E258D7.8090203@linux.intel.com>
References: <1389788754-2710-1-git-send-email-antti.koskipaa@linux.intel.com>
	<4B498744C37F034EA16F6FBC6AB9FAD201449056@IRSMSX103.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
	by gabe.freedesktop.org (Postfix) with ESMTP id 98B4AFB728
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 24 Jan 2014 04:11:32 -0800 (PST)
In-Reply-To: <4B498744C37F034EA16F6FBC6AB9FAD201449056@IRSMSX103.ger.corp.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On 01/22/14 08:50, Barbalho, Rafael wrote:

> BCLRPAT is in the transcoder, not the pipe.

> PIPERSRC is in the transcoder not in the pipe.

> PIPECONF is in the pipe not the transcoder.

> Missing from that patch is also all the DSP* registers (DSPCNTR,DSPADDR, etc...) those should use the new _PIPE2 macro.

Yes, you are correct. Seems that some of the original macros were wrong.
V2 coming up.

-- 
- Antti