From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH 1/5] drm/i915: Place the Global GTT VM first in the list of VM Date: Sat, 25 Jan 2014 00:32:33 -0800 Message-ID: <52E376A1.8000803@whitecape.org> References: <1390616265-4329-1-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0349485174==" Return-path: Received: from homiemail-a60.g.dreamhost.com (caiajhbdcagg.dreamhost.com [208.97.132.66]) by gabe.freedesktop.org (Postfix) with ESMTP id 95600FA19F for ; Sat, 25 Jan 2014 00:29:31 -0800 (PST) In-Reply-To: <1390616265-4329-1-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Ben Widawsky , Intel GFX List-Id: intel-gfx@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============0349485174== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ssaHnBb0x6DiWmVg9F47juWCgMkWcqsvD" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ssaHnBb0x6DiWmVg9F47juWCgMkWcqsvD Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 01/24/2014 06:17 PM, Ben Widawsky wrote: > From: Chris Wilson >=20 > This is useful for debugging as we then know that the first entry is > always the global GTT, and all later entries the per-process GTT VM. >=20 > Signed-off-by: Chris Wilson > Reviewed-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_gem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i91= 5_gem.c > index 024e454..946a577 100644 > --- a/drivers/gpu/drm/i915/i915_gem.c > +++ b/drivers/gpu/drm/i915/i915_gem.c > @@ -4634,7 +4634,7 @@ void i915_init_vm(struct drm_i915_private *dev_pr= iv, > INIT_LIST_HEAD(&vm->active_list); > INIT_LIST_HEAD(&vm->inactive_list); > INIT_LIST_HEAD(&vm->global_link); > - list_add(&vm->global_link, &dev_priv->vm_list); > + list_add_tail(&vm->global_link, &dev_priv->vm_list); > } > =20 > void These five patches are: Tested-by: Kenneth Graunke On Broadwell with drm-intel-nightly, I don't get the batchbuffer as part of my error state, which is a regression. With these patches, it's back again. Thanks for investigating this, Ben. --ssaHnBb0x6DiWmVg9F47juWCgMkWcqsvD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJS43alAAoJEFtb2gcdScw48e0P/37hvuAjGIIOTU821UHirauY yrnge+YjHW0EEk/IBqnMCG9Keh/D2NQBwmNIRrBZ0/t5ebw3isVN8SngNuyCtkZm edg611o8Qt2A2e32RCavkVyYYN6rr822+Y+X0K5vH2TqdK8oGAHXT3J7nzVFDgyH CnWMdlLE4Ava+IUOIJfe6EXpH+9c/t+SrX4DBsZv57u6fvhdJ3Z+2LUOuMshFUSP Mlv6iqJW7m33M7zJ9HzG4rNvJY5YUCUz/LM3v1dZ/fzQYnBIC9jIC1GVi9Xnljch zVcMvJyKgzgAoQF98SKBWHU7OYs5LBegptqvSVgOnxe/I4xcVtAY3v+psxgCneF3 JPEal7ikqUa5tBqOASU8dXkSKnSQyYql6/w1vOOs3U6ubeTzaUce/S+OIF7A3eju pFq4ewiK00Z/DLo6/ykF3FCxbSsLUSSIN5A87oX9fZaJUlD/dCrRdqJ8b3InDEyw N5tzqqMM15SoFRhabIwmcVv1mZzkJ9/BdISZ5wRNwKSwwynO9g12TBqPNPXiZgCG gFUYpzLQSYwwOPcx5JhbPNDxCIa+ToCxqqKs+F4kRIW2loKYocBot8HSr//e5kCm xyrdvbun+zRDhrHOLJWcZl4Fao4gsFX6X5Fj5wyD7WiI1Kb0d75kZcaP7kYMLNEe gvH38ApHs28lkUzbadmZ =etkD -----END PGP SIGNATURE----- --ssaHnBb0x6DiWmVg9F47juWCgMkWcqsvD-- --===============0349485174== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============0349485174==--