From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH 1/5] drm/i915: Place the Global GTT VM first in the list of VM Date: Sat, 25 Jan 2014 13:31:29 -0800 Message-ID: <52E42D31.6050604@whitecape.org> References: <1390616265-4329-1-git-send-email-benjamin.widawsky@intel.com> <52E376A1.8000803@whitecape.org> <20140125204805.GP9772@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1869740998==" Return-path: Received: from homiemail-a1.g.dreamhost.com (caiajhbdccah.dreamhost.com [208.97.132.207]) by gabe.freedesktop.org (Postfix) with ESMTP id 20BA2FA23E for ; Sat, 25 Jan 2014 13:28:33 -0800 (PST) In-Reply-To: <20140125204805.GP9772@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Daniel Vetter Cc: Intel GFX , Ben Widawsky List-Id: intel-gfx@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1869740998== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="R5qgT8ONCSGIKBdcDosj1dOiAxOAiFsCx" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --R5qgT8ONCSGIKBdcDosj1dOiAxOAiFsCx Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 01/25/2014 12:48 PM, Daniel Vetter wrote: > On Sat, Jan 25, 2014 at 12:32:33AM -0800, Kenneth Graunke wrote: >> On 01/24/2014 06:17 PM, Ben Widawsky wrote: >>> From: Chris Wilson >>> >>> This is useful for debugging as we then know that the first entry is >>> always the global GTT, and all later entries the per-process GTT VM. >>> >>> Signed-off-by: Chris Wilson >>> Reviewed-by: Ben Widawsky >>> --- >>> drivers/gpu/drm/i915/i915_gem.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i= 915_gem.c >>> index 024e454..946a577 100644 >>> --- a/drivers/gpu/drm/i915/i915_gem.c >>> +++ b/drivers/gpu/drm/i915/i915_gem.c >>> @@ -4634,7 +4634,7 @@ void i915_init_vm(struct drm_i915_private *dev_= priv, >>> INIT_LIST_HEAD(&vm->active_list); >>> INIT_LIST_HEAD(&vm->inactive_list); >>> INIT_LIST_HEAD(&vm->global_link); >>> - list_add(&vm->global_link, &dev_priv->vm_list); >>> + list_add_tail(&vm->global_link, &dev_priv->vm_list); >>> } >>> =20 >>> void >> >> These five patches are: >> Tested-by: Kenneth Graunke >> >> On Broadwell with drm-intel-nightly, I don't get the batchbuffer as pa= rt >> of my error state, which is a regression. With these patches, it's ba= ck >> again. >> >> Thanks for investigating this, Ben. >=20 > I want to merge Mika's fixes for the reset stats ioctls, mostly since h= is > patches are older and we also have neat testcases for them all. Then we= > can reconsider the issue here and how to best get at the right batch > buffers. If it breaks development just boot with ppgtt=3D1 for now, for= > userspace nothing really changes compared to full ppgtt. > -Daniel >=20 Do you mean i915.i915_enable_ppgtt=3D1? I still get no batchbuffer in th= e error state either with or without that. But for now, Ben gave me a branch that fixes the issue, so I'll just keep using that until you get this sorted in next/nightly. --Ken --R5qgT8ONCSGIKBdcDosj1dOiAxOAiFsCx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJS5C04AAoJEFtb2gcdScw4Jl4P/3VQqRGVnd2c0EmKDDZIQkoa U7uIuR2oZ+5OukqJRRdj7YZ+5S8aQfrC5mEiGJMKEqzUYUY/8VGddgUWv88bf/lL DOupUzAOIPh+4Gtl16yZE+O+qCWd6K/4c6E0FUCVI2U+G1UPov43arExfvh34c7n KBWtFgYhXqH5tH6tblNTQA36fsmC527tu5Crr4vA6oLBP2nELJiN/gByNYgY+B2W mRCIBjzxKa2opw6x+/kSqhE4If8S9gC6wVATYAB+hlrhY1w1dP3d7UcL/ujAsKX2 59HKmPz++OTts4N77vKcFLm3LiOPaQnFNp4/AlK/ajZ/piVemj9qnsStgl4XB42T QmYiKk+Dgomq+R8PKqEoydl0UN1sMxIm0xLNyWY0aPrmttKgmzCH1QvgKrN1WVby 7X9f0B5AL7Tr1MAQdPs3BfilTlGi5PcHHzW5kqkLlAK+qWkaRWPcEdQA8UoNfzfn EA8o0sUdjzJRXGoikwfxJmSn77aJAtOmnKDL1Q/iORqtkHD6TbWPapdgc+HC6buU 7/q43V6w0KnsHLqgRMMUQCFW4ne0B+nPndlH0bWUJicIqRaBTyUhubLhpJLdPY1h LS3bbzT7Yq0nXp1IKWDv5Fbo6nHAxDXQQhFI7F9Tv8SodyOE/n78MwFsqe5rOlrO qUDHYYpbQjpnOg0nNznH =1CDM -----END PGP SIGNATURE----- --R5qgT8ONCSGIKBdcDosj1dOiAxOAiFsCx-- --===============1869740998== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1869740998==--