From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?ISO-8859-1?Q?Antti_Koskip=E4=E4?=
 <antti.koskipaa@linux.intel.com>
Subject: Re: [PATCH v2] drm/i915: Clean up display pipe register
 accesses
Date: Mon, 27 Jan 2014 13:17:09 +0200
Message-ID: <52E64035.4090302@linux.intel.com>
References: <1390565594-9890-1-git-send-email-antti.koskipaa@linux.intel.com>
	<20140124125236.GD9454@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id 5A6C2FACE5
	for <intel-gfx@lists.freedesktop.org>;
	Mon, 27 Jan 2014 03:15:13 -0800 (PST)
In-Reply-To: <20140124125236.GD9454@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces@lists.freedesktop.org
Errors-To: intel-gfx-bounces@lists.freedesktop.org
To: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On 01/24/14 14:52, Ville Syrj=E4l=E4 wrote:
> On Fri, Jan 24, 2014 at 02:13:14PM +0200, Antti Koskipaa wrote:
>> +#define PIPE_A_OFFSET	0x70000
>> +#define PIPE_B_OFFSET	0x71000
>> +#define PIPE_C_OFFSET	0x72000
> =

> I'd like a comment here to explain what PIPE_EDP_OFFSET
> actually means. Eg.:
> =

> /*
>  * There's actually no pipe EDP. Some pipe registers have
>  * simply shifted from the pipe to the transcoder, while
>  * keeping their original offset. Thus we need PIPE_EDP_OFFSET
>  * to access such registers in transcoder EDP.
>  */

Ok.

>>  #define TRANS_DDI_FUNC_CTL_B		0x61400
>>  #define TRANS_DDI_FUNC_CTL_C		0x62400
>>  #define TRANS_DDI_FUNC_CTL_EDP		0x6F400
>> -#define TRANS_DDI_FUNC_CTL(tran) _TRANSCODER(tran, TRANS_DDI_FUNC_CTL_A=
, \
>> -						   TRANS_DDI_FUNC_CTL_B)
>> +#define TRANS_DDI_FUNC_CTL(tran) (dev_priv->info->trans_ddi_func_offset=
s[tran])
>> +
> =

> Why is there a separate offset for these? They're all within the
> normal transcoder range, aren't they?

Yes, they are. Will use _TRANSCODER2 for those too.

>>  #define  TRANS_DDI_FUNC_ENABLE		(1<<31)
>>  /* Those bits are ignored by pipe EDP since it can only connect to DDI =
A */
>>  #define  TRANS_DDI_PORT_MASK		(7<<28)
>> @@ -5343,10 +5362,12 @@
>>  #define  TRANS_CLK_SEL_DISABLED		(0x0<<29)
>>  #define  TRANS_CLK_SEL_PORT(x)		((x+1)<<29)
>>  =

>> -#define _TRANSA_MSA_MISC		0x60410
>> -#define _TRANSB_MSA_MISC		0x61410
>> -#define TRANS_MSA_MISC(tran) _TRANSCODER(tran, _TRANSA_MSA_MISC, \
>> -					       _TRANSB_MSA_MISC)
>> +#define TRANSA_MSA_MISC			0x60410
>> +#define TRANSB_MSA_MISC			0x61410
>> +#define TRANSC_MSA_MISC			0x62410
>> +#define TRANS_EDP_MSA_MISC		0x6f410
>> +#define TRANS_MSA_MISC(tran) (dev_priv->info->trans_msa_misc_offsets[tr=
an])
> =

> ditto

Ditto.

-- =

- Antti