From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-1?Q?Antti_Koskip=E4=E4?= Subject: Re: [PATCH] drm/i915: Clean up display pipe register accesses Date: Mon, 27 Jan 2014 14:51:53 +0200 Message-ID: <52E65669.7070105@linux.intel.com> References: <1390821445-2784-1-git-send-email-antti.koskipaa@linux.intel.com> <20140127112139.GA2508@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id D2CF7FB301 for ; Mon, 27 Jan 2014 04:49:58 -0800 (PST) In-Reply-To: <20140127112139.GA2508@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 01/27/14 13:21, Chris Wilson wrote: > On Mon, Jan 27, 2014 at 01:17:25PM +0200, Antti Koskipaa wrote: >> RFCv2: Reorganize array indexing so that full offsets can be used as >> is. It makes grepping for registers in i915_reg.h much easier. Also >> move offset arrays to intel_device_info. >> >> PATCHv1: Fixed offsets for VLV >> >> Upcoming hardware will not have the various display pipe register >> ranges evenly spaced in memory. Change register address calculations >> into array lookups. >> >> Tested on SandyBridge and Valleyview > > Please also report changes in object size. If we have people complaining > that i915.ko is too big, it helps to point why. > -Chris Do you want this to be reported in the commit message, or where? bloat-o-meter says: add/remove: 0/0 grow/shrink: 88/10 up/down: 3326/-518 (2808) -- - Antti