From mboxrd@z Thu Jan 1 00:00:00 1970 From: "S, Deepak" Subject: Re: [PATCH v5 1/2] drm/i915: Disable/Enable PM Intrrupts based on the current freq. Date: Thu, 30 Jan 2014 12:33:21 +0530 Message-ID: <52E9F939.1020404@intel.com> References: <1390838706-10934-1-git-send-email-deepak.s@intel.com> <1390838706-10934-2-git-send-email-deepak.s@intel.com> <20140129155923.GF9454@intel.com> <20140129193031.GM7444@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga03.intel.com (mga03.intel.com [143.182.124.21]) by gabe.freedesktop.org (Postfix) with ESMTP id 2455B88810 for ; Wed, 29 Jan 2014 23:03:25 -0800 (PST) In-Reply-To: <20140129193031.GM7444@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: Daniel Vetter , =?ISO-8859-1?Q?Ville_Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On 1/30/2014 1:00 AM, Daniel Vetter wrote: > On Wed, Jan 29, 2014 at 05:59:23PM +0200, Ville Syrj=E4l=E4 wrote: >> On Mon, Jan 27, 2014 at 09:35:05PM +0530, deepak.s@intel.com wrote: >>> From: Deepak S >>> >>> When current delay is already at max delay, Let's disable the PM UP >>> THRESHOLD INTRRUPTS, so that we will not get further interrupts until >>> current delay is less than max delay, Also request for the PM DOWN >>> THRESHOLD INTRRUPTS to indicate the decrease in clock freq. and >>> viceversa for PM DOWN THRESHOLD INTRRUPTS. >>> >>> v2: Use bool variables (Daniel) >>> >>> v3: Fix Interrupt masking bit (Deepak) >>> >>> v4: Use existing symbolic constants in i915_reg.h (Daniel) >>> >>> v5: Add pm interrupt mask after new_delay calculation (Ville) >>> >>> Signed-off-by: Deepak S >>> --- >>> drivers/gpu/drm/i915/i915_drv.h | 3 +++ >>> drivers/gpu/drm/i915/i915_irq.c | 39 ++++++++++++++++++++++++++++++++= +++++++ >>> drivers/gpu/drm/i915/intel_pm.c | 3 +++ >>> 3 files changed, 45 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i91= 5_drv.h >>> index 56c720b..f19de66 100644 >>> --- a/drivers/gpu/drm/i915/i915_drv.h >>> +++ b/drivers/gpu/drm/i915/i915_drv.h >>> @@ -943,6 +943,9 @@ struct intel_gen6_power_mgmt { >>> u8 rp0_delay; >>> u8 hw_max; >>> >>> + bool rp_up_masked; >>> + bool rp_down_masked; >>> + >>> int last_adj; >>> enum { LOW_POWER, BETWEEN, HIGH_POWER } power; >>> >>> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i91= 5_irq.c >>> index 01a8686..69a5214 100644 >>> --- a/drivers/gpu/drm/i915/i915_irq.c >>> +++ b/drivers/gpu/drm/i915/i915_irq.c >>> @@ -972,6 +972,43 @@ static void notify_ring(struct drm_device *dev, >>> i915_queue_hangcheck(dev); >>> } >>> >>> +static void gen6_set_pm_mask(struct drm_i915_private *dev_priv, >>> + u32 pm_iir, int *new_delay) >> >> Just a minor nit here. We don't modify new_delay in this function, so >> passing by value would be better. > > I've fixed this up and merged the patch. I've also polished the whitespace > a bit, please run patches through scripts/checkpatch.pl before submitting. > I usually don't all go whitespace-nazi about this, but generally the > suggestions result in more uniform and hence readable sources. > >> Otherwise the patch looks good to me. So if you change that, you can >> add: >> Reviewed-by: Ville Syrj=E4l=E4 > > Thanks, Daniel Thanks Daniel.