Re: [PATCH] tests/gem_userptr_benchmark: Benchmarking userptr surfaces and impact

Tvrtko Ursulin
2014-02-06T10:21:01Z

On 02/05/2014 05:51 PM, Daniel Vetter wrote:
> On Wed, Feb 05, 2014 at 05:33:06PM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> This adds a small benchmark for the new userptr functionality.
>>
>> Apart from basic surface creation and destruction, also tested is the
>> impact of having userptr surfaces in the process address space. Reason
>> for that is the impact of MMU notifiers on common address space
>> operations like munmap() which is per process.
>>
>> v2:
>> * Moved to benchmarks.
>
> I'd just keep it as an igt testcase, beating on the kernel a bit can't
> hurt. And we have piles of other benchmark-like testcase already around.

Are you sure? Ben suggested to move it there and I actually agree it
makes more sense since it is mostly testing indirect effects on
(seemingly) unrelated operations. Not to mention benchmark directory
already exists and it is rather empty compared to tests...

Tvrtko