From mboxrd@z Thu Jan 1 00:00:00 1970 From: "S, Deepak" Subject: Re: [PATCH 2/9] drm/i915: Stop pretending VLV has rc6+ Date: Fri, 07 Feb 2014 11:12:51 +0530 Message-ID: <52F4725B.4030208@intel.com> References: <1390969547-1018-1-git-send-email-benjamin.widawsky@intel.com> <1390969547-1018-3-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 26721FB758 for ; Thu, 6 Feb 2014 21:42:53 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org To: benjamin.widawsky@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Wed, Jan 29, 2014 at 9:55 AM, Ben Widawsky > > wrote: > > It wasn't ever used by the caller anyway with the exception of what we > show in sysfs. > > Signed-off-by: Ben Widawsky > > --- > drivers/gpu/drm/i915/intel_pm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c > b/drivers/gpu/drm/i915/intel_pm.c > index bcbdac2..258241b 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -3161,7 +3161,7 @@ int intel_enable_rc6(const struct drm_device *dev) > if (INTEL_INFO(dev)->gen == 5) > return 0; > > - if (IS_IVYBRIDGE(dev) || IS_VALLEYVIEW(dev)) > + if (IS_IVYBRIDGE(dev)) > return (INTEL_RC6_ENABLE | INTEL_RC6p_ENABLE); > else > return INTEL_RC6_ENABLE; > -- > 1.8.5.3 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/intel-gfx I think, we can avoid else condition and return INTEL_RC6_ENABLE if the other platform checks fails? Reviewed-by: Deepak S