Re: [PATCH 08/12] drm/i915/bdw: Extract rp_state_caps logic

Chris Wilson
2014-03-20T07:28:32Z

On Wed, Mar 19, 2014 at 06:31:15PM -0700, Ben Widawsky wrote:
> We have a need for duplicated parsing of the RP_STATE_CAPS register (and
> the setting of the associated fields). To reuse some code, we can
> extract the function into a simple helper.
>
> This patch also addresses the fact that we missed doing this for gen8,
> something we should have done anyway.
>
> This could be two patches, one to extract, and one to add gen8, but it's
> trivial enough that I think one is fine. I will accept a request to
> split it. Please notice the fix addressed by v2 below.
>
> Valleyview is left untouched because it is different.
>
> v2: Logically rebased on top of
> commit dd0a1aa19bd3d7203e58157b84cea78bbac605ac
> Author: Jeff McGee <jeff.mcgee@intel.com>
> Date: Tue Feb 4 11:32:31 2014 -0600
>
> drm/i915: Restore rps/rc6 on reset
>
> Note with the above change the fix for gen8 is also handled (which was
> not the case in Jeff's original patch).
>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

By setting max_freq_soft before querying overclocking frequencies, we
force the user to have to manually raise the max freq through sysfs,
right? Hasn't the user already explicitly asked for overclocking through
the BIOS setting in the first place, so isn't that a needless burden
upon the user?
-Chris

--
Chris Wilson, Intel Open Source Technology Centre