From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kenneth Graunke Subject: Re: [PATCH] uxa: Support BLT ring flushes on Broadwell, but not render ring flushes. Date: Tue, 18 Mar 2014 10:08:56 -0700 Message-ID: <53287DA8.3070109@whitecape.org> References: <1395073636-2484-1-git-send-email-kenneth@whitecape.org> <20140318082950.GC12972@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1146458741==" Return-path: Received: from homiemail-a6.g.dreamhost.com (caiajhbdccac.dreamhost.com [208.97.132.202]) by gabe.freedesktop.org (Postfix) with ESMTP id C8DAB8E373 for ; Tue, 18 Mar 2014 10:08:45 -0700 (PDT) In-Reply-To: <20140318082950.GC12972@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============1146458741== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C0ShtCuWVlSclmDTriHMX86L1nFW7UOEA" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --C0ShtCuWVlSclmDTriHMX86L1nFW7UOEA Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 03/18/2014 01:29 AM, Chris Wilson wrote: > On Mon, Mar 17, 2014 at 09:27:16AM -0700, Kenneth Graunke wrote: >> Chris, >> >> In the future, if you're going to rewrite significant portions of my >> patches, could you please at least put your Signed-off-by or something= >> on it? In the version of "uxa: Enable BLT acceleration on Broadwell."= , >> you committed, at least half the patch was not actually written by me,= >> and the resulting code either hit assertion failures or GPU hangs if >> run at all. >> >> It's pretty disconcerting to see code committed under my name, with my= >> Signed-off-by, that doesn't work and which I've never even seen before= =2E >=20 > I do apologise that you felt I made substantive changes to the patch. A= s > far I was concerned the addition of the libdrm_intel version bump in > configure (a vital build fix), the change in if-else cascade (cosmetic)= > and the only functional change of disabling TexturedVideo for gen8+ wer= e > trivial. >=20 > The fact that the original patch made an assumption that was then broke= n > by not applying the first patch in the series was not altered by those > changes. And I should have realised that at the time. > -Chris Definitely thanks for those fixes! I should've remembered the libdrm requirement bump. Also, thanks for taking the patches. --Ken --C0ShtCuWVlSclmDTriHMX86L1nFW7UOEA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJTKH2wAAoJEFtb2gcdScw4aEQQAJxz6xAU3VeIYvY4NomWXHHA Nnmz130z5rlBPCA61Ejn7hHKayiEilf6PEShrMEtWMOmh5bPY2IMaEsUeCz16xpk fASD3j/h+Fe/355b6NMBXcQ4NzYMXcaTXr4xQRWfkEtLR3tHv/Ct5lNKDephsHbb lHY6zgfhsbRIBMryZ87St+TPTAnhnPwF99Z88++5ojQZ+04Tr6LeLL9eO2Eyf0Q2 tG0YMUXxnBZSclOxp/qlgQCI2Xteg131z6mHoELig6pl5t4ovWqIBh4J9f7uIxrk ifq6MVg6ghSgdu3pA4crhLjkD9ypC49HlpMkdrNwz7gt2VK2Ta0Nn2i6i9sJTU1b Tc8a9MQNEyaGzhnrB4AxzsKPEjaNO4M612/faS9z4RqIoBQjhWT/DcXt38k4kYwF lQUGJsyK03RVlt+VriAsDRufFkGWA32iN+nh16UvLYTYvFVg3nyKmDQyMnmVHUR7 aubTcguTMSXTIyNjKONZVT20GQw5n+BjCWfjMUSAdW4yyh3OnMwzwkn+aSUBwfhH aEp6MzZ1EGoOSAd4sQqO2hhu8WMiDh9Cm96W5mil7lciWtP5fLqwK+MhaILSmX7/ JJ+Uw2+WQBdcyw2xpIZ5yNhhZnguObKZLnflnWwaHSlqon/2yhrA+/c5rdkwExxm 1UIWolI5knk6Rd/HHIHp =HUJw -----END PGP SIGNATURE----- --C0ShtCuWVlSclmDTriHMX86L1nFW7UOEA-- --===============1146458741== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx --===============1146458741==--