From mboxrd@z Thu Jan  1 00:00:00 1970
From: Timo Aaltonen <timo.aaltonen@canonical.com>
Subject: Re: [PATCH] drm/i915/bdw: Restore PPAT on thaw
Date: Wed, 19 Mar 2014 10:39:03 +0200
Message-ID: <532957A7.6030703@canonical.com>
References: <1395184177-10673-1-git-send-email-benjamin.widawsky@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from youngberry.canonical.com (youngberry.canonical.com
 [91.189.89.112])
 by gabe.freedesktop.org (Postfix) with ESMTP id CB0746F94A
 for <intel-gfx@lists.freedesktop.org>; Wed, 19 Mar 2014 01:39:06 -0700 (PDT)
In-Reply-To: <1395184177-10673-1-git-send-email-benjamin.widawsky@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Ben Widawsky <benjamin.widawsky@intel.com>, Intel GFX <intel-gfx@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org

On 19.03.2014 01:09, Ben Widawsky wrote:
> Apparently it is wiped out from under us, and we get some really fun
> caching artifacts upon resume (it seems to be WB for all types by
> default).
> 
> Reported-by: James Ausmus <james.ausmus@intel.com>
> Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

Excellent!

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=76113
Tested-by: Timo Aaltonen <timo.aaltonen@canonical.com>

> ---
>  drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index bd016e2..1b45a04 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -30,6 +30,8 @@
>  #include "i915_trace.h"
>  #include "intel_drv.h"
>  
> +static void gen8_setup_private_ppat(struct drm_i915_private *dev_priv);
> +
>  bool intel_enable_ppgtt(struct drm_device *dev, bool full)
>  {
>  	if (i915.enable_ppgtt == 0 || !HAS_ALIASING_PPGTT(dev))
> @@ -1371,8 +1373,10 @@ void i915_gem_restore_gtt_mappings(struct drm_device *dev)
>  	}
>  
>  
> -	if (INTEL_INFO(dev)->gen >= 8)
> +	if (INTEL_INFO(dev)->gen >= 8) {
> +		gen8_setup_private_ppat(dev_priv);
>  		return;
> +	}
>  
>  	list_for_each_entry(vm, &dev_priv->vm_list, global_link) {
>  		/* TODO: Perhaps it shouldn't be gen6 specific */
> 


-- 
timo.aaltonen@canonical.com