From mboxrd@z Thu Jan 1 00:00:00 1970 From: Deepak S Subject: Re: [PATCH 03/12] drm/i915: Store the HW min frequency as min_freq Date: Mon, 24 Mar 2014 16:01:17 +0530 Message-ID: <53300975.3000700@linux.intel.com> References: <1392692512-2268-1-git-send-email-benjamin.widawsky@intel.com> <1395279079-12704-1-git-send-email-benjamin.widawsky@intel.com> <1395279079-12704-4-git-send-email-benjamin.widawsky@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id E63D66E956 for ; Mon, 24 Mar 2014 03:29:57 -0700 (PDT) In-Reply-To: <1395279079-12704-4-git-send-email-benjamin.widawsky@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ben Widawsky , Intel GFX List-Id: intel-gfx@lists.freedesktop.org On Thursday 20 March 2014 07:01 AM, Ben Widawsky wrote: > this leaves a temporarily awkward min_delay (the soft limit) with the > new min_freq (the hardware limit). It's fixed in the next patch. > > Signed-off-by: Ben Widawsky > --- > drivers/gpu/drm/i915/i915_drv.h | 1 + > drivers/gpu/drm/i915/intel_pm.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h > index 9cd870f..241f5e1 100644 > --- a/drivers/gpu/drm/i915/i915_drv.h > +++ b/drivers/gpu/drm/i915/i915_drv.h > @@ -987,6 +987,7 @@ struct intel_gen6_power_mgmt { > u8 rp1_delay; > u8 rp0_delay; > u8 hw_max; > + u8 min_freq; > > bool rp_up_masked; > bool rp_down_masked; > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c > index dd3a121..dd631d1 100644 > --- a/drivers/gpu/drm/i915/intel_pm.c > +++ b/drivers/gpu/drm/i915/intel_pm.c > @@ -3354,7 +3354,7 @@ static void gen6_enable_rps(struct drm_device *dev) > > /* In units of 50MHz */ > dev_priv->rps.hw_max = hw_max = rp_state_cap & 0xff; > - hw_min = (rp_state_cap >> 16) & 0xff; > + dev_priv->rps.min_freq = hw_min = (rp_state_cap >> 16) & 0xff; > dev_priv->rps.rp1_delay = (rp_state_cap >> 8) & 0xff; > dev_priv->rps.rp0_delay = (rp_state_cap >> 0) & 0xff; > dev_priv->rps.rpe_delay = dev_priv->rps.rp1_delay; Reviewed-by: Deepak S Reviewed-by: Deepak S